Received-SPF: pass (google.com: domain of linux-kernel+bounces-3741-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <26207725d5025318b831dd5a5feca67248aaa221.camel@sipsolutions.net>
Subject: Re: [PATCH] bcma,ssb: simplify dependency handling for bcma and ssb
 drivers
From: Johannes Berg <johannes@sipsolutions.net>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>, 
 =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <zajec5@gmail.com>, "David S . Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
 <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Kalle Valo
 <kvalo@kernel.org>, Larry Finger <Larry.Finger@lwfinger.net>, Arend van
 Spriel <aspriel@gmail.com>, Franky Lin <franky.lin@broadcom.com>, Hante
 Meuleman <hante.meuleman@broadcom.com>,  Michael Buesch <m@bues.ch>,
 linux-wireless@vger.kernel.org, netdev@vger.kernel.org, 
 b43-dev@lists.infradead.org, brcm80211-dev-list.pdl@broadcom.com, 
 SHA-cyfmac-dev-list@infineon.com
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Mon, 18 Dec 2023 14:17:59 +0100
In-Reply-To: <20231218115802.15859-1-lukas.bulwahn@gmail.com>
References: <20231218115802.15859-1-lukas.bulwahn@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.2 (3.50.2-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2023-12-18 at 12:58 +0100, Lukas Bulwahn wrote:

Dunno, I'm not super involved with this but ...

> +++ b/drivers/bcma/Kconfig
> @@ -1,12 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0
> -config BCMA_POSSIBLE
> -	bool
> -	depends on HAS_IOMEM && HAS_DMA
> -	default y
> -
>  menuconfig BCMA
>  	tristate "Broadcom specific AMBA"
> -	depends on BCMA_POSSIBLE
> +	depends on HAS_IOMEM && HAS_DMA

[...]
>  config BRCMSMAC
>  	tristate "Broadcom IEEE802.11n PCIe SoftMAC WLAN driver"
> -	depends on MAC80211
> -	depends on BCMA_POSSIBLE
> +	depends on HAS_IOMEM && HAS_DMA && MAC80211
>  	select BCMA

to me it kind of seems more obvious for example in this case to say
"depend on BCMA_POSSIBLE and select BCMA" rather than open-coding the
BCMA dependencies both here and in BCMA? Now granted, they're rather
unlikely to _change_, but it still seems more obvious?

johannes