Received-SPF: pass (google.com: domain of linux-kernel+bounces-3745-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <1cea5a82-0868-44bb-950c-5d5b6e124e39@suse.de>
Date: Mon, 18 Dec 2023 16:25:44 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] net: mana: select PAGE_POOL
Content-Language: en-US
To: Yury Norov <yury.norov@gmail.com>, "K. Y. Srinivasan"
 <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>,
 Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
 Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>,
 linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20231215203353.635379-1-yury.norov@gmail.com>
From: Denis Kirjanov <dkirjanov@suse.de>
In-Reply-To: <20231215203353.635379-1-yury.norov@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 12/15/23 23:33, Yury Norov wrote:
> Mana uses PAGE_POOL API. x86_64 defconfig doesn't select it:
> 
> ld: vmlinux.o: in function `mana_create_page_pool.isra.0':
> mana_en.c:(.text+0x9ae36f): undefined reference to `page_pool_create'
> ld: vmlinux.o: in function `mana_get_rxfrag':
> mana_en.c:(.text+0x9afed1): undefined reference to `page_pool_alloc_pages'
> make[3]: *** [/home/yury/work/linux/scripts/Makefile.vmlinux:37: vmlinux] Error 1
> make[2]: *** [/home/yury/work/linux/Makefile:1154: vmlinux] Error 2
> make[1]: *** [/home/yury/work/linux/Makefile:234: __sub-make] Error 2
> make[1]: Leaving directory '/home/yury/work/build-linux-x86_64'
> make: *** [Makefile:234: __sub-make] Error 2
> 
> So we need to select it explicitly.
> 
Fixes: ca9c54d2 ("net: mana: Add a driver for Microsoft Azure Network Adapter")
> Signed-off-by: Yury Norov <yury.norov@gmail.com>