Received-SPF: pass (google.com: domain of linux-kernel+bounces-3776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <202312072018+0800-wangjinchao@xfusion.com>
In-Reply-To: <202312072018+0800-wangjinchao@xfusion.com>
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Mon, 18 Dec 2023 14:51:11 +0100
Message-ID: <CAKfTPtD-rRsUr+P-vjzMDcKfx8Vnb_vLxjCOb5ZPvF5g2LpVzw@mail.gmail.com>
Subject: Re: [PATCH] sched/headers: Remove duplicated struct rq declare
To: WangJinchao <wangjinchao@xfusion.com>
Cc: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>, 
	Juri Lelli <juri.lelli@redhat.com>, Dietmar Eggemann <dietmar.eggemann@arm.com>, 
	Steven Rostedt <rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>, 
	Daniel Bristot de Oliveira <bristot@redhat.com>, Valentin Schneider <vschneid@redhat.com>, linux-kernel@vger.kernel.org, 
	stone.xulei@xfusion.com
Content-Type: text/plain; charset="UTF-8"

On Thu, 7 Dec 2023 at 13:20, WangJinchao <wangjinchao@xfusion.com> wrote:
>
> `struct rq` has been declared at the top of the file,
> so remove the second declaration.
>
> Signed-off-by: WangJinchao <wangjinchao@xfusion.com>

Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>

> ---
>  kernel/sched/sched.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 2e5a95486a42..349c90554bd8 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -931,7 +931,6 @@ struct uclamp_rq {
>  DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
>  #endif /* CONFIG_UCLAMP_TASK */
>
> -struct rq;
>  struct balance_callback {
>         struct balance_callback *next;
>         void (*func)(struct rq *rq);
> --
> 2.40.0
>