Received-SPF: pass (google.com: domain of linux-kernel+bounces-3885-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20231218115802.15859-1-lukas.bulwahn@gmail.com>
 <26207725d5025318b831dd5a5feca67248aaa221.camel@sipsolutions.net> <87o7ensgjv.fsf@kernel.org>
In-Reply-To: <87o7ensgjv.fsf@kernel.org>
From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Date: Mon, 18 Dec 2023 16:03:54 +0100
Message-ID: <CAKXUXMxh3rM8da9kJG_=Sy8fQqqf7f8xXaHDHPLvpvRiYg1e5w@mail.gmail.com>
Subject: Re: [PATCH] bcma,ssb: simplify dependency handling for bcma and ssb drivers
To: Kalle Valo <kvalo@kernel.org>
Cc: Johannes Berg <johannes@sipsolutions.net>, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>, 
	"David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, 
	Larry Finger <Larry.Finger@lwfinger.net>, Arend van Spriel <aspriel@gmail.com>, 
	Franky Lin <franky.lin@broadcom.com>, Hante Meuleman <hante.meuleman@broadcom.com>, 
	Michael Buesch <m@bues.ch>, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, 
	b43-dev@lists.infradead.org, brcm80211-dev-list.pdl@broadcom.com, 
	SHA-cyfmac-dev-list@infineon.com, kernel-janitors@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 18, 2023 at 3:59=E2=80=AFPM Kalle Valo <kvalo@kernel.org> wrote=
:
>
> Johannes Berg <johannes@sipsolutions.net> writes:
>
> > On Mon, 2023-12-18 at 12:58 +0100, Lukas Bulwahn wrote:
> >
> > Dunno, I'm not super involved with this but ...
> >
> >> +++ b/drivers/bcma/Kconfig
> >> @@ -1,12 +1,7 @@
> >>  # SPDX-License-Identifier: GPL-2.0
> >> -config BCMA_POSSIBLE
> >> -    bool
> >> -    depends on HAS_IOMEM && HAS_DMA
> >> -    default y
> >> -
> >>  menuconfig BCMA
> >>      tristate "Broadcom specific AMBA"
> >> -    depends on BCMA_POSSIBLE
> >> +    depends on HAS_IOMEM && HAS_DMA
> >
> > [...]
> >>  config BRCMSMAC
> >>      tristate "Broadcom IEEE802.11n PCIe SoftMAC WLAN driver"
> >> -    depends on MAC80211
> >> -    depends on BCMA_POSSIBLE
> >> +    depends on HAS_IOMEM && HAS_DMA && MAC80211
> >>      select BCMA
> >
> > to me it kind of seems more obvious for example in this case to say
> > "depend on BCMA_POSSIBLE and select BCMA" rather than open-coding the
> > BCMA dependencies both here and in BCMA? Now granted, they're rather
> > unlikely to _change_, but it still seems more obvious?
>
> I was thinking the same. Lukas, is there a specific reason why you want
> to change this or this just something you noticed by chance?
>

I just noticed this by chance---well, I was wondering what these
config symbols were doing in my kernel build configuration (they are
actually in every config). While reading through the code, I was
confused on what the dependencies were trying to tell me, as the
config symbols and conditions seemed to repeat over and over in
different places.

I thought it was worth a clean up and this was the patch I came up
with in the end.

Lukas