Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757661AbXLGUFj (ORCPT ); Fri, 7 Dec 2007 15:05:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755183AbXLGUFb (ORCPT ); Fri, 7 Dec 2007 15:05:31 -0500 Received: from filer.fsl.cs.sunysb.edu ([130.245.126.2]:34698 "EHLO filer.fsl.cs.sunysb.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751981AbXLGUFa (ORCPT ); Fri, 7 Dec 2007 15:05:30 -0500 Date: Fri, 7 Dec 2007 15:05:12 -0500 Message-Id: <200712072005.lB7K5Cre013747@agora.fsl.cs.sunysb.edu> From: Erez Zadok To: "J. Bruce Fields" Cc: Erez Zadok , linux-kernel@vger.kernel.org, nfs@lists.sourceforge.net, "Eric W. Biederman" , Andrew Morton Subject: Re: [NFS] NFSv2/3 broken exporting/mounting (permission denied) in 2.6.24-rc4 In-reply-to: Your message of "Thu, 06 Dec 2007 21:55:04 EST." <20071207025504.GA3070@fieldses.org> X-MailKey: Erez_Zadok Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2841 Lines: 65 In message <20071207025504.GA3070@fieldses.org>, "J. Bruce Fields" writes: > On Thu, Dec 06, 2007 at 09:20:41PM -0500, Erez Zadok wrote: > > I get a "permission denied" when trying to mount a localhost nfsv2/3 > > exported volume, on v2.6.24-rc4-124-gf194d13. It works w/ nfsv4 mounting. > > It worked fine in 2.6.24-rc3. Here's a sequence of ops I tried: > > > > # mount -t ext2 /dev/hdb1 /n/lower/b0 > > # exportfs -o no_root_squash,rw localhost:/n/lower/b0 > > # mount -t nfs -o nfsvers=3 localhost:/n/lower/b0 /mnt > > What do you see if you watch the network traffic in ethereal? > > --b. Bruce, I'm using nfs-utils-1.0.10-14.fc6 on an FC6 system with all latest FC6 patches. Using git-bisect I was able to find the patch which broke it: commit 2b1e300a9dfc3196ccddf6f1d74b91b7af55e416 Author: Eric W. Biederman Date: Sun Dec 2 00:33:17 2007 +1100 [NETNS]: Fix /proc/net breakage Well I clearly goofed when I added the initial network namespace support for /proc/net. Currently things work but there are odd details visible to user space, even when we have a single network namespace. Since we do not cache proc_dir_entry dentries at the moment we can just modify ->lookup to return a different directory inode depending on the network namespace of the process looking at /proc/net, replacing the current technique of using a magic and fragile follow_link method. To accomplish that this patch: - introduces a shadow_proc method to allow different dentries to be returned from proc_lookup. - Removes the old /proc/net follow_link magic - Fixes a weakness in our not caching of proc generic dentries. As shadow_proc uses a task struct to decided which dentry to return we can go back later and fix the proc generic caching without modifying any code that uses the shadow_proc method. Signed-off-by: Eric W. Biederman Cc: "Rafael J. Wysocki" Cc: Pavel Machek Cc: Pavel Emelyanov Cc: "David S. Miller" Cc: Ingo Molnar Signed-off-by: Andrew Morton Signed-off-by: Herbert Xu With the above patch, rpc.mountd is unable to open /proc/fs/nfsd/filehandle. Strace shows: open("/proc/fs/nfsd/filehandle", O_RDWR|O_LARGEFILE) = -1 ENOENT (No such file or directory) Without the above patch, /proc/fs/nfsd is populated with a number of files, including "filehandle". Erez. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/