Received: by 2002:a05:7412:8d06:b0:f9:332d:97f1 with SMTP id bj6csp10451rdb; Mon, 18 Dec 2023 07:37:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBNP9TrftHc8koWUY13HnJNwMrY0HQDezA66iluF5b5/W2tXYieTUqO37Yi855a3sNmeQa X-Received: by 2002:a05:6a20:429f:b0:18f:c3ea:2904 with SMTP id o31-20020a056a20429f00b0018fc3ea2904mr8213146pzj.33.1702913838268; Mon, 18 Dec 2023 07:37:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702913838; cv=none; d=google.com; s=arc-20160816; b=POkKqdcSLvXrta5jJ6yAyqiJXTGSTOYIvrsVx14AXcGqFcaMm+2Inhd7oUxm4GSiPD kPd+ErqYac1Vgh6NVhwUFpK0m7rjnxQAyUS8wv+fTOfogXEiL3NR1/GbarLFU9+4jU2H wsTPu2XdrIlLtBaRy0aeG7teZPQx9CXSxS+w/+bdDogpllmowuYi8rMKi3wLbvZjW/wB 5nQfwXu953wcgBKquDVriOVNYaUytqK5uwsCfZb22T6u9L5rEMFCoTV36PQUNQAY/mS1 afFnIV9yNsggHjxd+t8DBwe1Nh5MndZXp7QjqFam2H51hp82KLfOLRYDCk6WToj4XXGy AbSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Lw7xp95AelvvA4AjWwOhdcJ2KPtPHGi1JqNkB2EsLRA=; fh=kcgU0zlDUgnimr+i6v94uJFjD+ehLkZVEFcAQhWFiNM=; b=xb/HbyiMD1fAVMc8+sWzSfj6iCVZ8h34cTymxzct5PYEVKTdr14dOMh5FngtWD9Vfn tWGAjc/WWyosYwXPdxCEwZCxFF5NBZBiqf8vRTiIFDmQsTX3zZTTXtG0beEoJ94yLQQU r3dy5DHTEb4qgkWjhV8lM5LXLDFjZVUzez6RqDtTZnKhE7spzdp4pR64sUM+I6rKgsoL QvpjBLA7Z9jucwEIrLR0xG+v1Lckdnsk7I6sk2qK0+r1IWFoJTy+8U/xuHI2KU3uzuAj ChSVCTEqk27+onAximV/r2P0u3HASEh3Ovh1/5WbbkKcaFhektZ1fPU19PhhkQ04Bd5C lZkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WutFymaG; spf=pass (google.com: domain of linux-kernel+bounces-3941-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3941-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d4-20020a170902b70400b001d052b098a3si18006293pls.537.2023.12.18.07.37.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 07:37:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-3941-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WutFymaG; spf=pass (google.com: domain of linux-kernel+bounces-3941-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-3941-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 77B40B23475 for ; Mon, 18 Dec 2023 15:35:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 25B983D576; Mon, 18 Dec 2023 15:35:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WutFymaG" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54E2E3A1B6; Mon, 18 Dec 2023 15:35:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 325FEC433C9; Mon, 18 Dec 2023 15:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702913739; bh=/PRzWW+61bm8JeOBeRvqEJXgxir+CIm2dpn3TWN4lv8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WutFymaGf0kheSzw6iK7t4JsxJsPTWfvgOABhP380FO7j6yCB08/b4ALn9Br1doXg hnz9gmt5M5m07rN+2po3GKTfcr8BZ4Zyb+/A8V76pR/QKXh09RiJTAymWYm9UpXJIN ORqbujQcMxIt3uyHz0QczEzh9AsjpsH5cVhdNcklYgebLPJHmxLFE2n7CDntE1ZyNG ZDMkrgnh4NaK86wgeYywwS5KrvbieFmPdaKRIKqnvj5lNH9TbNhM6ELglU+EL0lVXk 4LEjySawQ4F3lX02rdymekEIaGkAOjT645We7aGKsfI6ld2eoiA7gNNE3piMdw/3+F 4r7DsUVT8hTGw== Date: Mon, 18 Dec 2023 15:35:33 +0000 From: Simon Horman To: Jijie Shao Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shenjian15@huawei.com, wangjie125@huawei.com, liuyonglong@huawei.com, lanhao@huawei.com, wangpeiyang1@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 net-next 4/4] net: hns3: move constants from hclge_debugfs.h to hclge_debugfs.c Message-ID: <20231218153533.GE6288@kernel.org> References: <20231216070018.222798-1-shaojijie@huawei.com> <20231216070018.222798-5-shaojijie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231216070018.222798-5-shaojijie@huawei.com> On Sat, Dec 16, 2023 at 03:00:18PM +0800, Jijie Shao wrote: > some constants are defined in hclge_debugfs.h, > but only used in hclge_debugfs.c. > so move them from hclge_debugfs.h to hclge_debugfs.c. > > Signed-off-by: Jijie Shao Thanks Jijie, this looks good, but I think it should come before patch 2/4, to avoid warnings about unused symbols being flagged until this patch is applied. ...