Received-SPF: pass (google.com: domain of linux-kernel+bounces-4007-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <9469ccaa-d05a-1c9d-4350-841de7c03ae0@axis.com>
Date: Mon, 18 Dec 2023 17:00:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 2/2] iio: light: vcnl4000: Add ps high definition for
 vcnl4040
Content-Language: en-US
From: =?UTF-8?Q?M=c3=a5rten_Lindahl?= <martenli@axis.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
 kernel@axis.com, linux-kernel@vger.kernel.org
References: <20231212-vcnl4000-ps-hd-v1-0-1c62a95828c0@axis.com>
 <20231212-vcnl4000-ps-hd-v1-2-1c62a95828c0@axis.com>
 <20231217141554.04c8863d@jic23-huawei>
 <45bb38c9-63f9-101e-60e5-36037699f11e@axis.com>
In-Reply-To: <45bb38c9-63f9-101e-60e5-36037699f11e@axis.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TE1sZURWczNxdk4yYVJZa09Xd3kyancxK0twd0l3Z25QeGVra2pORTY3WUVL?=
 =?utf-8?B?NkZlV1VvaDlKOXJEUTFiLzZTNTdsMFJGNUNHL1dRb2xESmY3dStzdys2T29s?=
 =?utf-8?B?bWhrRzZGUHZKUXlJcFpTNlUvaDNNSU9vZFFXTWJDMTVqMnpZcnA0WkRZNllo?=
 =?utf-8?B?dHAyZFRiaTlkOUJBUjYyNzk4dnp5aTkxRU9iV1AwdThPRFErMDNTM1Z6WUZO?=
 =?utf-8?B?Q0RjcnFzK1hnbDl4RitzMUpyaXpadzdmZ2xsem9GdFprR1htNUVHQUNldll6?=
 =?utf-8?B?YTcxZEJubmlCelZsNDROYWN0YlFFZVJpSk9zZThXWENQK3o1aTRpWWtodWFV?=
 =?utf-8?B?d1gzeWdaY250VWR6eUlXakxCTit6elBsSkFwK2tkZCsvQzd1V2MrSHpoTEtm?=
 =?utf-8?B?K1p1bGZ0TXB5T3ZZZ2ZCeUZ1elEvaUIrOWE0a21LVUgyZFd4VUx3Z092MThV?=
 =?utf-8?B?K09Kamg1alVEUkY1NFdTRFphUnJ1Z3JXYXpZTWJ0NFhjblFBU2c0VjZERmZq?=
 =?utf-8?B?d0tHTzRsdXRBYVdEandrKzJxdnIvSHZJOTRQRFFNNEJwZWd2VGlQeHBRdEdQ?=
 =?utf-8?B?eForVHh5R3B6YjVSdFJmTU1EeG1BYUtaZ3ZKeEZuNE5jdmlITElYZENMenRG?=
 =?utf-8?B?US9zVlo3OXpWRDBscFB2WGg3L2lISUFtWHRIMXd4ZUVVN243UWhBU3RnbjRR?=
 =?utf-8?B?aEtzYTh0MlFUVVprd1pFZU5jMnh4QkxnNzdXcmU3OUcrL3BIVkdUMFdQOTRU?=
 =?utf-8?B?bk9mN2FaMG5kMnJKbWJiN2xyR0FtSXRRSDM1NFBoR1U4dmJEdFZVQ21ML0pI?=
 =?utf-8?B?NWprdGJ6UDRPYVladzdDZlcyZ2lCTVhkOHM3VHhOT0JlMnUvS0tkdUltcjhL?=
 =?utf-8?B?SVpWaFlBS24wVERqKzdPYWY4ckkyVlBtazNhWUVzT3NQdjYyOGVwdi82cm9h?=
 =?utf-8?B?cnU0Mk9Fd3dla2Zvd0RxUjVhb1d3d2ZDUkVsYjdwclZ3RVVmWk43TWxkbkxq?=
 =?utf-8?B?cGcvb3BhbmZ4Z1duRkhVb1BaV3FXMVpkSFJnUExJNjBXUUx0UHNrZlVDdnY1?=
 =?utf-8?B?VlIrS0R4WDY0ckVVMUprNjEvVlV4NHpVOUhzZldBZENGbjVkMVcxUXZ4TG5w?=
 =?utf-8?B?cmU0MHVnOFVEaTltRHFJSXNUSFBSOGtZSUxvTlZoOHBXbFVrUU5jZjd0TUgw?=
 =?utf-8?B?QllkTnVHelhPV3h2SFJzY2NLajBVckQzd2cwakQrV2k5WlFhYU5QdXF5WDdZ?=
 =?utf-8?B?R0JCRlJrSFJ2Z05zZDVheUdvbVE4OWZTSlVjL3Y5ZG8rRC9FVnBkNlhaU0hY?=
 =?utf-8?B?Y3hKd01nK0tVMUozNERqcmJCbExveEppWll2MWY2dmZJUWs3cVNnd2xKWlNN?=
 =?utf-8?B?Znd3c2FVZnM3NnVBZjlUeW9Lczg3R08zamJranJuSkJPVlVyaG1RdW9aR3Nq?=
 =?utf-8?B?M0VoSlZRZVpjRFgwVXBvbzRvdDZjMUdlZ0RieDBHSEVvMCtwWi9tNGVKZ3N6?=
 =?utf-8?B?b3VneGpITjBwbjgxOGs4bGorLzE1dUlyTDBSYkxJc0tSUGs1dDgvMlNmdmgy?=
 =?utf-8?B?YlhCWmxSYjNITm9GSzhCQmNzMUo5T2lOWVEvd29BTnhudm1QVnB0QmJablVC?=
 =?utf-8?B?ZlppaHBrRTVxSkZrSjc3ZzdLeHcxU3NkNG5pOHRjSjJWMDBKRFhDUnlMVEF2?=
 =?utf-8?B?ZVN1YzhLdisyVUgyaUpqejRWUWtNVlVUeUMxV21zZE1TbUg5cEZudWtGc1FS?=
 =?utf-8?B?R3BLdjBTS3NkVWpxMTh1MktaaEdqa1pNZzE2OTI5MUdjTHk4QzVIdTA4OXBQ?=
 =?utf-8?B?OU54UFpLYUwvWGExRW8rSVVKVk1yMUpaYi9TdGxJbWlMYUgrVTRsN2l5MmVp?=
 =?utf-8?B?Z1EyTGFXaUsyanpaQVF3aTFyRUFCa1QvV1hLS2dwdDVncVRGNjE2SkZIc0hY?=
 =?utf-8?B?dW9DZlRzcmFQbnQ5Sk80ZG1kdlhFei9PaWs4b0loY0I0aFBBaG5kS0RMNUpo?=
 =?utf-8?B?cmNMMExqdXpaZm5lbitJZm9xNXZkcjRsaUpmNlBtejVMaU1hTFFuVnRlMXpr?=
 =?utf-8?B?ZHUxdzlqVzZnbjFraHFsVGpBY0ZjSmw4bjJuRi9SOUNKVVdhalpIUW5waEI0?=
 =?utf-8?Q?pP8GL01G0nxw0dxRSztPgVwt4?=
X-OriginatorOrg: axis.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3229f64-b992-467e-5be6-08dbffe26ac8
X-MS-Exchange-CrossTenant-AuthSource: AS8PR02MB9529.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 16:00:12.3472
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oiLV7DYGh0MahoimCQShYDQawIdkRJtGjMWzVRpYSvzovhyla1ryj9g9jO2sRsarFGYmXL9Q8zalR32hgg/tKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR02MB6569

On 12/18/23 16:19, Mårten Lindahl wrote:
> On 12/17/23 15:15, Jonathan Cameron wrote:
>> On Fri, 15 Dec 2023 13:43:05 +0100
>> Mårten Lindahl <marten.lindahl@axis.com> wrote:
>>
>>> The vcnl4040 proximity sensor defaults to 12 bit data resolution, but
>>> the chip also supports 16 bit data resolution, which is called 
>>> proximity
>>> high definition (PS_HD).
>>>
>>> Add read/write attribute for proximity resolution, and read attribute
>>> for available proximity resolution values for the vcnl4040 chip.
>>>
>>> Signed-off-by: Mårten Lindahl <marten.lindahl@axis.com>
> Hi Jonathan!
>> I'll review this on basis the usecase is clear (see reply to cover 
>> letter)
>
> I'll skip this patch (see reply to cover letter comment)
>
> Your are right about the paired register manipulation. Better to 
> read/write byte instead of word.

Hi Jonathan!

I now remember why the register is read as a word (CONF1/CONF2). It is 
addressed as one 16 bit register where CONF1 is the low 8 bit field and 
CONF2 is the high bit field. It is the same address/code for both:

Register PS_CONF1 - COMMAND CODE: 0x03_L (0x03 DATA BYTE LOW)

Register PS_CONF2 - COMMAND CODE: 0x03_H (0x03 DATA BYTE HIGH)

Where in my case (PS_CONF2->PS_HD[3] is the same as PS_CONF1[11])

Kind regards

Mårten

>
> Kind regards
>
> Mårten
>
>>
>> The manipulation of the CONF1 and CONF2 registers in a pair is rather 
>> odd given you
>> only want to change one bit here.
>>
>> Why is that done?
>>> ---
>>>   drivers/iio/light/vcnl4000.c | 87 
>>> +++++++++++++++++++++++++++++++++++++++++++-
>>>   1 file changed, 85 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/iio/light/vcnl4000.c 
>>> b/drivers/iio/light/vcnl4000.c
>>> index fdf763a04b0b..2addff635b79 100644
>>> --- a/drivers/iio/light/vcnl4000.c
>>> +++ b/drivers/iio/light/vcnl4000.c
>>> @@ -90,6 +90,7 @@
>>>   #define VCNL4040_PS_CONF1_PS_SHUTDOWN    BIT(0)
>>>   #define VCNL4040_PS_CONF2_PS_IT    GENMASK(3, 1) /* Proximity 
>>> integration time */
>>>   #define VCNL4040_CONF1_PS_PERS    GENMASK(5, 4) /* Proximity 
>>> interrupt persistence setting */
>>> +#define VCNL4040_PS_CONF2_PS_HD        BIT(11)    /* Proximity high 
>>> definition */
>>>   #define VCNL4040_PS_CONF2_PS_INT    GENMASK(9, 8) /* Proximity 
>>> interrupt mode */
>>>   #define VCNL4040_PS_CONF3_MPS        GENMASK(6, 5) /* Proximity 
>>> multi pulse number */
>>>   #define VCNL4040_PS_MS_LED_I        GENMASK(10, 8) /* Proximity 
>>> current */
>>> @@ -170,6 +171,11 @@ static const int vcnl4040_ps_calibbias_ua[][2] = {
>>>       {0, 200000},
>>>   };
>>>   +static const int vcnl4040_ps_resolutions[2] = {
>>> +    12,
>>> +    16
>>> +};
>>> +
>>>   static const int vcnl4040_als_persistence[] = {1, 2, 4, 8};
>>>   static const int vcnl4040_ps_persistence[] = {1, 2, 3, 4};
>>>   static const int vcnl4040_ps_oversampling_ratio[] = {1, 2, 4, 8};
>>> @@ -880,6 +886,54 @@ static ssize_t 
>>> vcnl4040_write_ps_calibbias(struct vcnl4000_data *data, int val)
>>>       return ret;
>>>   }
>>>   +static ssize_t vcnl4040_read_ps_resolution(struct vcnl4000_data 
>>> *data, int *val, int *val2)
>>> +{
>>> +    int ret;
>>> +
>>> +    ret = i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF1);
>> The field seems to be in PS_CONF2.  So you are reading a word and I 
>> guess that
>> gets you two registers.  Can we not do a byte read to get just CONF2?
>>> +    if (ret < 0)
>>> +        return ret;
>>> +
>>> +    ret = FIELD_GET(VCNL4040_PS_CONF2_PS_HD, ret);
>>> +    if (ret >= ARRAY_SIZE(vcnl4040_ps_resolutions))
>>> +        return -EINVAL;
>>> +
>>> +    *val = vcnl4040_ps_resolutions[ret];
>>> +    *val2 = 0;
>>> +
>>> +    return ret;
>>> +}
>>> +
>>> +static ssize_t vcnl4040_write_ps_resolution(struct vcnl4000_data 
>>> *data, int val)
>>> +{
>>> +    unsigned int i;
>>> +    int ret;
>>> +    u16 regval;
>>> +
>>> +    for (i = 0; i < ARRAY_SIZE(vcnl4040_ps_resolutions); i++) {
>>> +        if (val == vcnl4040_ps_resolutions[i])
>>> +            break;
>>> +    }
>>> +
>>> +    if (i >= ARRAY_SIZE(vcnl4040_ps_resolutions))
>>> +        return -EINVAL;
>>> +
>>> +    mutex_lock(&data->vcnl4000_lock);
>>> +
>>> +    ret = i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF1);
>>> +    if (ret < 0)
>>> +        goto out_unlock;
>>> +
>>> +    regval = (ret & ~VCNL4040_PS_CONF2_PS_HD);
>>> +    regval |= FIELD_PREP(VCNL4040_PS_CONF2_PS_HD, i);
>>> +    ret = i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF1,
>>> +                    regval);
>>> +
>>> +out_unlock:
>>> +    mutex_unlock(&data->vcnl4000_lock);
>>> +    return ret;
>>> +}
>> c),