Received-SPF: pass (google.com: domain of linux-kernel+bounces-4106-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <abf4725b-8569-47f8-a06d-c06285595625@foss.st.com>
Date: Mon, 18 Dec 2023 17:58:32 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/6] dt-bindings: spi: stm32: add st,stm32mp25-spi
 compatible
Content-Language: en-US
To: Alain Volmat <alain.volmat@foss.st.com>, Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue
	<alexandre.torgue@foss.st.com>,
        Erwan Leray <erwan.leray@foss.st.com>
CC: Valentin Caron <valentin.caron@foss.st.com>, <linux-spi@vger.kernel.org>,
        <devicetree@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <20231218155721.359198-1-alain.volmat@foss.st.com>
 <20231218155721.359198-3-alain.volmat@foss.st.com>
From: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
In-Reply-To: <20231218155721.359198-3-alain.volmat@foss.st.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 12/18/23 16:57, Alain Volmat wrote:
> From: Valentin Caron <valentin.caron@foss.st.com>
> 
> Add st,stm32mp25-spi compatible in dt-bindings.  STM32MP25 spi is similar

Hi Alain,
In case you re-submit,
Nitpicking, extra space here could be removed    ^
Capital letters for SPI could also be used here             ^

Appart from that, you can add my:
Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>

Best Regards,
Fabrice

> to the STM32H7 except for the following two points:
>   - Burst should not be enabled with the new DMA used on STM32MP25.
>   - STM32MP25 SPI8 has a limited feature set, it can only send words of
>     8 or 16 bits and with a maximum words number of 1024.
> 
> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> ---
>  Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> index 5754d603f34f..4bd9aeb81208 100644
> --- a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> @@ -25,6 +25,7 @@ properties:
>        - st,stm32f4-spi
>        - st,stm32f7-spi
>        - st,stm32h7-spi
> +      - st,stm32mp25-spi
>  
>    reg:
>      maxItems: 1