Received: by 2002:a05:7412:8d06:b0:f9:332d:97f1 with SMTP id bj6csp65457rdb; Mon, 18 Dec 2023 09:02:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGMG9rZHTD/auyoH68TYoGAgfjVoFQF4y7ai7cRN+dkYK9DXKWzIwGJ8f6+XsvQ7Zsc3EfU X-Received: by 2002:ac8:4e91:0:b0:41e:3e18:e09c with SMTP id 17-20020ac84e91000000b0041e3e18e09cmr22843718qtp.67.1702918975481; Mon, 18 Dec 2023 09:02:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702918975; cv=none; d=google.com; s=arc-20160816; b=gTjFbMAXcL1J9NpaxiV2E9eMmW22kY59Rf6KKdxLgzSBTcjGS6U37MedrxmU3c+yT4 MrXpOrUi7fGcQLxTfiitf190Uq5jxNWq4VuyqONx8xzqVNSc7jF8a8M+xNoaJmwa8WKf 5hFRaQFlJlC1K07R5NpA1A7HdEVvLchNoGXW0OZpVUwdDymrXGDuTcUroUdzkXUxjih7 +B5SpDGPeuu/KVfCdx+RLizxCmQmZJRWAcFIYPekaSL9JUhwlAeYJ2J8binJRGO0T4Iz NQwSp/CrHlQ6d+55rGYWlyPiNnD3+VI7Rc2zTvvVObb1xkdzoiflJ4aIZP1nzDyeFaa/ 9Stg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=/1DYgIzwVVHIUTBZRQm0/j2Jm2pykqS7kpwFWrYvsHg=; fh=241Vp76XhryhN4jdwHk0rPqD5iJoXnTbU205f9qwYR8=; b=l2hDjh044ehxtVYX7fdW5r90Y8xmh625VdDRSPvHQjaX8l2koIMhOSxDr1mZi7qrYJ oF92oQKd/DWXlnsD/YDWIe3zpnU/nkbHysSn03W7r158Lk4wDdrMUryFi43lNyvd9gcP PxCD0acOG/3c1gOEFq2XkvIYrcOnW64tNuT4qDrBUneV1fN6r6eq+1Pwb5xlRXotUVge rZbmN89R/heoz8TOHld+kkQt+l83dgHHq8+OnlWXOIoyHC4qApqi70n0lzOSUysR8mJ1 ZqX/uaR+Bd/GHexnuAEpRKT6v7Utr6e2u+x79D20+3xDoFFiJFxyYvU4cXfAUfkCTnWg iRrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gx6DJoo1; spf=pass (google.com: domain of linux-kernel+bounces-4116-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4116-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id bb26-20020a05622a1b1a00b004254e20ee87si25672102qtb.264.2023.12.18.09.02.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 09:02:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-4116-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gx6DJoo1; spf=pass (google.com: domain of linux-kernel+bounces-4116-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4116-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DD7801C23A3D for ; Mon, 18 Dec 2023 17:02:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C7F8F4FF66; Mon, 18 Dec 2023 17:02:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gx6DJoo1" X-Original-To: linux-kernel@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B258137863 for ; Mon, 18 Dec 2023 17:02:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702918965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/1DYgIzwVVHIUTBZRQm0/j2Jm2pykqS7kpwFWrYvsHg=; b=gx6DJoo1NjgP6w/LTO5WgIbD7eeluDO4/m5xULLbGLgCDV0AGt923gXc2qOvfRcJoCN/df 728Wlkw4Fh1s2yZ33L9joKfr6yrhY4W0seJPaqXzcOe0MR9ddqCVeq6vXgyaRvSVE5fEK6 bzZC77JvNrbti7JW5zFfzdiq3gQLWi8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-68-KxFez5cvMCqhx_KNmDVwtw-1; Mon, 18 Dec 2023 12:02:43 -0500 X-MC-Unique: KxFez5cvMCqhx_KNmDVwtw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40c1d2b1559so25429555e9.3 for ; Mon, 18 Dec 2023 09:02:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702918962; x=1703523762; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/1DYgIzwVVHIUTBZRQm0/j2Jm2pykqS7kpwFWrYvsHg=; b=sTHgM2+RaJStw2jEHNoTQs72vw0YDTyLaFlizrm0uw8btLwOkYDIC9mHG2O2Bolhod uqE65gIZ5/xCPG4TunuiqD/7t/UK/fFg/HetWJtG8bZ4iyRXhj/ueEDBjqitvHKDOiLk K4iyxm973yW/7s4lqkB9JurGKwLZ1aopMfhSXlX5ugrrT/Z8Q9Ud5+5/gGGGhmgTBWEL rc42lJFkqn0sdtbU9zUznRh+iHdRTXmi/f/TIe+4LXe+PUBvThNVsltLLEdaUrMgxIAB km7C8yoHpWXxhHHcL4PoeMm+1y93eamJpmsj27zWsSVflar2rJksbcFn/9hEcyr0BLa/ pLGg== X-Gm-Message-State: AOJu0Yy+M+a0gxuxYUg71HCpZfEByqAUPXCVF/O58waUThb/VLKHrLP5 PRs2klaSh7hGM8UEvkKe9aQ6sm644wWCKG4V4K5/lhJ4VXB9Uq9nHNYUNm8rWp5eC4odkdQDlg8 fgwKK0cjz9MXnJUk9vQvGgzA6 X-Received: by 2002:a05:600c:3556:b0:40b:5e1e:cf9 with SMTP id i22-20020a05600c355600b0040b5e1e0cf9mr8065261wmq.52.1702918955259; Mon, 18 Dec 2023 09:02:35 -0800 (PST) X-Received: by 2002:a05:600c:3556:b0:40b:5e1e:cf9 with SMTP id i22-20020a05600c355600b0040b5e1e0cf9mr8065077wmq.52.1702918944886; Mon, 18 Dec 2023 09:02:24 -0800 (PST) Received: from ?IPV6:2003:cb:c72b:b500:b53e:6e32:1408:27ac? (p200300cbc72bb500b53e6e32140827ac.dip0.t-ipconnect.de. [2003:cb:c72b:b500:b53e:6e32:1408:27ac]) by smtp.gmail.com with ESMTPSA id e10-20020adfe7ca000000b003335ddce799sm13919144wrn.103.2023.12.18.09.02.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Dec 2023 09:02:24 -0800 (PST) Message-ID: <1bc53fc1-fdf0-4f4b-98ab-bab53384b765@redhat.com> Date: Mon, 18 Dec 2023 18:02:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 14/39] mm/rmap: introduce folio_add_anon_rmap_[pte|ptes|pmd]() To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu References: <20231211155652.131054-1-david@redhat.com> <20231211155652.131054-15-david@redhat.com> <593c4eb0-e430-4186-a95c-9d2ebd91235c@arm.com> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <593c4eb0-e430-4186-a95c-9d2ebd91235c@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> - if (flags & RMAP_EXCLUSIVE) >> - SetPageAnonExclusive(page); >> - /* While PTE-mapping a THP we have a PMD and a PTE mapping. */ >> - VM_WARN_ON_FOLIO((atomic_read(&page->_mapcount) > 0 || >> - (folio_test_large(folio) && folio_entire_mapcount(folio) > 1)) && >> - PageAnonExclusive(page), folio); >> + >> + if (flags & RMAP_EXCLUSIVE) { >> + switch (mode) { >> + case RMAP_MODE_PTE: >> + for (i = 0; i < nr_pages; i++) >> + SetPageAnonExclusive(page + i); >> + break; >> + case RMAP_MODE_PMD: >> + SetPageAnonExclusive(page); > > Just to check; I suppose only setting this on the head is ok, because it's an > exclusive mapping and therefore by definition it can only be mapped by pmd? Yes. And when PTE-remapping, we will push the flag to all tail pages. No change in behavior :) -- Cheers, David / dhildenb