Received-SPF: pass (google.com: domain of linux-kernel+bounces-4213-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 18 Dec 2023 17:47:30 +0000
To: Martin Rodriguez Reboredo <yakoyoku@gmail.com>, Miguel Ojeda <ojeda@kernel.org>, Alex Gaynor <alex.gaynor@gmail.com>, Wedson Almeida Filho <wedsonaf@gmail.com>, Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>, =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>, Andreas Hindborg <a.hindborg@samsung.com>, Alice Ryhl <aliceryhl@google.com>, Tejun Heo <tj@kernel.org>
From: Benno Lossin <benno.lossin@proton.me>
Cc: Wedson Almeida Filho <walmeida@microsoft.com>, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] rust: workqueue: add `#[pin_data]` to `Work`
Message-ID: <cf36ec44-466a-4c00-afd6-8387dd1ed1f2@proton.me>
In-Reply-To: <05fa58f3-f351-4119-9c07-1f5bb04503d2@gmail.com>
References: <20231213220447.3613500-1-benno.lossin@proton.me> <20231213220447.3613500-3-benno.lossin@proton.me> <05fa58f3-f351-4119-9c07-1f5bb04503d2@gmail.com>
Feedback-ID: 71780778:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 12/14/23 04:13, Martin Rodriguez Reboredo wrote:
> On 12/13/23 19:09, Benno Lossin wrote:
>> The previous two patches made it possible to add `#[pin_data]` on
>> structs with default generic parameter values.
>> This patch makes `Work` use `#[pin_data]` and removes an invocation of
>> `pin_init_from_closure`. This function is intended as a low level manual
>> escape hatch, so it is better to rely on the safe `pin_init!` macro.
>>
>> Signed-off-by: Benno Lossin <benno.lossin@proton.me>
>> ---
>> [...]

Did you mean to add your reviewed by? Because I received only
the quote.

--=20
Cheers,
Benno