Received-SPF: pass (google.com: domain of linux-kernel+bounces-4220-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <19b88718-a1e6-d699-f056-cf00b1b75346@oracle.com>
Date: Mon, 18 Dec 2023 09:53:53 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 6.6.y] maple_tree: do not preallocate nodes for slot
 stores
Content-Language: en-US
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        maple-tree@lists.infradead.org, akpm@linux-foundation.org,
        willy@infradead.org, liam.howlett@oracle.com,
        zhangpeng.00@bytedance.com, stable@vger.kernel.org
References: <20231212195255.219624-1-sidhartha.kumar@oracle.com>
 <2023121847-cope-surviving-26bf@gregkh>
From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
In-Reply-To: <2023121847-cope-surviving-26bf@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?d3NudU4yY0dxQUdkK3RlbFM2WkVTU1VmM01vT1JwTDIrMTBXQkpKZ25OTUJM?=
 =?utf-8?B?WFRXYVUyeHVPazJOcW5FNWNtbHE1RDhMczdiZjdIMUZ0ZDB3Z3dKTE9CV0hY?=
 =?utf-8?B?YWdtUzhzamw5RWx4UUo1T1UyM1lmOUoxL0JYWVJqMVRKd04vRW1aU0J1MzIw?=
 =?utf-8?B?ZFBvUEUyNkt5cTVRL1c2QVFPcCsyWDVXT3hWS0VZbStYUVZEdTVJbGZpRktV?=
 =?utf-8?B?dkU1VzhxL3Zlc29tOGtOcWRUNm1IUzg0a2h0Unl1bCt3QzAzWmU3T1B6dUkv?=
 =?utf-8?B?OTR0cTFGcGxvcXBrWUhieWVTc1p2RDFObHc1SkdVRk5jMVBnZEt3Zi96MjNn?=
 =?utf-8?B?bCtaS2VsaE9GUWpXVmwrWVFMLzVDSlpMdFdaQmEzam9ybzV1NnBnc3JkdmlU?=
 =?utf-8?B?dFNoNUllVlU2bDlyVHRlRjg1N1hzZXZSVkx5SVV3Y3U3MnFNdm1MQ3pUdmhS?=
 =?utf-8?B?cEdsYkxadmJQNFRlMG1uNytWbldqOUxPZXNyZVI4d3BtbDhBcGVOOWtMcFNL?=
 =?utf-8?B?S1VzODhEZzFFVzBIT2VuOFZNTWZleFRXOWc1b054dE1kcTNJdFlGMEtOcVE1?=
 =?utf-8?B?alBRVjZ5bDltWWNDZjZwZjBiOGZTcm9uKzA2aVdsYVZPNno4NjM2eldSK3E2?=
 =?utf-8?B?dTB5STlCOU1TNDdha2svQUdwaFdMTzR5Q0wvYUgvWGF3RHJkRDhsU0ZQNkhp?=
 =?utf-8?B?S1hnTHhZVW9QdlNGYzhGSmNhWUhLZ0lhMElrdS8xY0JROVphLy93bkZ0dUFx?=
 =?utf-8?B?RDhIQUxYQkZEeEpjM2dybWFJMXFZcFh6Y1M0RlZoVjhaZUxMVU5yeEVDRlA3?=
 =?utf-8?B?LzRZejJ2UzlKR2tDaENaaStZcXpwUTkwb0liSFBGbVpjK05KRlF1MzFDaWhV?=
 =?utf-8?B?dllKY0tOWlNhTElkSEtuNnJ0ZzhoS1Evc3RlWW9maGdmdGlVNi8rTG1VN0J6?=
 =?utf-8?B?M3ZpeU9hVmllcU5HUkdRZkFYSEhxSGhsd3laaVFDMEhpY0VuYjZYOG1HSjNT?=
 =?utf-8?B?NmRHZEFBcUlGU2tVSm9PMHNzOFMwNURzTmdzTjBhUnkzNUp0UHhVN0ViQTRu?=
 =?utf-8?B?MGpkT2NkVUhyZ1BVRFlJQnY1ZmJBSXlQZ0dzT3ZITHVSd0ZsMFJpTHBtWUFm?=
 =?utf-8?B?WXpLMGtJMTJtZU1BSUdnRTZZd3YwWHl5eFJqMUVLLzRiZGg1OFJYZWtmS3M1?=
 =?utf-8?B?SVNvMnd5WTB6NEsyTlpyRTcydjcreXFIdGtUNG1BdVMrRGd3dXY2V1pUVVJi?=
 =?utf-8?B?Y2lzNlBkaFNBRGNIY2hubFdoMzVHeUdpY2dkakdUM1ppWE1uK3FCMmpndFZE?=
 =?utf-8?B?b2J4L1g3M013Q2RqUks0Qm1nOGl1Wi9VWXJCOHQwS0lBY2hGdklRRlAvWmhi?=
 =?utf-8?B?RmNXYlJaYUF4VXZ4NGtrQ3l0dEc4cldQNzNPQStPZzVhUzdJU01XemZWWDFZ?=
 =?utf-8?B?N2ZZSHZUdkVyS2RQbis1L1hKM2lQRkJvL080TmxVaktaMUtFY2NSbitqNlBH?=
 =?utf-8?B?OW9CV3UwSzk1RXBreDFscmUycVJHN3ZqM2Z3T1NCSmVBd1p6K3I3ZmpZT3FE?=
 =?utf-8?B?LzVFRUtwUkdQdTFIdzVHNFZpM2dXZXgvcTNqOE02RGdVR2Zmd3VrRnNGOHhB?=
 =?utf-8?B?U0hTRXVoV010ZWdPTHhSN1N0TVdJUHFrR3FqTTdNRUh6WWZVelV0Uk4yajUz?=
 =?utf-8?B?NVpnMFU3MGR4TUNZVWtXY3N3d1Zsa1lRUGZaN0NJaTV2bEFlU2dPc3ZZQ3JY?=
 =?utf-8?B?aFdGTzVxNVp5ME1QVEtPYTE0K20rVSs3NDNZaHR2Sm4vbTV4cnBoV3E4emtB?=
 =?utf-8?B?OUhiSk1LeXZuVHdZc3FKWjNveUgvOU4xTVBNYUcwa2w1NTJvVHVHQ05PZk1v?=
 =?utf-8?B?N1Q4Sll1NTV2SnY5dVM3Ly84QkxCaFlmRmt5NmFFNm9jVHo4aWorbUR5Sk1z?=
 =?utf-8?B?dWQ1UEtJUFk2OWJmMTRsQ0dhMmc2dzd1cC9oQy9jL2xyaFBJSktCUTV2dnlB?=
 =?utf-8?B?c3h4elFwVzhlcU5wd2JiZjcrbndtNS8zNDcyZG9QMTg1V01yeTZXZU9hUHkw?=
 =?utf-8?B?QVM1aFJpd2dMMEdvVzI3Mm1qWUtwVXVxYXRUTC9pbTh5d3d1dWhyUS9zR1hk?=
 =?utf-8?B?NHVjWmxoRDErbnlhb28waUQ3a0FIVFBSeTFVa1E4MitabHBJOTdKalJzS0VY?=
 =?utf-8?Q?shy5RFNcdq9xecgztEvZcmI=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	+a3K+hWtokoTGbcXzqfxyfe7gH/mYBMUbMGqaT0I+VOMYtafdC3RzV6I1Blyl9y3ka8Cs0h7Xw8NP7JjSaiu2U7eDHTDkpN/PVHrZtlQNflEd4ZOaxCU2oDS+CXJf1k2IGjm+IH3JEH+agSJPAA+o1irMZYBTxugyYMR1j9wJXfwnPBhVL8uGHVF4XaQCKaPHr16cbEfsmlz+ZsAKw6cKAHAMwEAS1jHNLqGqEf1YP/Hy/VdDyp5CZJhtXW0TmQVQkbLF0XsSiVXPhbVl3Tcw/FE8yfpIIES4zEwLQE3B6issvMmuMbtMoPylb4HTBiaATVoLNTWKd13WFUdPdnRimc4odpaORoCKJbYcj0V1RwREOn3UpDbvEQirHb8DgYSvXFZ8HihH77DTG6GCS8sxfp/ulVgEOdivR0KQXBlepBOaXZ0zFBeTzBY7C21XvUwEIPuFcMnWgRfLZRCPb3DbR7YCI6csQKODzSrOHpxlQfNxD4SK5vB+So1vCjlafmv72NsJrRqQeGdFwSEK/YBRo/rCqCHZDtk169wvs0FcioTI1kQRt/inVHtOyQtfpWjJt2YYm4isiREevGacciwP0+LWjZqFPNaY76kSHBPrpc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b736d2f2-285b-4419-ba2a-08dbfff24dce
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5113.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 17:53:55.8981
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2YP5qGFapIRwFzaLWUjjcmss2mJAiXXppOThchWYJzPzluHcBTclu/xDQ+l5n6/scmEcjaAWRmYGn+zOR3VVm5AAVZg5UqA7hgt2kzAMNUw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4706
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-18_11,2023-12-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 mlxscore=0
 mlxlogscore=999 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312180132
X-Proofpoint-GUID: Wue-1za10fmUIUVloSO2tmZw30l2i28S
X-Proofpoint-ORIG-GUID: Wue-1za10fmUIUVloSO2tmZw30l2i28S

On 12/18/23 2:59 AM, Greg KH wrote:
> On Tue, Dec 12, 2023 at 11:52:55AM -0800, Sidhartha Kumar wrote:
>> mas_preallocate() defaults to requesting 1 node for preallocation and then
>> ,depending on the type of store, will update the request variable. There
>> isn't a check for a slot store type, so slot stores are preallocating the
>> default 1 node. Slot stores do not require any additional nodes, so add a
>> check for the slot store case that will bypass node_count_gfp(). Update
>> the tests to reflect that slot stores do not require allocations.
>>
>> User visible effects of this bug include increased memory usage from the
>> unneeded node that was allocated.
>>
>> Fixes: 0b8bb544b1a7 ("maple_tree: update mas_preallocate() testing")
>> Cc: <stable@vger.kernel.org> # 6.6+
>> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
>> ---
>> This is a modified backport as the patch to fix this in upstream does not
>> apply to 6.6 because the node_end field was moved from the ma_wr_state to
>> the ma_state after 6.6.
> 
> What is the git commit id of this change in Linus's tree?

The patch is in akpm's mm-hotfixes-unstable tree and has not made it to Linus's 
tree yet.

Thanks,
Sid
> 
> thanks,
> 
> greg k-h