Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp54821rdh; Mon, 18 Dec 2023 11:19:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHGHC+zrkPjUfCFmIh9S0iFDSVV1E7KO73LBFPDhkGL+VchBYkdmQSXErzNwQDaMkofdOQd X-Received: by 2002:a05:6a20:3d89:b0:190:72d0:d13a with SMTP id s9-20020a056a203d8900b0019072d0d13amr8511666pzi.77.1702927164858; Mon, 18 Dec 2023 11:19:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702927164; cv=none; d=google.com; s=arc-20160816; b=ZEzusVzQt2QZ0NK4bF0JoxJ2uk7TS5AsAAqyK2JnB8K2Ng8yU3lD3nt6YsnKsl6umi ZvwE3JgNLAZg/RPiOcuQQgXaiN2Ac4QXVBj558GF0hcFGG//fAVGhe3GFoqIwoa5+utL lAiv9SKV8AXO3vA8SEVcV0mCApjNPL8bkfY+Y4aAinfqo3f0BKuGdc3Qcu/XWPzTAxBk SRgdDJ1f+KVHj408RdTMFMZyfuonjUK6HsZEAoP3SFn3H44zfjGoeJy8VkF+UJ1zrZNW 4L4bERLbX+7Ng6MbKUZQE9/ZfLCDwMDfWv4/QwJ/jtg3GwaIMD7KpkbJ9N52/LeFLj7y +JBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=le0ioer3hQ0SkH/DBOg57Lcs8bJkYJGxlD07hhof/R0=; fh=kS5+oEOxApSszH+jTEQVI9w3vr3aGQrGyjsPM18lHlQ=; b=tOz119WumGkd5eYWn1jEzmsK7F0PCtj9z7lP+48303V3Zm31WrwOR328++MFtHev+q Hjik7ADi9BwZ1XoxJkTai9ZY0zvU81eGOMYeMqqeNlmWLii6GQ6A0AhRpHl0caWaw/hS 4levK/T8LvETrMkH+1tZkZRtsXYjknMq+asBGAD2RBpkvR9WdbZ4d5OAaPxXqg2yrgFA eCEVSwZwdNQF2xNg1UH4BOexftWzlhC5oJBFjagPnEojsR7Tuqu6V6ckH0kv5G16Cx/d UxI55rGaDi/ZuStPf/qQ6AzWtAs1p/Zza+JueiqZ811XjVTxTwqIFy3fUL42+U7PqR3e ftug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=R9WUM6Mx; spf=pass (google.com: domain of linux-kernel+bounces-4282-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4282-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id h2-20020a056a00170200b006c33a1bdf92si18694897pfc.307.2023.12.18.11.19.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 11:19:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-4282-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=R9WUM6Mx; spf=pass (google.com: domain of linux-kernel+bounces-4282-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4282-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 80E5A286278 for ; Mon, 18 Dec 2023 19:12:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 48EAF74E16; Mon, 18 Dec 2023 19:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R9WUM6Mx" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7301F49891; Mon, 18 Dec 2023 19:10:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78E72C433C8; Mon, 18 Dec 2023 19:10:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702926657; bh=EmeKqQ9l5hZEjaLsVkMcEH3YJG0MBMg0v2Q0/eeSbRs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R9WUM6MxKBOvSwq5/zTDBiDqyt2i7LOpkhq6r7PYE3+UNDLyrKEtyvNTtgBDRSAcj 7KJ/Tw5+YoihTxs8Lz/8TqFuySQaR9QI+Zw03wYDRp7BvzWtQTYTgvJ+/HWZp4un0k P39f+MDRsOMgua1IB4MhhsZrPDsqrA2Jo4O3c5R8QpzY2tlo8alGNtB4reRDn2owa2 GylBGaltxrIOyALBt4SYIBAOuW0t+y+m/UxFBLAJ19WvRX9G5xhHkIdY49nepykodN g8bBBzB7osLnA9XIf7JVxc3tY2csPyweFtYoYbNR0IQxBSkXZw7NNoSlPDzY17P/7b a6CvHTBf0L2sA== Date: Mon, 18 Dec 2023 19:10:51 +0000 From: Simon Horman To: Suman Ghosh Cc: "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , Sunil Kovvuri Goutham , Subbaraya Sundeep Bhatta , Jerin Jacob Kollanukkaran , Geethasowjanya Akula , Hariprasad Kelam , Linu Cherian , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [EXT] Re: [net-next PATCH] octeontx2-af: Add new devlink param to configure maximum usable NIX block LFs Message-ID: <20231218191051.GL6288@kernel.org> References: <20231215120149.160122-1-sumang@marvell.com> <20231218162316.GG6288@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Dec 18, 2023 at 06:03:53PM +0000, Suman Ghosh wrote: > >Hi Suman, > > > >I realise that this patch has been accepted. > >But I believe there is a double-free problem above as mcam- > >>counters.bmap may be freed twice. > >And mcam->bmap seems to be leaked. > > > >Perhaps the last part of the unwind ladder should be: > > > >free_bmap: > > kfree(mcam->bmap); > > > >Double-free flagged by Smatch and Coccinelle. > [Suman] Thanks Simon for finding it. I have pushed a follow-up patch as a fix. Likewise, thanks. The fix patch looks good.