From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org, balbir@linux.vnet.ibm.com
Subject: Re: [PATCH] Fake NUMA emulation for PowerPC
Date: Fri, 7 Dec 2007 22:58:17 +0100
User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405)
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
       LKML <linux-kernel@vger.kernel.org>
References: <20071207211425.10223.91240.sendpatchset@balbir-laptop> <4759BCBA.7060800@linux.vnet.ibm.com> <4759BE88.3020702@linux.vnet.ibm.com>
In-Reply-To: <4759BE88.3020702@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200712072258.19331.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1024
Lines: 27

On Friday 07 December 2007, Balbir Singh wrote:
> Balbir Singh wrote:
> > Geert Uytterhoeven wrote:
> >> On Sat, 8 Dec 2007, Balbir Singh wrote:
> >>> +???if (strstr(p, "fake="))
> >>> +???????????cmdline = p + 5;????????/* 5 is faster than strlen("fake=") */
> >> Really? My gcc is smart enough to replace the `strlen("fake=")' by 5, even
> >> without -O.
> >>
> > 
> > Thanks for pointing that out, but I am surprised that a compiler would
> > interpret library routines like strlen.
> > 
> 
> I just tested it and it turns out that you are right. I'll go hunt to
> see where gcc gets its magic powers from.
> 

Even if it wasn't: Why the heck would you want to optimize this? The function
is run _once_ at boot time and the object code gets thrown away afterwards!

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/