Received-SPF: pass (google.com: domain of linux-kernel+bounces-4299-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20231218-topic-thermaldbg-v1-1-451bcb723e1d@linaro.org>
In-Reply-To: <20231218-topic-thermaldbg-v1-1-451bcb723e1d@linaro.org>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Mon, 18 Dec 2023 20:40:37 +0100
Message-ID: <CAJZ5v0gkko7nWH2ePwEhbfXR-jAb9+f+rsfYXKBMSz04uW4rYg@mail.gmail.com>
Subject: Re: [PATCH] thermal: core: Print out thermal zone name on
 update_temperature error
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Zhang Rui <rui.zhang@intel.com>, Lukasz Luba <lukasz.luba@arm.com>, 
	Marijn Suijten <marijn.suijten@somainline.org>, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 18, 2023 at 3:40=E2=80=AFPM Konrad Dybcio <konrad.dybcio@linaro=
.org> wrote:
>
> Currently, we can encounter an error like this:
>
>   thermal thermal_zone48: failed to read out thermal zone (-19)
>
> It's good to know that there's been an issue, but on some occasions
> (like the error happening in the middle of a platform crash), one may
> not be able to look up what kind of thermal zone that is.
>
> Add the TZ name to the error message in order to speed up debugging.

s/name/type/ ?  It looks like that's what you mean.

First, the tz type is not its name (because there may be multiple
zones of the same type) and it would be consistent with the first
paragraph above.

>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  drivers/thermal/thermal_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_cor=
e.c
> index 2415dc50c31d..a6ccf93eb34e 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -403,8 +403,8 @@ static void update_temperature(struct thermal_zone_de=
vice *tz)
>         if (ret) {
>                 if (ret !=3D -EAGAIN)
>                         dev_warn(&tz->device,
> -                                "failed to read out thermal zone (%d)\n"=
,
> -                                ret);
> +                                "failed to read out thermal zone %s (%d)=
\n",
> +                                tz->type, ret);
>                 return;
>         }
>
>
> ---