Received-SPF: pass (google.com: domain of linux-kernel+bounces-4300-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <849f7785-547c-4add-8bfd-c04608b3fbab@ti.com>
Date: Mon, 18 Dec 2023 13:41:31 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/2] *** Add fixed-paritions to phyCORE-AM62x and
 phyCORE-AM64x ***
To: Nathan Morrisson <nmorrisson@phytec.com>, <nm@ti.com>, <vigneshr@ti.com>,
        <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>
CC: <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <upstream@lists.phytec.de>,
        <w.egorov@phytec.de>
References: <20231215191838.1925082-1-nmorrisson@phytec.com>
 <9f86870c-88cc-43ea-800c-3a05482953aa@ti.com>
 <d03e3dfc-ba3c-4474-8094-94c5557021f2@phytec.com>
Content-Language: en-US
From: Andrew Davis <afd@ti.com>
In-Reply-To: <d03e3dfc-ba3c-4474-8094-94c5557021f2@phytec.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit

On 12/18/23 12:47 PM, Nathan Morrisson wrote:
> Hi Andrew,
> 
> We are adding the nodes directly to the device tree to match what is done in other device trees, for example: k3-am642-tqma64xxl.dtsi. You are correct that this could be done by the bootloader instead though. Why do you prefer having the bootloader add the nodes?
> 

k3-am642-tqma64xxl.dtsi should be fixed, it slipped past me and
shouldn't be used as a reference.

The bootloader might not fill it out at all, what if we start
using the new MTD GPT partitions? Then the new bootloaders
will have to start *removing* these stale half-nodes.

If the bootloader is going to add fixed partitions it should do
the whole job. There is no good reason to have a half complete
nodes here.

Andrew

> Regards,
> 
> Nathan
> 
> On 12/15/23 11:20 AM, Andrew Davis wrote:
>> On 12/15/23 1:18 PM, Nathan Morrisson wrote:
>>> Add a fixed-partitions node to the NOR flash of the phyCORE-AM62x
>>> and phyCORE-AM64x to enable the bootloader to fixup the partitions
>>> during boot.
>>>
>>
>> Why can't your bootloader add these nodes?
>>
>> Andrew
>>
>>> Nathan Morrisson (2):
>>>    arm64: dts: ti: k3-am62-phycore-som: Add fixed-partitions to NOR Flash
>>>    arm64: dts: ti: k3-am64-phycore-som: Add fixed-partitions to NOR Flash
>>>
>>>   arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 6 ++++++
>>>   arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi | 6 ++++++
>>>   2 files changed, 12 insertions(+)
>>>