Received-SPF: pass (google.com: domain of linux-kernel+bounces-4336-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Armin Wolf <W_Armin@gmx.de>
To: hdegoede@redhat.com,
	ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH RESEND v2 4/6] platform/x86: wmi: Create WMI bus device first
Date: Mon, 18 Dec 2023 21:18:47 +0100
Message-Id: <20231218201844.2860-5-W_Armin@gmx.de>
In-Reply-To: <20231218201844.2860-1-W_Armin@gmx.de>
References: <20231218201844.2860-1-W_Armin@gmx.de>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:uJjfeoZUhpU=;K+q3QhbSQr1xYpHm6brduiy+YvI
 ZQgepe4fepG/9tmz9dQcVrMVhGc1l75xt8wqlgv+wJSWoBozvnTiecTmxabs5mJUAKJH1vbwf
 EZLct4sorJsbOZsM+ssnE7ZhqWCHaKomph6sqCtnODAdD/gUt2gQwU55YPj5ny5lA74YXcGW+
 s8fXF3gK8C8p9vzxBx0gtOBdHj06tMxz6FQFnjI6bRfLtCT65Gaf0Zyja3gZM29R5qWBjSoTK
 Yc12mzmlSNygmZYwQw8It+twoxH4XRZEfDafalEwRBmm6q+dYlY9jmZm0azgOniOhuKAFYGXG
 uLaLueBLkFp5QRVtnDPyQ/vidvseCOIDtUWz0zR0BD4bjrOeF/qwrwUVaNfdQkfoXxaASEJZH
 Lq9pZtRxjd4EcIXHfM4dXcBuHvc7YS4xJfA5Gsh2UToHN+rsCocYrJQ30cdw9f5TYoa2Jvd9l
 FeBkahH1C1uciChl9Te0ZFw5PmPZ0OxuCu3Jzlk/9CZs3fFZTdYb1O2fdInhw4Ht4l7nfsPb6
 08pByfGmdJp3/7NXwnkJ8XLTFk3tnQ7jtJtDajpf/bJbTkbrTDZx2MHIarqI1OOA2QP8at8bf
 FVn5RC1itAoXAcMZGhXRcL65KZRm++G61pSu/q7aiPbmt2Iub/+YVhDxyrEPSKtGsrtgGkzI+
 4o5DmRfhcdLhLjrCORWFppDx9AlcszdUM9TTdzg3hxeABgccDoR8koR4KDYUSVgD0ImaVw7qJ
 GS/7sXh51qUCaVdtsGOVj6AFGgLdKDRjzCgsg9VN4NQfj0KnwFMD72PlyWMHufugLzeT2NAcn
 I/lo7N3UuowFk76XbO95tiR8b49cXk6HeI6EbX5kgU3m4ra+xpMrMVjRwi6YU7adWs3BjFiqW
 iayOL10a8PlktGf9JHipzqbFLkCSeNO+O+5U6DZWZ7PbE6IdC/Sh9riDgUYssmp71v3+Lxpbg
 e/PRK9oE5yV7xXYtW5oFZXPiqBU=

Create the WMI bus device first so that it can be used
by the ACPI handlers.

Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
=2D--
 drivers/platform/x86/wmi.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index 4bc5da70c1b0..e2bfdc61c4ce 100644
=2D-- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
@@ -1276,6 +1276,17 @@ static int acpi_wmi_probe(struct platform_device *d=
evice)
 		return -ENODEV;
 	}

+	wmi_bus_dev =3D device_create(&wmi_bus_class, &device->dev, MKDEV(0, 0),=
 NULL, "wmi_bus-%s",
+				    dev_name(&device->dev));
+	if (IS_ERR(wmi_bus_dev))
+		return PTR_ERR(wmi_bus_dev);
+
+	error =3D devm_add_action_or_reset(&device->dev, acpi_wmi_remove_bus_dev=
ice, wmi_bus_dev);
+	if (error < 0)
+		return error;
+
+	dev_set_drvdata(&device->dev, wmi_bus_dev);
+
 	status =3D acpi_install_address_space_handler(acpi_device->handle,
 						    ACPI_ADR_SPACE_EC,
 						    &acpi_wmi_ec_space_handler,
@@ -1302,17 +1313,6 @@ static int acpi_wmi_probe(struct platform_device *d=
evice)
 	if (error < 0)
 		return error;

-	wmi_bus_dev =3D device_create(&wmi_bus_class, &device->dev, MKDEV(0, 0),
-				    NULL, "wmi_bus-%s", dev_name(&device->dev));
-	if (IS_ERR(wmi_bus_dev))
-		return PTR_ERR(wmi_bus_dev);
-
-	error =3D devm_add_action_or_reset(&device->dev, acpi_wmi_remove_bus_dev=
ice, wmi_bus_dev);
-	if (error < 0)
-		return error;
-
-	dev_set_drvdata(&device->dev, wmi_bus_dev);
-
 	error =3D parse_wdg(wmi_bus_dev, device);
 	if (error) {
 		pr_err("Failed to parse WDG method\n");
=2D-
2.39.2