Received-SPF: pass (google.com: domain of linux-kernel+bounces-4376-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <159702bf-3bc8-482e-b4f5-65799d330d7f@intel.com>
Date: Mon, 18 Dec 2023 12:48:20 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net v2 1/1] net: stmmac: fix incorrect flag check in
 timestamp interrupt
Content-Language: en-US
To: Lai Peter Jun Ann <jun.ann.lai@intel.com>, Alexandre Torgue
	<alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, "David S.
 Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, "Jakub
 Kicinski" <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Maxime Coquelin
	<mcoquelin.stm32@gmail.com>
CC: <netdev@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, "Song
 Yoong Siang" <yoong.siang.song@intel.com>
References: <1702885892-30369-1-git-send-email-jun.ann.lai@intel.com>
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <1702885892-30369-1-git-send-email-jun.ann.lai@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkxHbWdNeGdHNndsOVhOMjlNZXpsa0hLZ09lTU5xdDhLSmROMisxZU5GNDZL?=
 =?utf-8?B?Q0JqdlJ3V0lJVkt3ZllSVE5ZUWdkSWJ0TmpFNU9KN1RTcnFadGhLRFVwalQ2?=
 =?utf-8?B?bHZWT3pUb0VwS3k0TUx6TzJmNHJiWVY5L0RUdVhPQTVIK0REYlV4QzM5WWFa?=
 =?utf-8?B?QWpVdXJRQ1FLNTV6dGtJREpMMTdCd3gvcjdmbnpYYy9vMFphVlpxa3JoZ0hC?=
 =?utf-8?B?NHJ6dCs0S0lQb05UL3JRZlpKdThMNENIMDl5QVVoUmZPZFN0d0FiakdrYVBm?=
 =?utf-8?B?K0ZVYjk3MWxxb3Z0VVJydmdPclo4c01WL01mVHE5eGdxSElweDF5cm52K003?=
 =?utf-8?B?eUY3UmVLZWJ6Z1A5ZUY0eUpIeGUzN3hUZE5WbjluU1NndmdGejlhdjZ1eitH?=
 =?utf-8?B?Y3RobmRKMUExTTIwY2F1UGMwaExOVmpSazNyTHdyeWRMQUhLcEh2WmtTQzNo?=
 =?utf-8?B?ZmpDWFg2eERub0RDWnplazVJUWRUUFpxS053cXNoakFFVkpEOXJocW5aWnow?=
 =?utf-8?B?VStROWJaNVc0RWJMNXR2WU1LNVQrYUZCdXFLSFNEUlpZL3FhRVVaMXg4U204?=
 =?utf-8?B?UzEvR05iWlQ2ZUtGeGNKV2QraTYrYzBSSEpzTHlxSEs2SXhBeDN4cE1FVnlG?=
 =?utf-8?B?RDRFOHB2N0dkbjQrR1pWcFJQQVcxY1pLdkNwZGhsdjNwemRMQ1JxRnNhN2to?=
 =?utf-8?B?YlB1YmVWUTE3SllGQzErYjczL1BlZUZYaU1GbHdlQXVML255c3VuWjd4blJQ?=
 =?utf-8?B?QzVienNzN3pJMWlpM1lkWlN2eEp2a21zYzB1RXhxeVBoaXl1WjNSU01qc0gz?=
 =?utf-8?B?TVBLOEhZdm1wRVlKZW9uaGR4d1JaSjgrTTZCY214dUJQZ1pOV2ZKWmtNUER3?=
 =?utf-8?B?Y3RPcXhyOVdDeVdGb3h3Y3doMFFOaDBVWGtKMVFkZEx2YzhiY1Bnb2VqSWdP?=
 =?utf-8?B?TDR6elNsc0UxK291RDRBN3JNMTQwQ3RUb2tUU0k0ZFlmVDdWS2U0bXJoT0No?=
 =?utf-8?B?aSs5cnZ2b0Q0SG1rVURwdlBqQkducmFURGVhSUhWUHdUQlJ2U0NVYUh3OWpi?=
 =?utf-8?B?VDNkOW5MeGRVSmFFY1krM0MxeFhRRTF3NlAzVEpHVEVWZWs5WWVjdVN4RnIz?=
 =?utf-8?B?OE0rQmNFS1NraTlTQ0lmRTJNbHY0d1Y3RXRYU2xUZEE3Tkp1bGdzK2xFYW1y?=
 =?utf-8?B?UWxXeXBldVQ1L3Y0U0YzYWYrK0F5cXdCTU4rV0hTNVFnTytuY2NGWTMxL2xN?=
 =?utf-8?B?QjRNUlV3OTNaVDhQNUxmdFNUVDhMdndyZFUrd1hIKzl3Vy9vRlRlcUxHcTlk?=
 =?utf-8?B?UFU0QUlwQkd6VXhWK1dSVUdUSDIwS2ZETm51c2YramJpMnJkbHpUcW1qUUtN?=
 =?utf-8?B?aDQyWU9lMHFqTDRjMUZnTk9YMU0rUi93WUtXZzl5MmpaQWs0ek5kVWx5dmd4?=
 =?utf-8?B?eDBSYWwyUFQyNkRQOE15TXF0aWJ4emhKWlJOdDhsZUJ2aE9reFBjVTVtV1VM?=
 =?utf-8?B?dnBucTdWb056Q0ZkNEVyK1RvM1UwZERHN05wVmFqeUNNRDIzZS9SSTY5L1NL?=
 =?utf-8?B?UnhhQlJLZWNlbjJPbGZiNkd0blhvbWNydGZJSUZFaEh4TjV4NktnVW9xTGpw?=
 =?utf-8?B?K0c0L3BlR0tEOVVnL1ZlcEtORmJrOS9ocldBaWlSd2RwazAzcTNpcGMwL0ls?=
 =?utf-8?B?NEwzdld3ZWlRZzdBOXBaZTUwSk5QejFhYjg3QUV6NDBKTHFBZzBtM1NRTUp5?=
 =?utf-8?B?YlhIVTFyRllNeUZ2ajZIdmNILzVWOFFib1pLckxrWWJULzlvekZ5b0xiVVJn?=
 =?utf-8?B?ZmtKSmUwdXpKV3pVeFVFQStNOXNZc3RaR2VQSVNtQmQ1cWNhUmRqS3RVVGJy?=
 =?utf-8?B?ZVZoUW9VQ282Q0hXckZyZGJVekI0MjZDeU41Y3dtL2ZBQ3E4cU5ORE1KNEVJ?=
 =?utf-8?B?enNWYUltSm9QNDl6M0RSN2xSODhpTnRWV0VsTndsQnBPdnlrdDhHNE5CWXkv?=
 =?utf-8?B?UElXcjVxeFhVRGFXTmR5aGx5NVBnQzA1d0ltZlhhcU1JQ3UzMG4xNnpqNUpl?=
 =?utf-8?B?cDJtVTVNMGVYR1pkNXB6VW5NY25ad1BLdU5pZUZoWWdDODJtMHhVVXZqZlBl?=
 =?utf-8?B?dmFBSTladitsaDJaZEhLQWd2d0RTeU92dlh6V2s3YXNaMkVRbEZTdlhBa2Fu?=
 =?utf-8?B?VEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f1f1182-8f48-4447-b84d-08dc000aac75
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 20:48:22.4013
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K3PVOsAtSLyWv+3/W2SQCkA/pqKU0XRVtHHW3BlNkK9ZrzMB+lc6iJd/P5Eq0V+trzyuxl7H9r6Y0YFNE0038xd+hQ5ovKXiVgxJL2wuL4w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5677
X-OriginatorOrg: intel.com


On 12/17/2023 11:51 PM, Lai Peter Jun Ann wrote:
> The driver should continue get the timestamp if STMMAC_FLAG_EXT_SNAPSHOT_EN
> flag is set.
> 

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

> Fixes: aa5513f5d95f ("net: stmmac: replace the ext_snapshot_en field with a flag")
> Cc: <stable@vger.kernel.org> # 6.6
> Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com>
> Signed-off-by: Lai Peter Jun Ann <jun.ann.lai@intel.com>
> ---
> v2 changelog:
>  - Add fix tag and stable@vger.kernel.org in email cc list.
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
> index 540f6a4..f05bd75 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
> @@ -237,7 +237,7 @@ static void timestamp_interrupt(struct stmmac_priv *priv)
>  	 */
>  	ts_status = readl(priv->ioaddr + GMAC_TIMESTAMP_STATUS);
>  
> -	if (priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN)
> +	if (!(priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN))
>  		return;
>  
>  	num_snapshot = (ts_status & GMAC_TIMESTAMP_ATSNS_MASK) >>