Received-SPF: pass (google.com: domain of linux-kernel+bounces-4400-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <9ba04aef-ba13-4366-8709-ea1808dd4270@intel.com>
Date: Mon, 18 Dec 2023 13:17:53 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/3] net: mana: add a function to spread IRQs per CPUs
Content-Language: en-US
To: Yury Norov <yury.norov@gmail.com>, Souradeep Chakrabarti
	<schakrabarti@linux.microsoft.com>, <kys@microsoft.com>,
	<haiyangz@microsoft.com>, <wei.liu@kernel.org>, <decui@microsoft.com>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <longli@microsoft.com>, <leon@kernel.org>,
	<cai.huoqing@linux.dev>, <ssengar@linux.microsoft.com>,
	<vkuznets@redhat.com>, <tglx@linutronix.de>, <linux-hyperv@vger.kernel.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-rdma@vger.kernel.org>
CC: <schakrabarti@microsoft.com>, <paulros@microsoft.com>
References: <20231217213214.1905481-1-yury.norov@gmail.com>
 <20231217213214.1905481-4-yury.norov@gmail.com>
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231217213214.1905481-4-yury.norov@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dCtWQTd4MG5ZamV0ekwrY3lMZTBlTmNpNXVEYW9GdTlDekZpd1RsWFdCOTVZ?=
 =?utf-8?B?YmkrQ0tWcWxLRHhFS1dwbForM0xQbDFkaHNER1NSYWxlUEZWeUcrUHlVU200?=
 =?utf-8?B?Z2k2MWpFTW9ReitJMlc5aHExdDA5dmpZdHhxb1piV2kyaEdQRHlublJJeXha?=
 =?utf-8?B?bVVJOCtUTHBMTXRDZy84dGxWMmp3eXRRazNSdk5nT1lZS2VhekJsamhvRGlF?=
 =?utf-8?B?NjBZSVNkRzJRNVJNTzR1YXF5WDlMM04wQ1NEMFI5MXNwQzV1eHB1d1pkWDZM?=
 =?utf-8?B?RnBwVUVhZzlmZy9saVo5S0F5V1JUNmlpZ1dEYmRBTjZJUkNxQS9DUnhHOXds?=
 =?utf-8?B?TE9SL1RtNDdtM1ZSOElqZGhlYytrRXFZQXAvTjNueTBzN3hSMXJrUXVSbTdD?=
 =?utf-8?B?UkNsVGZUYVlObTZ3MVp1R2pIb0NJOEk0aG9IeWFzMnZyVmt6WEVML3RldGlR?=
 =?utf-8?B?WjEzY2lBTGlaVlRQV1pqZWg1UVhRakZKOFE1dXBiT2JUR29nVlFmU2t4UTlu?=
 =?utf-8?B?YmQ5VWNlTytoMjU1NnBTUDZsUFV3WnRQSm5YWW9WRVBNdlp2b09KTkpHSEd1?=
 =?utf-8?B?STlSZTAwc3JvOEkvaE5zMGRxeEJSaW1KM0JyNEhGd3kxMFE4TGRZQTAwVVYw?=
 =?utf-8?B?S1FaVGlCenJ0ZUVOOXA3UGZsZ3VMN3dpTncyR0NwNzJyL1k2Uk9vem9tNW4w?=
 =?utf-8?B?bDEra3VCcHdsNXQ4SnZ5VXcyUGs0WDRIUWw3eWsyd3Faa1VNVytUbkRMZk1x?=
 =?utf-8?B?NEp6WWhQK2xTaGZKZUdiSVVTdHFqQUZyZHdHUDRWOEJWQWYvZ1k5eHpvU09p?=
 =?utf-8?B?Z0hHZlhmbVA1Zi83dXJnZE1nWjM1dzYvTGUzSlJ2enVTQTF2QWFyMCtWeG1H?=
 =?utf-8?B?aldUWnN5d1lGajAyNVBVNGM2VnN0U044Sm9NSHExdDNwSHJnRGJTdlFOS3E5?=
 =?utf-8?B?Z3prWjBqOWlqb0ZIWjFDR2tFajJkQVFsYnpPWGlnaEQ4OUViZVBkVHBTNER6?=
 =?utf-8?B?NGRxVkYzc1daT1VXbDFUVWpNeFh0NkV1cWZXT1lXOTZSdS9aclBtMDJITi8x?=
 =?utf-8?B?aW44Sm1sR1dGQndrUmhqZEFkaTlMV0RXSzNYZTNDNXlRdGNpSXhlVHpXcWk0?=
 =?utf-8?B?ZHMybTB3dmxTNXdKc2RvL0F6b3lCeHZYOW8xanFlWk1Gdi9ySkxkc3U2blY1?=
 =?utf-8?B?VG96MEQyZVRXSGZVZk1VcUI2clhIbjVGOHYybFdmeXgvdW5wdE9VOXNrcTVV?=
 =?utf-8?B?OGtoNWJBS29nWVoyRk4zMGYwenMxUUxWSGx1MHZ4VFpubmFJTDdLRmhaQXNj?=
 =?utf-8?B?a0xBcHNFOXEyUmlGYnAxOXVlZmVvZWJRNitDOThHb0dhcXNlZDAzL0FZVDh6?=
 =?utf-8?B?NnluUTQya3F1NjFwSXJBMnZzdE45WXhzS1QwRnkrZVBucmcwTVUwOTlOMCtT?=
 =?utf-8?B?Umg1Z1h2VjI5dFdENlppYU1ZR0NWcGppaTBPU3U0WXpRMHZoL3JFWUtpMklp?=
 =?utf-8?B?YzUxSmt2TFBqd0dlcjZwaTM4TnQ1cUpnNW4zdHpHaythekpTczNEMmp5ZUVa?=
 =?utf-8?B?MDk4dGpINUxVTVJMVUk1RFdYcysvT3FjY2hRZnZoWHBmK0xXbVJlTkxOS0J5?=
 =?utf-8?B?MDM3T2VETC83YTd1VFJRSXFCODF3OFFMbkNNUnRZNlRnOCtNLzAzSEpLZi9T?=
 =?utf-8?B?MUxNMTRaVVNRdWorbVVnNFZJU0lmM3dYTjA4NDFOVWRQTjR4QnFoeWJOUkdV?=
 =?utf-8?B?cjNkYTFiNm9URHhIa2ZTeGdPKzhDa08rSzdkL05PV3p4K1BCb05EaUQzeFg5?=
 =?utf-8?B?K0RQQzBMbnIxdWNPN2JVZWlHenMxSXNIQy9WVVR2bVNwMVlFY1BTYXVuenp4?=
 =?utf-8?B?K3YyRWNnYTY4UGZRci9MNE5UZExxMGlyK3orcDNlSjMvY21paFFQdGxTNGo0?=
 =?utf-8?B?OHlpZDcyUW00WVA5M2Z6VlBheXR3eTE0Nlo1bWRBbmJaOFRSdmtBWEhSNk1Y?=
 =?utf-8?B?M2E3TzZNR3dCNVB6cDM5RE5vZXZ6czJoTWNWNEYwajJ6UmdGTWUrSFlGZ2ZQ?=
 =?utf-8?B?UXJDRGRqQk9zQWpTZXdsZjF5NWZZMUNOY1A1QTNZbUxBWDFsOHhHL2duOFpM?=
 =?utf-8?B?LzZpVkZCaFZqd1QwWEc1NXJvYWZySko2WVBja1pmckpZRlMwOGNlMlRINEk4?=
 =?utf-8?B?eWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 22e3fead-51e7-4d20-7c11-08dc000ece0a
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 21:17:56.7002
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZIsxFVsUW/F/alX1CdPLQJrQ2y5Xs4rTdoEi7Bs9zFprqQtWe7Yg2e+pMYY+Hg78Fk+8C/w/3VkSj07fTxsoyHkr4YBcbXIHJGCWGa352KE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7941
X-OriginatorOrg: intel.com


On 12/17/2023 1:32 PM, Yury Norov wrote:
> +static __maybe_unused int irq_setup(unsigned int *irqs, unsigned int len, int node)
> +{
> +	const struct cpumask *next, *prev = cpu_none_mask;
> +	cpumask_var_t cpus __free(free_cpumask_var);
> +	int cpu, weight;
> +
> +	if (!alloc_cpumask_var(&cpus, GFP_KERNEL))
> +		return -ENOMEM;
> +
> +	rcu_read_lock();
> +	for_each_numa_hop_mask(next, node) {
> +		weight = cpumask_weight_andnot(next, prev);
> +		while (weight-- > 0) {
> +			cpumask_andnot(cpus, next, prev);
> +			for_each_cpu(cpu, cpus) {
> +				if (len-- == 0)
> +					goto done;
> +				irq_set_affinity_and_hint(*irqs++, topology_sibling_cpumask(cpu));
> +				cpumask_andnot(cpus, cpus, topology_sibling_cpumask(cpu));
> +			}
> +		}
> +		prev = next;
> +	}
> +done:
> +	rcu_read_unlock();
> +	return 0;
> +}
> +

You're adding a function here but its not called and even marked as
__maybe_unused?

>  static int mana_gd_setup_irqs(struct pci_dev *pdev)
>  {
>  	unsigned int max_queues_per_port = num_online_cpus();