Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp139698rdh; Mon, 18 Dec 2023 14:20:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IHKSkHVaY+Esq6H9qJb3BHBPXkjwZ3Zb6jqzIlDjyNl8LOs82ytzZ3n/D6QKPlwEncebhOT X-Received: by 2002:a05:6a00:1749:b0:6ce:2732:1e07 with SMTP id j9-20020a056a00174900b006ce27321e07mr9316978pfc.65.1702938034609; Mon, 18 Dec 2023 14:20:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702938034; cv=none; d=google.com; s=arc-20160816; b=U+6b2wuYH5ev7GEnIikw4mTapcxRNzsgqRZ0eoQjPfiB0unwkVKdVEo7sKuMuVL7Ut dFnt20M9tei6smaRmD2niF/4MzhT+8OO865CWrmLrZZQDSIBJkqbJTkdn1U6k3cotqDz qCfMZDLCSUTSpedhWvez+X6g/RjvSdIk9QxhlAgmR0ytXpKIjiAQjmex8KR15zxL7uuM 3WiV10SNHgv1wUncIetUehOwq/QVXdmtMbzU7rN6JqE+A0QXYIsPsVWuTcyUJe/S+sB0 D5kuVClsfkdXpS/gxESF0nTV4ePayRnFe2n3hC2IWNNii2qqi3aMm02gxXTGG1gQsUZz zH7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=thread-index:thread-topic:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject :references:in-reply-to:message-id:cc:to:from:date; bh=V67jUA/X4iuuyWPHvIFmIMQeerw4rwp8jEY/OLK5Slg=; fh=8raor8WkIWdS52YjHRyWvE0zKo9ZVuQPz0k6JPcaiRc=; b=Ah0fedLnNBKMIPFB23pnCPmkOszadzrj8YyPEaFKE6SnQE6wMWcNZVDCg+b5To42EP Ydn6dwpkSAuos2FccVlJ8NuyKB3lJa6ghmwQdjFdbM5V4V0pjeUiQwIc3o0GZcugl/k0 xcx458Tqd/a4ZlSVHlT/9cyAMZJTTgqcT2jnPbq0lM4xlg1z/wju8HUJyrhBNQvCjpXY 3m7E4wzrdZ6i4Hc4ldelsnCyJWPO37f6+OBb+RyxFOmmPUlMyV3ycipbSFbsBY1jSmVG POhdIKkvMz5d86OJxJYan/+/gE6GT8Yv12ciWzuD4l57P+aK/kNdvvSN9P4XPQb2VbRQ Xiow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-4446-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4446-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id z10-20020a056a00240a00b006ce7e1a786fsi18351706pfh.169.2023.12.18.14.20.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 14:20:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-4446-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-4446-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4446-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B6E5FB23E06 for ; Mon, 18 Dec 2023 22:20:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A6CB974E19; Mon, 18 Dec 2023 22:20:11 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 188AE5D746; Mon, 18 Dec 2023 22:20:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nod.at Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nod.at Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id E1BDC6343B3B; Mon, 18 Dec 2023 23:10:21 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 9keEN92ZV6OF; Mon, 18 Dec 2023 23:10:21 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 6AB616343B3C; Mon, 18 Dec 2023 23:10:21 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id nR8uZpRh0SkQ; Mon, 18 Dec 2023 23:10:21 +0100 (CET) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 2459D6343B3B; Mon, 18 Dec 2023 23:10:21 +0100 (CET) Date: Mon, 18 Dec 2023 23:10:20 +0100 (CET) From: Richard Weinberger To: Amit Kumar Mahapatra Cc: Mark Brown , Tudor Ambarus , pratyush , Miquel Raynal , Vignesh Raghavendra , sbinding@opensource.cirrus.com, Lee Jones , james schulman , david rhodes , rf@opensource.cirrus.com, Jaroslav Kysela , tiwai@suse.com, linux-spi , linux-kernel , Michael Walle , linux-mtd , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , michal simek , linux-arm-kernel , alsa-devel , patches@opensource.cirrus.com, linux-sound@vger.kernel.org, git@amd.com, amitrkcian2002@gmail.com Message-ID: <1953466568.133535.1702937420979.JavaMail.zimbra@nod.at> In-Reply-To: <20231125092137.2948-1-amit.kumar-mahapatra@amd.com> References: <20231125092137.2948-1-amit.kumar-mahapatra@amd.com> Subject: Re: [PATCH v11 00/10] spi: Add support for stacked/parallel memories Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF97 (Linux)/8.8.12_GA_3809) Thread-Topic: Add support for stacked/parallel memories Thread-Index: Gp+EE7t5zvexUhLdnkyaadGyCIq7oQ== ----- Urspr=C3=BCngliche Mail ----- > Von: "Amit Kumar Mahapatra" > This patch series updated the spi-nor, spi core and the AMD-Xilinx GQSPI > driver to add stacked and parallel memories support. I wish the series had a real cover letter which explains the big picture in more detail. What I didn't really get so far, is it really necessary to support multiple chip selects within a single mtd? You changes introduce hard to maintain changes into the spi-nor/mtd core co= de which alert me. Why can't we have one mtd for each cs and, if needed, combine them later? We have drivers such as mtdconcat for reasons. Thanks, //richard