Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp181104rdh; Mon, 18 Dec 2023 16:00:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGoDhmYrzB4lZE47hwnPsKetLtdzdD8yoCzOQzhacZnKDAX3tQGre0c4HudBOl36ti6jTh1 X-Received: by 2002:a17:907:c30f:b0:a23:59ea:764 with SMTP id tl15-20020a170907c30f00b00a2359ea0764mr735034ejc.242.1702944033416; Mon, 18 Dec 2023 16:00:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702944033; cv=none; d=google.com; s=arc-20160816; b=Yiz4SY9dKlrCaD0PL0r+RB1ZUy9jFbFxwLcwPQD0z8W5POy42W+p9SOk+hJ3D0lbUz k+CbF8vrJT82yxlS/n6GxSNaZyStMlWB47ykkpLZp3ucnVii1obtgCCpAWse7SEt1QPu 4bQSJSC4wp5kph8xKxBiVL0O6g+AdcPogwBnzhek7TOixz59L2Vch8W75yBQ7LEI4wSW //05we/3ghg77rdIX5Po0k9slvBOfNpIg3Lu/qzmnlUCsAQ+JTOGD5FyWTmpQDkYA9Ed Ja2OGCaylI6q3NrTBEkPZpnSvo2bCuE+rhTNekjDRl7+RQ9pfnAYA3/YzxP+8EsiU4La B/bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=F/HdrOudsCZXCQmc+xM1fBy8+9mnEgRSilISiXluyqI=; fh=oCRgIxeR6dRvA2FnQ4j0u0+xW+V16s2nO4hO/pL6Br0=; b=UWZBM8XP1Nu+MwaBC9Qb/08CQCWeB6eUIhucuL+U3l2fSo94MyiCR/sqOUOmddG50d iu8s46IM+RoQjXszlUSuc5U/05SIpOv3v3Jh8vnUJYfXyTl2+h16Qssg6zSKtis2srJ4 N0BTdQ6e0mbWJ1a0iBG0l3KyMe+7xOInFxCginPjl3kOlXvQdRA9jlPBROPP+pWZFbza a0LlkvAbplf7NLqvt4K9l12cKOyHKnWeBGeP5A240gE13odxgTLQDrUkMbxpzwfBSAsn yoBV6FmxJbdwo6niAddhTKYi+5MaZhWoLdEybkDk4Goe41e+R7TLx1C7LvdA08jjdbLm jz7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U1i6h7yR; spf=pass (google.com: domain of linux-kernel+bounces-4506-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4506-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id e18-20020a1709062d5200b00a23151d06b0si3809154eji.1054.2023.12.18.16.00.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 16:00:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-4506-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U1i6h7yR; spf=pass (google.com: domain of linux-kernel+bounces-4506-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4506-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E9D741F2344B for ; Tue, 19 Dec 2023 00:00:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 852F879EC; Tue, 19 Dec 2023 00:00:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U1i6h7yR" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB6DD6129; Tue, 19 Dec 2023 00:00:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF2B4C433C7; Tue, 19 Dec 2023 00:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702944024; bh=uH9ugU+7qqeRDjMYoKm8lVQHLGXGmWs2ElB1AqWtjug=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U1i6h7yRznY+6DGXxmEsXQibpH+4jvmWkcauqO2DbhOJQSwU9vJ3fb/rzhwH9dpS9 aBJ/zC9Bnvs2YI/dcwLWEbOBZfWQnCQGI2v+m+ylfM775kbiVdCAxeny2HqS+K4T6g u8SUFuAUGVaqB4LDHhJ9ILJ1PlnHeuFY/63oH0KDcwWtY2YALw1nDDOe65FM+AAI4b gWv0rESaCCs+HCy1B4VGPkVdPCFfienU8u1+POUYrJm+vwknBvZqlAQAJtdnpyLgQ0 QjBAfcuqS5sZaL7gC+6CpQniFcFQh4Dq3psxjzJpTvHbUluOmlIEr1wZjLBlAPhVsM dL3EF3FoH8tpw== Date: Mon, 18 Dec 2023 16:00:22 -0800 From: Jakub Kicinski To: Leone Fernando Cc: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] ipmr: support IP_PKTINFO on cache report IGMP msg Message-ID: <20231218160022.60434a91@kernel.org> In-Reply-To: <63bd69c0-8729-4237-82e6-53af12a60bf9@gmail.com> References: <63bd69c0-8729-4237-82e6-53af12a60bf9@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 13 Dec 2023 17:19:35 +0100 Leone Fernando wrote: > In order to support IP_PKTINFO on those packets, we need to call > ipv4_pktinfo_prepare. > > When sending mrouted/pimd daemons a cache report IGMP msg, it is > unnecessary to set dst on the newly created skb. > It used to be necessary on older versions until > commit d826eb14ecef ("ipv4: PKTINFO doesnt need dst reference") which > changed the way IP_PKTINFO struct is been retrieved. > > Changes from v1: > 1. Undo changes in ipv4_pktinfo_prepare function. use it directly > and copy the control block. > > Fixes: d826eb14ecef ("ipv4: PKTINFO doesnt need dst reference") > Signed-off-by: Leone Fernando Applied to net-next, thanks!