Received-SPF: pass (google.com: domain of linux-kernel+bounces-4513-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20231215-llvm-decode-stacktrace-v1-1-201cb86f4879@quicinc.com> <CAKwvOdmY=Jysqai3KOYO8+c5idP9JjNGKL2xZn2sDNdj5MjTVA@mail.gmail.com>
In-Reply-To: <CAKwvOdmY=Jysqai3KOYO8+c5idP9JjNGKL2xZn2sDNdj5MjTVA@mail.gmail.com>
From: Justin Stitt <justinstitt@google.com>
Date: Mon, 18 Dec 2023 16:16:57 -0800
Message-ID: <CAFhGd8qA8Hh63iZPP33Nsxu61OycP7oqT50mDgUO-HFNUWHZxQ@mail.gmail.com>
Subject: Re: [PATCH] scripts/decode_stacktrace.sh: Use LLVM environment variable
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Elliot Berman <quic_eberman@quicinc.com>, Masahiro Yamada <masahiroy@kernel.org>, 
	Nathan Chancellor <nathan@kernel.org>, Bill Wendling <morbo@google.com>, Manuel Traut <manut@linutronix.de>, 
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	llvm@lists.linux.dev, Will Deacon <will@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Dec 18, 2023 at 8:37=E2=80=AFAM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Fri, Dec 15, 2023 at 10:27=E2=80=AFAM Elliot Berman <quic_eberman@quic=
inc.com> wrote:
>
> This patch looks familiar...
> https://lore.kernel.org/lkml/20230929034836.403735-1-cmllamas@google.com/
>
> Masahiro, can you please pick up that patch?
>
> Elliot, Justin, can you help test/review that patch?
>

Interestingly, I am getting good stack traces on mainline with a
LLVM-built kernel -- both with and without that patch.

It may help others, so I'll go to that patch and add my tested-by.

> >
> > When using LLVM as the compiler, decode_stacktrace should also use
> > llvm-addr2line. Check if LLVM is set and add the appropriate
> > suffix/prefix.
> >
> > Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
> > ---
> >  scripts/decode_stacktrace.sh | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.s=
h
> > index 564c5632e1a2..189b00f4e120 100755
> > --- a/scripts/decode_stacktrace.sh
> > +++ b/scripts/decode_stacktrace.sh
> > @@ -16,6 +16,16 @@ elif type c++filt >/dev/null 2>&1 ; then
> >         cppfilt_opts=3D-i
> >  fi
> >
> > +if [[ "${LLVM}" =3D=3D "1" ]] ; then
> > +       addr2line=3D"llvm-addr2line"
> > +elif [[ "${LLVM}" =3D=3D */ ]] ; then
> > +       addr2line=3D"${LLVM}llvm-addr2line"
> > +elif [[ "${LLVM}" =3D=3D -* ]] ; then
> > +       addr2line=3D"llvm-addr2line${LLVM}"
> > +else
> > +       addr2line=3D"${CROSS_COMPILE}addr2line"
> > +fi
> > +
> >  if [[ $1 =3D=3D "-r" ]] ; then
> >         vmlinux=3D""
> >         basepath=3D"auto"
> > @@ -169,7 +179,7 @@ parse_symbol() {
> >         if [[ $aarray_support =3D=3D true && "${cache[$module,$address]=
+isset}" =3D=3D "isset" ]]; then
> >                 local code=3D${cache[$module,$address]}
> >         else
> > -               local code=3D$(${CROSS_COMPILE}addr2line -i -e "$objfil=
e" "$address" 2>/dev/null)
> > +               local code=3D$(${addr2line} -i -e "$objfile" "$address"=
 2>/dev/null)
> >                 if [[ $aarray_support =3D=3D true ]]; then
> >                         cache[$module,$address]=3D$code
> >                 fi
> >
> > ---
> > base-commit: 3f7168591ebf7bbdb91797d02b1afaf00a4289b1
> > change-id: 20231214-llvm-decode-stacktrace-09538979006d
> >
> > Best regards,
> > --
> > Elliot Berman <quic_eberman@quicinc.com>
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers

Thanks
Justin