Received-SPF: pass (google.com: domain of linux-kernel+bounces-4569-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <5fa71441-a3c0-46ee-802d-5b08492f4e8f@huawei.com>
Date: Tue, 19 Dec 2023 09:45:03 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
CC: <shaojijie@huawei.com>, <yisen.zhuang@huawei.com>,
	<salil.mehta@huawei.com>, <davem@davemloft.net>, <edumazet@google.com>,
	<kuba@kernel.org>, <pabeni@redhat.com>, <shenjian15@huawei.com>,
	<wangjie125@huawei.com>, <liuyonglong@huawei.com>, <lanhao@huawei.com>,
	<wangpeiyang1@huawei.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 net-next 4/4] net: hns3: move constants from
 hclge_debugfs.h to hclge_debugfs.c
To: Simon Horman <horms@kernel.org>
References: <20231216070018.222798-1-shaojijie@huawei.com>
 <20231216070018.222798-5-shaojijie@huawei.com>
 <20231218153533.GE6288@kernel.org>
From: Jijie Shao <shaojijie@huawei.com>
In-Reply-To: <20231218153533.GE6288@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


on 2023/12/18 23:35, Simon Horman wrote:
> On Sat, Dec 16, 2023 at 03:00:18PM +0800, Jijie Shao wrote:
>> some constants are defined in hclge_debugfs.h,
>> but only used in hclge_debugfs.c.
>> so move them from hclge_debugfs.h to hclge_debugfs.c.
>>
>> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
> Thanks Jijie,
>
> this looks good, but I think it should come before patch 2/4,
> to avoid warnings about unused symbols being flagged until this patch is
> applied.
>
> ...

Thanks for your suggestion, this will be fixed in v4.