Received-SPF: pass (google.com: domain of linux-kernel+bounces-4579-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Mon, 18 Dec 2023 23:10:45 -0300
From: Fabio Estevam <festevam@denx.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>, Zhang Rui
 <rui.zhang@intel.com>, Linux Kernel Mailing List
 <linux-kernel@vger.kernel.org>, Linux Next Mailing List
 <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the thermal tree
In-Reply-To: <20231219103457.4e034e9a@canb.auug.org.au>
References: <20231219103457.4e034e9a@canb.auug.org.au>
Message-ID: <68012fb93e0057f62c03a5d9b01237c4@denx.de>
User-Agent: Roundcube Webmail/1.3.6

Hi Stephen,

On 18/12/2023 20:34, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the thermal tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: modpost: "__hw_protection_shutdown"
> [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!
> 
> Caused by commit
> 
>   726edaad90f6 ("thermal/core: Prepare for introduction of thermal 
> reboot")

Thanks for reporting.

Daniel,

Could you please squash the following fix to the commit above?

diff --git a/kernel/reboot.c b/kernel/reboot.c
index 07eb6537ed8b..f814568525f1 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -1002,6 +1002,7 @@ void __hw_protection_shutdown(const char *reason, 
int ms_until_forced, bool shut
         if (shutdown)
                 orderly_poweroff(true);
  }
+EXPORT_SYMBOL_GPL(__hw_protection_shutdown);

  static int __init reboot_setup(char *str)
  {

x86_64 allmodconfig builds successfully with this change.


Thanks,

Fabio Estevam