Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp235785rdh; Mon, 18 Dec 2023 18:21:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IE7whtQqRb8TLYmrox19mz+5HHRFBcsIxse19yVYDQnUfRRBXlkr6xaYDsEiPhZm1Fw2cX1 X-Received: by 2002:a05:6830:615:b0:6d9:f334:f886 with SMTP id w21-20020a056830061500b006d9f334f886mr16000915oti.18.1702952515475; Mon, 18 Dec 2023 18:21:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702952515; cv=none; d=google.com; s=arc-20160816; b=AKKExFFK6cB/R4/9hHh7mTxsDMQhU3SmpDECv2tpR95q5jPtHHxm1kMqMfSKc+KJUb UnIy/B0UuBL56CvggohQ2/N8f1AgKwBqx8V7qXzEF8yeGAEblkR0WT9QWTgXZkYI7ZeR 8IwqeIcvuzYEzjE+ZwOF2ceB5hnoBwH7er4oqoTRRIEwTXPYyaGY4A+jRcWD/08Ghgh6 fM+hrwcrOgwPScX5JIfJIZnC2tbx09Bdqa93RzuLjijkwES2Jpll5MXvLrpOOu/KadeD qJ361+ZOMk9tw6md2T4ffUvL1E6B3jQ/vvsggIqZ1vZKzvS/w35IkwkkgMPwawKn970H OGkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=8hgMui5IfrlicjH5IV7rxovhTxySQYdDHIh8ZaptdKw=; fh=cJhXZaLrtGOfQM6Q6zLAnEnDURMuWuZmp+zAMVJNw38=; b=ojp4bwSWpEDhgxpWGSr1lYOaUAH8imAJEtfrdtdj7H/4IO4d6pPyAnuWWi1sX4qIqU bQZ1UtNh+vGK2EudEnyNDNp+NBYzsVXIirsHEv44FpqFe5Yi4722fm8tk/uxW6RujL9H brtPHj3hHO1IaEpqoy4tDNDQIp8SI2cEKshp3TojcGHE7HPT744AGHl+eOqLwR+FhEwk 0bjBE/kL7+dJ5c5bKm516J8FHkbVKKNP/+Y6pz/fB5iuKPLU9co/TDRUZl0XhNMFJJEG Ryh7PEnq4Uv6TY2nPsbmgpfO23T0+cuF+JidQBk3Lyb6/wCctNCwLsNA6ULzBZs4EFR4 H1Nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=cdT+XJu+; spf=pass (google.com: domain of linux-kernel+bounces-4591-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4591-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id g19-20020a62e313000000b006d6c7ef990fsi3061740pfh.94.2023.12.18.18.21.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 18:21:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-4591-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=cdT+XJu+; spf=pass (google.com: domain of linux-kernel+bounces-4591-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4591-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 06A37285FAC for ; Tue, 19 Dec 2023 02:21:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D667C1172A; Tue, 19 Dec 2023 02:19:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="cdT+XJu+" X-Original-To: linux-kernel@vger.kernel.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F8685386; Tue, 19 Dec 2023 02:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BJ0JSer018729; Tue, 19 Dec 2023 02:19:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-11-20; bh=8hgMui5IfrlicjH5IV7rxovhTxySQYdDHIh8ZaptdKw=; b=cdT+XJu+r5HVYSB3qHXEU1Nrn9ldS8VeMKo65n7klSOW6PQ5OULrNbpg7HDnHF+1dNIl A05nu3YndZCElC8Gzaf7EmxeSyLqRTkae20vs+i4UYXoI8DNZgA/ZJATgGh1UZFQdmUl GD4817CYdBvN+n2FZHtLoLmPIIHPGV7Qmdoo6csDvOEsGx507R09S+UYFxMNLN23w91f ujiqXNTncGLThDifM2hSLvD6TTOD2iEp/hGlnwfYcauuah21HV/5ApEJlg/k4W8nv9EI C797aNtQzA6Q9XLYknLnl912YVX+/UbKH8IORZX2mEpqP3cxlNyEM9j/x2M97HmJ1LkF 1w== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3v13guctfd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Dec 2023 02:19:47 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3BJ1Mf62028151; Tue, 19 Dec 2023 02:19:46 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3v12bc5j4a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Dec 2023 02:19:46 +0000 Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3BJ2EbhV009328; Tue, 19 Dec 2023 02:19:46 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3v12bc5j3x-2; Tue, 19 Dec 2023 02:19:45 +0000 From: "Martin K. Petersen" To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mani@kernel.org, jejb@linux.ibm.com, quic_asutoshd@quicinc.com, dmitry.baryshkov@linaro.org, ahalaney@redhat.com, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Chanwoo Lee Cc: "Martin K . Petersen" , grant.jung@samsung.com, jt77.jang@samsung.com, dh0421.hwang@samsung.com, sh043.lee@samsung.com Subject: Re: [PATCH v3] scsi: ufs: qcom: Return ufs_qcom_clk_scale_*() errors in ufs_qcom_clk_scale_notify() Date: Mon, 18 Dec 2023 21:19:36 -0500 Message-ID: <170295223232.2870516.2257248057089025297.b4-ty@oracle.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231215003812.29650-1-cw9316.lee@samsung.com> References: <20231215003812.29650-1-cw9316.lee@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-18_15,2023-12-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=931 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312190017 X-Proofpoint-ORIG-GUID: Z8tp9hmbYYjBv9iaE6IqJ6jcI_MvoyEG X-Proofpoint-GUID: Z8tp9hmbYYjBv9iaE6IqJ6jcI_MvoyEG On Fri, 15 Dec 2023 09:38:12 +0900, Chanwoo Lee wrote: > In commit 031312dbc695 ("scsi: ufs: ufs-qcom: Remove unnecessary goto statements") > the error handling was accidentally changed, resulting in the error of > ufs_qcom_clk_scale_*() calls not being returned. > > This is the case I checked. > * ufs_qcom_clk_scale_notify -> 'ufs_qcom_clk_scale_up_/down_pre_change' error -> return 0; > > [...] Applied to 6.7/scsi-fixes, thanks! [1/1] scsi: ufs: qcom: Return ufs_qcom_clk_scale_*() errors in ufs_qcom_clk_scale_notify() https://git.kernel.org/mkp/scsi/c/9264fd61e628 -- Martin K. Petersen Oracle Linux Engineering