Received-SPF: pass (google.com: domain of linux-kernel+bounces-4659-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <df9e1899-cc09-4fef-b999-05feeb0c41fa@intel.com>
Date: Tue, 19 Dec 2023 09:34:49 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 03/50] x86/lib/cache-smp.c: fix missing include
To: Kent Overstreet <kent.overstreet@linux.dev>
CC: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	<linux-fsdevel@vger.kernel.org>, <tglx@linutronix.de>, <x86@kernel.org>,
	<tj@kernel.org>, <peterz@infradead.org>, <mathieu.desnoyers@efficios.com>,
	<paulmck@kernel.org>, <keescook@chromium.org>, <dave.hansen@linux.intel.com>,
	<mingo@redhat.com>, <will@kernel.org>, <longman@redhat.com>,
	<boqun.feng@gmail.com>, <brauner@kernel.org>, Borislav Petkov <bp@alien8.de>
References: <20231216024834.3510073-1-kent.overstreet@linux.dev>
 <20231216024834.3510073-4-kent.overstreet@linux.dev>
 <76af02dd-1f16-41ad-86c7-3202146d0085@intel.com>
 <20231219020605.edmlnz2hgjb4h4im@moria.home.lan>
Content-Language: en-US
From: Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20231219020605.edmlnz2hgjb4h4im@moria.home.lan>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnFGVWF6cysrVkFkRzZnaWc1Ui9CcG56YytTVVdMZzNHdmdBZWR1aEtNQytB?=
 =?utf-8?B?MVFNamtwNFlPRDEvWUxqSDBiNytKZW1lY1JOM241ZlJXOGFlK1J3cFhyUS9K?=
 =?utf-8?B?eGhjSGRtN1AzS3F1SXpkc0ZvbmRGVGRmZDk1VGF1a3AxREVhbytsU1B4UHlO?=
 =?utf-8?B?enkrRjVmUTg5dGpxTFJkZjVieVhrYUxzSHdBY2E5eERkYzBMMUZydXRGSUsw?=
 =?utf-8?B?VHNqVDY3VzdGSzBvZko1SDVqS2J6TVIwRk1SNUt0TjVWbGhZWjk2eEoyVjJY?=
 =?utf-8?B?RU5lNG9aNVpRM3JzNEJaSHNmR2o1QzRCMVZGUEpFZDRjeFg1RjdFYW5zSmJz?=
 =?utf-8?B?UmFqMlY2M0l3TEsrcGlOVmhvc2d1Mm1oK1ZlNytybTExVkc2c3dMNkdqRDN1?=
 =?utf-8?B?YjZUVS84VFpnNlpkaUxQSmtYL3ZDYzNBbnNqaXl4Rzk3KzI5bXN6UVU5SnhO?=
 =?utf-8?B?ZTM5Yk9oN0RiZG1qT1NJc21SZWNwTlQ2VGgwZU1hQWZoVVRNQmI5R3U3UStD?=
 =?utf-8?B?UGNQL0RXMml3RXcyRzdVYlNvTmI3WmxnMHZoNE9vaytDU1dRV2hiOUI3ZWhV?=
 =?utf-8?B?WTR6OFhzdjhoaTQ2SEJ2Ty9SaU9WeHczWnZ0QXFMOWVNR0FNcEpQdU01MXU0?=
 =?utf-8?B?WmdEM3I5SnF5eld0UTRRczFxRFo2dWtGVHRSRFhLeVMyYWJ0U2EvS2xjbjZY?=
 =?utf-8?B?VFdlOXlvQ2ZnSVdlR2cyQm9jS3dYLy9Ta3ZBOFVERXYyV2tCeDJ2Nnl4dEh0?=
 =?utf-8?B?QWxzWHBDb0N1N2UwNTd1MzJ6UkFtMkNBVi9YeVJNNXplRHZFUlZnQzFBcnlo?=
 =?utf-8?B?Z05CNkxYdnZjSXhITlB5cUFYdjNyZkVaMllhbjMwaThkQkgyalYzSkFJcG04?=
 =?utf-8?B?S1N6eStmT3N5M2U0THNrQ0M1eW9jdCtaZVBGQVA4Ti9zZDF1T3pMb29KQ3kr?=
 =?utf-8?B?dEcrOTlZRG4rU0tNdk55SHY3UnRWMUd1QWswZ3hwN1NWcW9TUitTbGZwT1Fl?=
 =?utf-8?B?ODY0WkR3VGNhejJFNGZRUGZBZms4MVh1VnB2aS9FVWkyKzRQRFRmT010byt6?=
 =?utf-8?B?a2svUXZFZUVBOHA5VnlGVnVuOEUvNVd6a3NJYmdXOW9JaXhHRVl1cThCc0dw?=
 =?utf-8?B?UlZHMnVBVHRhS0thSHZxUi9EbEI5ekVNQ256bnR0VUtQRjdzekdzbE5SWGZl?=
 =?utf-8?B?cUV0QmxOakVVTXJvamt6aVQwMzNPNmxkbm9QTTEweTRhWE1BblFNTUNLRk9n?=
 =?utf-8?B?RUdQUmxsWmJVdmNQNVYrNXlTYXFMS3N0bzRaT2p0cU9KZ1o4Y1lmSkdrK3FG?=
 =?utf-8?B?b3J3bTZBc3EwM3A5S05zejVyQ2dkL25yeDN3djUyY2VadThlT2QvelpKYkc5?=
 =?utf-8?B?akF5MUdGQndoMHZ0M29OTG5vaFhxbDJscVlhenhsaHVtNXZmSXhJVVUzNXFl?=
 =?utf-8?B?NkhJWTJmeUdjTXQyMXBHWDltVGRHZWtDZFJKVjBSdFlrRlQwNkFaTnArR2JI?=
 =?utf-8?B?a2syU2dmVHJGS2pQNytrSGlEbHZsY3V6TmZkS3E4bm14bStSeTNEWVBJaHVw?=
 =?utf-8?B?N1J3bXJPdXJiR3I0YUhFRmVJbE1EbVVwUTRZWE1xdUVhaWlOOGtUTFEvYUda?=
 =?utf-8?B?RThlNUZRVkc4dDAxVm5BNXlVR0hXN1pSSmIxVjBJb3FnZEJGZnNYNFVRM20z?=
 =?utf-8?B?cVlsVm5LUjlYZUtrNk5rYWIzOGtEUXBDMEdhN0Y2am0vdmVMKzdxN2JxVmZq?=
 =?utf-8?B?QUx2UEsyWUdpcDVVTlRLSXBoZWdwa1dFRWNGNU1OMExkckk2Um9KdklyWmtM?=
 =?utf-8?B?TUQyZDQreW9XR24zeHhpZHdKcGVXaEhadDk2djJyb1h3VlZ2TzBhak5KWS9H?=
 =?utf-8?B?WmY2eHVlcitVSlVmUm9HNmVlNDU1Q1hnNnZUYTRxYTl2MEhlT0ovR1ZYRDRn?=
 =?utf-8?B?K0Q1QXVkejNDNXUweGY5MzJBVWsyMTFuT0liR1JYZHBFT0U2OHYzZ2pvdkJW?=
 =?utf-8?B?Tk81OHhWN3FhUGtDb2NHQkJMVFZVcGdQWXRINTNBQitZV1NlaC9hR3B3UW1u?=
 =?utf-8?B?dlRYYXB0cFJHMU1tbkhLTXJRdW5pdFYzTzhOMmF6WmI2WndjN0Vqai9OL1lQ?=
 =?utf-8?Q?zH7pAM+DHiqtYB1PgBrby3/Xp?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 23a89228-5bc1-499a-057e-08dc0047ab25
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 04:04:59.7357
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hD1SeqiR9hH/AFSGCFUfqY1I+JDJWmmC91VDxm3cvr0UtT6PNBWsVQB+InBBHRq+Eod6+1f/r2VCuXaNqIMYcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7681
X-OriginatorOrg: intel.com

On 12/19/2023 7:36 AM, Kent Overstreet wrote:
> On Mon, Dec 18, 2023 at 04:18:29PM +0530, Sohil Mehta wrote:
>> I believe the norm is to have the linux/ includes first, followed by the
>> the asm/ ones. Shouldn't this case be the same?
> 
> I haven't seen that? I generally do the reverse, simpler includes first,
> not that I have any reason for that...

I couldn't find a kernel Documentation link handy. But, I found this
email from Boris:
https://lore.kernel.org/lkml/20190411135547.GH30080@zn.tnic/

I believe at least arch/x86 follows this for the most part. One simple
reason is to make it easier to find headers when a ton of them are
included in the same file.

Sohil