Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp273834rdh;
        Mon, 18 Dec 2023 20:27:29 -0800 (PST)
X-Google-Smtp-Source: AGHT+IHr46EGPYzKGvys+qqTRQTRjVIS1U+IHGFQkoRFYRJE/pduqHGFNvm/G8eAdYTZNxMc4ypf
X-Received: by 2002:a05:6a00:2d22:b0:6d5:ee7f:594e with SMTP id fa34-20020a056a002d2200b006d5ee7f594emr608324pfb.22.1702960049188;
        Mon, 18 Dec 2023 20:27:29 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1702960049; cv=none;
        d=google.com; s=arc-20160816;
        b=f+IldtbBleJLIkqb9Mu2e5vC3n45BzmKw896t+MbpR0vu2x4v0PQJmYPyp9f3Ltw59
         7yd3N1ep9rLelyqVE4Oa6hMxIP7BSDN5sKkQ9G3A8TSiTqMH2J6kA1lDoajUOMAjwW9a
         GNhRw6A3WPWknNRJI0I0gRyEUiNsnasefpmjtUbhdSNDhU34pyjbJfOunpfhHTV9RnF9
         HWxyyOqQTskIkd/KML5L1brKqvipR3n+S+V0ijaFxNzb2krd0Negbj3oFyq6b8b8Uy0F
         KlKK3Tw7ZpXQkkk/p6c+MdSCJovE5ojMSOYCcQ+klGoks8t6YkI/YtIMGtGCF0bqsTd8
         QNVw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version
         :list-unsubscribe:list-subscribe:list-id:precedence:references
         :message-id:subject:cc:to:from:date;
        bh=tVUAD9PN1l93dwPW/CeQKBtrKU6CsGpn13H+RdpvzCA=;
        fh=bO7QqOZggiuZIv2kiYKYk6++3Sxs5btaWVIXOG50Ggw=;
        b=LBbMu34NzfSZc/gScaVszNhJjLoIlU0pRnzvnOxZIbi5PL/nlWYpcgzuwS1sF4OKOx
         /Fmi44LecBTjTXvm2M4RGHiqBj+zisPdSVTT+xm73ZrV5v9QMXtXnvdr2bXRxsrol309
         6ZMBIOsbsefDfIHoDP+PAjaGr+HwxCb0SEQFAzuPVboUkq6UVUr6j77KfuI0OFWFOJYa
         O/vTmbGwJ/lMpkbSVnO5DyPmoRqNeiJHUaAeAx5b8gbhY97ahNd867tcZMT9JyvXjQQ7
         K+dt+m/FkWYBaheIc8FupAwOhkbN04Qp1n5cDzI1v0s4p3qSjf1feji2lxF1Jd2vhT2a
         siAA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel+bounces-4677-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4677-linux.lists.archive=gmail.com@vger.kernel.org"
Return-Path: <linux-kernel+bounces-4677-linux.lists.archive=gmail.com@vger.kernel.org>
Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1])
        by mx.google.com with ESMTPS id z8-20020a056a001d8800b006d748289f44si2957647pfw.156.2023.12.18.20.27.28
        for <linux.lists.archive@gmail.com>
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 18 Dec 2023 20:27:29 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel+bounces-4677-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel+bounces-4677-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4677-linux.lists.archive=gmail.com@vger.kernel.org"
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by sv.mirrors.kernel.org (Postfix) with ESMTPS id D7A75282D5C
	for <linux.lists.archive@gmail.com>; Tue, 19 Dec 2023 04:27:28 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id D0BBD18042;
	Tue, 19 Dec 2023 04:27:22 +0000 (UTC)
X-Original-To: linux-kernel@vger.kernel.org
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id AACEB18022
	for <linux-kernel@vger.kernel.org>; Tue, 19 Dec 2023 04:27:20 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id 7CAE068AFE; Tue, 19 Dec 2023 05:27:17 +0100 (CET)
Date: Tue, 19 Dec 2023 05:27:17 +0100
From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Keith Busch <kbusch@kernel.org>,
	James Smart <james.smart@broadcom.com>,
	Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v3 01/16] nvmet: report ioccsz and iorcsz for disc ctrl
Message-ID: <20231219042717.GB30580@lst.de>
References: <20231218153105.12717-1-dwagner@suse.de> <20231218153105.12717-2-dwagner@suse.de>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231218153105.12717-2-dwagner@suse.de>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Mon, Dec 18, 2023 at 04:30:49PM +0100, Daniel Wagner wrote:
> +	/*
> +	 * Max command capsule size is sqe + in-capsule data size.
> +	 * Disable in-capsule data for Metadata capable controllers.

A why on the disable would be useful here - the fact that it is disabled
is pretty obvious from the code.