Received-SPF: pass (google.com: domain of linux-kernel+bounces-4726-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <f4987195-97ed-4ad3-8bdd-dbf3fb590e79@oracle.com>
Date: Tue, 19 Dec 2023 11:23:48 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4.19 00/36] 4.19.303-rc1 review
Content-Language: en-US
To: =?UTF-8?Q?Daniel_D=C3=ADaz?= <daniel.diaz@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        stable@vger.kernel.org
Cc: patches@lists.linux.dev, linux-kernel@vger.kernel.org,
        torvalds@linux-foundation.org, akpm@linux-foundation.org,
        linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org,
        lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com,
        f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net,
        rwarsow@gmx.de, conor@kernel.org, allen.lkml@gmail.com,
        Vegard Nossum <vegard.nossum@oracle.com>,
        Darren Kenny <darren.kenny@oracle.com>
References: <20231218135041.876499958@linuxfoundation.org>
 <cf94f746-55d7-4f22-bb53-b5c1be843354@linaro.org>
From: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
In-Reply-To: <cf94f746-55d7-4f22-bb53-b5c1be843354@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?dTVZYUFNWXlkejl4YmlzVWhhZ2ZSc3BPUGxRdzVnVUxiT1I1a3FQdldXNmhW?=
 =?utf-8?B?TzZGTC8xMTNKR0JqOGVkbUNKU0lpck9oVFFRL01FcnBueDJoVDdXQlo1V2VS?=
 =?utf-8?B?d1FpVEhpemoxN3lKellwRDl5WUtiVXlLWXVBWUtvN1pVak1xYkQxaU5VVG53?=
 =?utf-8?B?aEg1eVZ5NVpMYzJFNWlTTklCb1JXQis5ejZwTnE1U3haZFBiTGR4dUJQMTVj?=
 =?utf-8?B?WWpKVkZ5cFRQNTRDMzdxWTVvM3MvR0JHMjhXWXVXODY3TVY5VkxoVkVhKzQ2?=
 =?utf-8?B?bHhCOGtEeStkMW94bCtoZzdmazFqQUkwWVhLWGxCNFJCaFdNOVNablhvZStp?=
 =?utf-8?B?VTRMOWh4OHpvU3h3WklBWGR0bGxxb08zRHlXQW5Makl2SkVDMjEzZHZMUnYw?=
 =?utf-8?B?cjhYVTZ6SU00WlNLZTZrN3BDemxlRXFhQ09VTzVuY29kU0EzVW1SeCs5UG1s?=
 =?utf-8?B?eXRZZGs2OFNpdVg0SlRTcXBjRTVjZU5vU0x3Ti9yMkVwUnk0dUlXTExqbG9F?=
 =?utf-8?B?SW1vQXZLS0pzR0E4ZjJzcnJmSHplNUZvWWJDWXo0bnM5bkVOS2pKREhNNXo5?=
 =?utf-8?B?bkhOaURqQ3VQd2dDejVNdGNsN2x4cEJ3QndoVGRyQnVja2ZFRFhmaGhqKzRD?=
 =?utf-8?B?b2V0eC9UOWw4cFlUUHR2Si9mYVVCc1BoaS9uOHB0eVl3d0o4ZEtrMWpMdWhy?=
 =?utf-8?B?RTB6M2s0KzBkdjZpM2kwY2hqQ055cUdyMUdUQ0VSUjBWbWpQbkxVcDYwVUxK?=
 =?utf-8?B?M1grZzZvWUZmNjVPUXZieEgrajcxb2gxRzZ0NUlGK0tTV3k0c0E1eXBQQVNU?=
 =?utf-8?B?ak5Pd2pJSzlrWi83OVExMkpnaVhFa3NISEo5aSsxWVgxZFAxQ3lvUVFManNQ?=
 =?utf-8?B?WmhyYWl1ZGQ5THN2TjRTbXEzZTBhSmlSRDJ5cHFJN3Z3UVpaR2RTSVovT3hY?=
 =?utf-8?B?MXRKb1lkRWQ2WnpLT1gweC9SNGhxOFltOUltQjFDV2FGY3FRblJNQ3FCL3R3?=
 =?utf-8?B?bTJOR2EwUlJ4R3JTb1V5TUJ3eEVvV1J5V3VoYVhhMlVWaHA4d0prUkdUTE5k?=
 =?utf-8?B?bHJDdDZvd2NxYlJDK25TRU5tQktlVDUzVDNwOVlVR0xuTlNRa0pxdGZxYktS?=
 =?utf-8?B?WFNYWFpZbjVucWhDWFlvclFkTVhBYVlzQnpJam1vRWoxWmhXTWczczVPcXhE?=
 =?utf-8?B?dmwwTlhxaE5SNWt2aEg0ZXJYRUhpbk55ZnpLdmV0eW1WZmdEUFlwcC82dEI2?=
 =?utf-8?B?Rk9hL0VkMTh5cVlSeENYRXdPRFZLaDYrbHlMSHNTNm1MVkVtQVpPOTlHNGpL?=
 =?utf-8?B?eUZaTmVrN0E0YXg4RmlRZHFBd0dZWml4SUw1V2NmMFJidXUrVG42MTl1UnNY?=
 =?utf-8?B?aWIrTXMyT3Ezd09IWUlLSDF1MmtKdEQ5aEpDemhOckJaeUhFcjdVVjFEWlhG?=
 =?utf-8?B?ekRuS2pTNDc1dlBNV0o1a1VNbE5XdlFKMk9zYWs5NGNDZzh2ZDlkNWhCSzBj?=
 =?utf-8?B?RllWNUdIUk9aU3JtVnBPT1pCeW5aT043M3VmbDRkVmZ6bHF1MFRUcjY5UFIx?=
 =?utf-8?B?Q3hnUXNFbDdoc0NVVlNjbmo3bGxPMDQyb0JwOU5QdWd1a0dOY0x4cW83U3Zk?=
 =?utf-8?B?bTNjSWZTSmovZDBmRHN0SG1UV0x1NmdVRHQyQUs2RGJGUFpzNUwvSkNkSkk5?=
 =?utf-8?B?cVdPR3QvcHFsZnY0bkxwUjdOYVhIRDhTSm9YakFabStnWGE2QlVtdlYraTdI?=
 =?utf-8?B?RHlrcFRlMENPSkVUeTJDNHc0TDh0eVEzYmJQckJMRG5wRG0waGtuT045VkFm?=
 =?utf-8?B?dU02UFBBSk1HWitFbFJSYk5BY1RBNWFCbkxBLytGbllmRDhwWXJKNWVhZzdE?=
 =?utf-8?B?NTZOY3d2RnFpUndWaWYwamVOVHRVaXlLcyttUW1zQmk4bk9JK3VaYnQ3YWor?=
 =?utf-8?B?dTFqazRLekhJTmlnOFlnQW50czdvVHJnNitXUDU3Qmt2akJ1cWowV1M5YzU1?=
 =?utf-8?B?bk5XVW50b1hIZ0hSMVNBL1gwWm5VNVFNanRpeVJMYUs3SUp5N0dVMGtmcm10?=
 =?utf-8?B?YUFmUGx6RzlUdEdkQXJ2VmU1TkpGNnlwSWVBUis1U051NU5ING1OQklQT0Jp?=
 =?utf-8?B?Rm8zbWNwMG5PZGpRY2gvRUxCTmQ0TXRkWGFCK1drOEpGUVNKRldKRVVZdGF0?=
 =?utf-8?Q?zMaBzXRNR4zDhPQASyTZj6w=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	KwmeNd8kx8MtZn3y2DgOF0Ql7bpBWOhXaKPnP1D0wIgnAYUmA2AwxhBOBgxf+K95BhZHsfa5W2YYTndXV1xul8zQ5VYcBUbYCFwF1IEn/j80lMR8dg9MEoRfmVqBrMcXsot1iDwSQHpMIWhskyH5AT4IQkIMQiapFCXTO7XbNb2Md0U9eRgWcPTltE4AnaHrA0HCIs3OSJTDiLBFA8BeJ0kHlYLhquoQZJ1NqWfOW25f7ARVM5c1ZJWO3rOYvWHCiTSxT/JtvuCIalEr2jU8VaMThdTMh2ynv/H3Sv+FrglG+SWiappHIrRLAJlGjz4sYMrJPrBqWwKHO89q+A0kLq9nTqqAt8eL0J6aogArxA/lFMUrl52f4bk0pP3qKT+AADGwiS1Narz4T8YwvaC7wFP40BVffSMAjBFmpAtwYMsFPmC9q2gCzcKlJPTjMHFCWEvMmGKjQa/YprC2XE4IjIiMP3++IuuHkvjhI736WyOGbzVvwEH3Qtl8vAVcs14Gla0Wr9HboGIsnaueXYmDkz4NYHvNorq5iZD/2MbWpydywipNk7Uhu8EuIBvb4jvgB7GxjD6pQ62oPLb1+2oGDF5cy0xMMc6TS5zIN//W+cE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a61193cf-b90c-4140-94fb-08dc0056e43f
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6290.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 05:53:57.9926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FvYUrzJc9ODGbLtf1EIFRZeZVJXPTyxAE9H6vPWNy3tcYH2JFYShTN4XdICIbED6bMdz7T5nYPQ21l4MHGf7zJALb0W0enSo3iBFtddZaQt1LEZEoC7N5VSbhR/vbC/0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB6430
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-19_02,2023-12-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0
 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=884 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312190041
X-Proofpoint-ORIG-GUID: r_kyL_Bg5-1_B6Bh45ZgAMSi5PT6CAJ3
X-Proofpoint-GUID: r_kyL_Bg5-1_B6Bh45ZgAMSi5PT6CAJ3

Hello Greg,

On 19/12/23 10:57 am, Daniel Díaz wrote:
> Hello!
> 

> 
> -----8<-----
>    In file included from /builds/linux/include/linux/list.h:9,
>                     from /builds/linux/include/linux/module.h:9,
>                     from /builds/linux/net/core/skbuff.c:41:
>    /builds/linux/net/core/skbuff.c: In function 'skb_segment':
>    /builds/linux/include/linux/kernel.h:847:43: warning: comparison of 
> distinct pointer types lacks a cast
>      847 |                 (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
>          |                                           ^~
>    /builds/linux/include/linux/kernel.h:861:18: note: in expansion of 
> macro '__typecheck'
>      861 |                 (__typecheck(x, y) && __no_side_effects(x, y))
>          |                  ^~~~~~~~~~~
>    /builds/linux/include/linux/kernel.h:871:31: note: in expansion of 
> macro '__safe_cmp'
>      871 |         __builtin_choose_expr(__safe_cmp(x, y), \
>          |                               ^~~~~~~~~~
>    /builds/linux/include/linux/kernel.h:880:25: note: in expansion of 
> macro '__careful_cmp'
>      880 | #define min(x, y)       __careful_cmp(x, y, <)
>          |                         ^~~~~~~~~~~~~
>    /builds/linux/net/core/skbuff.c:3630:32: note: in expansion of macro 
> 'min'
>     3630 |                 partial_segs = min(len, GSO_BY_FRAGS - 1) / mss;
>          |                                ^~~
> ----->8-----
> 

Note:

Caused by this commit:
98c6fb04f83b net: prevent mss overflow in skb_segment()

I don't see this commit being queued in other stable branches yet, 
5.4.y, 5.10.y, 5.15.y, 6.1.y, 6.6.y but only 4.19.y

Thanks,
Harshit

> Greetings!
> 
> Daniel Díaz
> daniel.diaz@linaro.org
> 
>