Received-SPF: pass (google.com: domain of linux-kernel+bounces-4731-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <5460aaf1-44f6-475f-b980-cb9058cc1df4@linux.alibaba.com>
Date: Tue, 19 Dec 2023 13:58:21 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/2] mm: fix arithmetic for max_prop_frac when setting
 max_ratio
Content-Language: en-US
To: Matthew Wilcox <willy@infradead.org>
Cc: shr@devkernel.io, akpm@linux-foundation.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, joseph.qi@linux.alibaba.com,
 linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org
References: <20231219024246.65654-1-jefflexu@linux.alibaba.com>
 <20231219024246.65654-3-jefflexu@linux.alibaba.com>
 <ZYEWyn5g/jG/ixMk@casper.infradead.org>
From: Jingbo Xu <jefflexu@linux.alibaba.com>
In-Reply-To: <ZYEWyn5g/jG/ixMk@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 12/19/23 12:06 PM, Matthew Wilcox wrote:
> On Tue, Dec 19, 2023 at 10:42:46AM +0800, Jingbo Xu wrote:
>>  	} else {
>>  		bdi->max_ratio = max_ratio;
>> -		bdi->max_prop_frac = (FPROP_FRAC_BASE * max_ratio) / 100;
>> +		bdi->max_prop_frac = div64_u64(FPROP_FRAC_BASE * max_ratio,
>> +					       100 * BDI_RATIO_SCALE);
>>  	}
> 
> Why use div64_u64 here?
> 
> FPROP_FRAC_BASE is an unsigned long.  max_ratio is an unsigned int, so
> the numerator is an unsigned long.  BDI_RATIO_SCALE is 10,000, so the
> numerator is an unsigned int.  There's no 64-bit arithmetic needed here.

Yes, div64_u64() is actually not needed here. So it seems

bdi->max_prop_frac = FPROP_FRAC_BASE * max_ratio / 100 / BDI_RATIO_SCALE;

is adequate?

-- 
Thanks,
Jingbo