Received-SPF: pass (google.com: domain of linux-kernel+bounces-4732-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <ebf302c5-edd8-451d-b9fa-69733b354fab@intel.com>
Date: Tue, 19 Dec 2023 08:05:34 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC V2 0/4] perf/core: Add ability for an event to "pause"
 or "resume" AUX area tracing
From: Adrian Hunter <adrian.hunter@intel.com>
To: Peter Zijlstra <peterz@infradead.org>, James Clark <james.clark@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>,
 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
 Heiko Carstens <hca@linux.ibm.com>, Thomas Richter <tmricht@linux.ibm.com>,
 Hendrik Brueckner <brueckner@linux.ibm.com>,
 Suzuki K Poulose <suzuki.poulose@arm.com>, Mike Leach
 <mike.leach@linaro.org>, coresight@lists.linaro.org,
 linux-arm-kernel@lists.infradead.org, Yicong Yang
 <yangyicong@hisilicon.com>, Jonathan Cameron <jonathan.cameron@huawei.com>,
 Will Deacon <will@kernel.org>, Arnaldo Carvalho de Melo <acme@kernel.org>,
 Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
 Ian Rogers <irogers@google.com>, linux-kernel@vger.kernel.org,
 linux-perf-users@vger.kernel.org
References: <20231208172449.35444-1-adrian.hunter@intel.com>
Content-Language: en-US
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
In-Reply-To: <20231208172449.35444-1-adrian.hunter@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 8/12/23 19:24, Adrian Hunter wrote:
> Hi
> 
> Hardware traces, such as instruction traces, can produce a vast amount of
> trace data, so being able to reduce tracing to more specific circumstances
> can be useful.
> 
> The ability to pause or resume tracing when another event happens, can do
> that.
> 
> These patches add such a facilty and show how it would work for Intel
> Processor Trace.
> 
> Maintainers of other AUX area tracing implementations are requested to
> consider if this is something they might employ and then whether or not
> the ABI would work for them.
> 
> Changes to perf tools are not fleshed out yet.
> 
> 
> Changes in RFC V2:
> 
>       Use ->stop() / ->start() instead of ->pause_resume()
>       Move aux_start_paused bit into aux_output_cfg
>       Tighten up when Intel PT pause / resume is allowed
>       Add an example of how it might work for CoreSight

Any comments?

> 
> 
> Adrian Hunter (4):
>       perf/core: Add aux_pause, aux_resume, aux_start_paused
>       perf/x86/intel/pt: Add support for pause / resume
>       perf tools: Add support for AUX area pause / resume
>       coresight: Have a stab at support for pause / resume
> 
>  arch/x86/events/intel/pt.c                       | 63 ++++++++++++++++++++-
>  arch/x86/events/intel/pt.h                       |  4 ++
>  drivers/hwtracing/coresight/coresight-etm-perf.c | 29 ++++++++--
>  include/linux/perf_event.h                       | 15 +++++
>  include/uapi/linux/perf_event.h                  | 11 +++-
>  kernel/events/core.c                             | 72 +++++++++++++++++++++++-
>  kernel/events/internal.h                         |  1 +
>  tools/include/uapi/linux/perf_event.h            | 11 +++-
>  tools/perf/util/auxtrace.c                       |  4 ++
>  tools/perf/util/evsel.c                          |  9 +++
>  tools/perf/util/evsel_config.h                   |  6 ++
>  tools/perf/util/parse-events.c                   | 33 +++++++++++
>  tools/perf/util/parse-events.h                   |  3 +
>  tools/perf/util/parse-events.l                   |  3 +
>  tools/perf/util/perf_event_attr_fprintf.c        |  3 +
>  15 files changed, 255 insertions(+), 12 deletions(-)
> 
> 
> Regards
> Adrian