Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp323537rdh; Mon, 18 Dec 2023 23:04:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFsmNgn+NRrJ/V/41VoLvrWOvUzAKA11tXsTZNOvH+vq8PxJRKZWG+B/XLH0gtNN5Hej0HS X-Received: by 2002:ac8:5781:0:b0:425:a31f:8c9d with SMTP id v1-20020ac85781000000b00425a31f8c9dmr22583834qta.32.1702969473916; Mon, 18 Dec 2023 23:04:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702969473; cv=none; d=google.com; s=arc-20160816; b=0DrLSj0Kf7X3L/GHeqB6VrcRpPtlXX4ei99AkGJBswMZtg2UzNSuBnbGgMUeV5yul9 jd6EFtbr+KSCuCNbj46YRsy3bWvbfEEK6MWbxy2fHq0pu5rubDjwNPS4swSizammlA5Q whuAkRmLuqsbVyBJDHQ6lDEIbYaecb75evprtXKL8q78pG5Td/xMPHkhWISzVx09xcZg SpzKlEhtBrQbY/5jomInMos9KQN0aYWroRHUA1Yl0FNxJxCRDpB2M1wCCj8FJgnPmwWH JhjEsoFON+Q4+2CEp1GZt2RqixmEyZ8tNisIWgWGnqN3VPHcJ4KgnJvNkIKmWLuezpLN oGkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=MkPfR7lqGwzgji3xkFR/F6aOTx95fUBqDD8cPbAtw+8=; fh=MxbzW9Ul2LzsP4KSTCRBKiSuwlA+wQbXPsHBvQtzwlM=; b=WcHXqeKHR6JEJB1tF3y5KVM6+thgzPGc3E5vvO+o6nyWcPwmT0R/C4mRJF11yQAl19 EmVKoqXx3ywohR7KgoFQx7iu6az7zap8/GpXTj4tqnBNAqUBC5G1f7RK95+j+3C7xXdX u5zjOfwpBqfKcYb1QyVbu23QCJXS4pnmuxV9Sc6GBIy0BsDQsbNdALhTHZt6OEbqEfkY ZI3MWieFcLSo2bFHffyMu5+BCfBSo9O/fs2d0jZiNu8ywrwOq/2F5xePrSuYwkoUGAmI uD0rK7y5K0U2keh3ZB70E0IEGHbxsbUfQllR1r+0VXn5yBrMThba8N0LbWuYiJ6qHmE1 j80Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rsku3z7Q; spf=pass (google.com: domain of linux-kernel+bounces-4780-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4780-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id bl15-20020a05622a244f00b00423e9c97548si16397216qtb.285.2023.12.18.23.04.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 23:04:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-4780-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rsku3z7Q; spf=pass (google.com: domain of linux-kernel+bounces-4780-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4780-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 475D61C215A0 for ; Tue, 19 Dec 2023 07:04:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8E9A08BE8; Tue, 19 Dec 2023 07:03:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rsku3z7Q" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BDDE882E for ; Tue, 19 Dec 2023 07:02:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-55322dbabf6so2607910a12.0 for ; Mon, 18 Dec 2023 23:02:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702969377; x=1703574177; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MkPfR7lqGwzgji3xkFR/F6aOTx95fUBqDD8cPbAtw+8=; b=rsku3z7Q7POdWN1RHk63mfThfY7C5ZB+WCdB6A8X6I2s8nyeMZrEPk26t63lHK2s8M F/wZoU8Yi8QcQEvYD/626npTzwAueN9fRnsCG96gFC1uVu5k22OYZngGRwRHyuIj2d1R 2PKYRfimB32Fcs9F+focJX8GifUq8bf2RP6MURn6urhtzo70RG4lsJVznIEcPjhD951F wSpc8nbweFYXpjEiPsvMEUtjyXaBRG1rboTm9XSRa6bt+q159ibTu8h1aEI7lIda057/ N3PtQB5VYfUkemaoBMTH7iYmQbdTv6OAv5xArlMObBJkweeZBIZP3hzMn/MGVVB7PKz7 dqSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702969377; x=1703574177; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MkPfR7lqGwzgji3xkFR/F6aOTx95fUBqDD8cPbAtw+8=; b=DrTBHtMWi61ryzSZyI2Zyqv8r5b/yn/mAMQOEslh3E6vv/8icom6UxuwbYIG+WN8aN Wgf5f9y56GflKyocWZBClbCwPlVoOSYwxEnfOVgFCR/gS2wuEQWduS+bSnkvC6+n7cXM aq2GM1flaGCG1i7mLSLui6lIlR87xyk4XrzHUY6zFSCLwJ5x6QDEpsrwx1nUTra9+0xy 2fXC/RyiQgwAc5wbktYNoEOY6jB9zPGvkWHy3eogfSR1LCebgcu08MUSVGaldrd4PsFB WrYBNjaHGZGl8qIumGJr0EzPHCVppQHZkkpbqDspXrSARtd+SbsvUEvoB7VDBXTCx6J1 b3gQ== X-Gm-Message-State: AOJu0YzrtaFOOAyMEWuv0+pjeP0TUQHFfnYMs1RfxVPxIp8JOiyOx/4S Z1Ar8Z3zyoT8BY1Cw0JingdWsw== X-Received: by 2002:a17:907:1a51:b0:a23:49f6:3ae9 with SMTP id mf17-20020a1709071a5100b00a2349f63ae9mr1263775ejc.61.1702969377463; Mon, 18 Dec 2023 23:02:57 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id jw23-20020a17090776b700b00a23365f1290sm3080362ejc.218.2023.12.18.23.02.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Dec 2023 23:02:56 -0800 (PST) Message-ID: Date: Tue, 19 Dec 2023 08:02:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/6] arm64: dts: qcom: qcs8550: introduce qcs8550 dtsi Content-Language: en-US To: Tengfei Fan , andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231219005007.11644-1-quic_tengfan@quicinc.com> <20231219005007.11644-5-quic_tengfan@quicinc.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231219005007.11644-5-quic_tengfan@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/12/2023 01:50, Tengfei Fan wrote: > QCS8550 is derived from SM8550, it is mainly used in IoT scenarios. What are the differences? You need to describe the hardware, you have entire commit msg for something useful which will avoid such comments from reviewers. > > Signed-off-by: Tengfei Fan > --- > arch/arm64/boot/dts/qcom/qcs8550.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/qcs8550.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/qcs8550.dtsi b/arch/arm64/boot/dts/qcom/qcs8550.dtsi > new file mode 100644 > index 000000000000..254657f46c5e > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/qcs8550.dtsi > @@ -0,0 +1,6 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +#include "sm8550.dtsi" This is a weird file. I thought qcs8550 has differences from sm8550, e.g. lack of modem, so why do you claim you have here MPSS? It's really confusing now. Best regards, Krzysztof