Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp343827rdh; Tue, 19 Dec 2023 00:01:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGa4kBmTwTFEIrx1H5SHqGVbdRtuF0N1GtQhljPsvQ+sLZoZAQoJ2qxXB0KFXA0zg4t7tjj X-Received: by 2002:a17:902:e74e:b0:1d0:c2be:3d92 with SMTP id p14-20020a170902e74e00b001d0c2be3d92mr21899369plf.39.1702972900104; Tue, 19 Dec 2023 00:01:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702972900; cv=none; d=google.com; s=arc-20160816; b=I+PE2V36dxeK04ms6ut0zxanaeSH+qrndN/wHdb0CkieJjB+l/CkY1j5rRdUxstHjo EEC74EojbZTQb3kvx34ePr5rL1BEsoQZFdzKC2R+GOmP9ZnokY/ldPAOY9m2PGJoYcFp qBcBX6Tr+cl5jE2vPzi3aR3c0XyeSd0Hl+B5NrDE9+OvtrVseq2omi2jD9x7t16ucXWI 5VVjwrGyin7ZTnyddZLx8Ks8/DBJHMu+TulkwTkDe/sWxM9d0hYgvYvXtrzS8JQ/Cqs3 Dqzub4bybJhsy0WsNpNf3uS/RXcCMKkFd8Brv0datSJaZmhBPggZFp3XktTcjZrtGq/L n+vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature :dkim-signature:dkim-signature:dkim-signature; bh=Tnay4DoOOY0mam4Tml11YvRfOpHCwJIlf0uwch/HJSo=; fh=Ob8FspbdAv2lvfy9oyzcNqJb9FlG/MYewgbmONDw7dw=; b=QGJ6XoN87F0cJnTxUBhA9kjwR7r73fTwO+Sqt6WM8lKUuGeqXGb3aaCFlhJWM15ksp /qqJsJq1OwycSadzt4nWdv3gn14VmqYHYgy8b60P9WQ+y07hvrN9HuC/rOJs7ueOl7w9 YUF3W6xcBJ7D2CutVJvxDhIXtnhQFlVXdhc4cNtPt+J2c3bbLcboO2+Qi6zCB9pwP6Al L2cJTttbLS3pWaKlf9rOmjLJK9C3GNmd5rE0y9dJJ2xQbYlzhUqzKJQYtqwtGq8jO4Uf dBdSmzbeVwdbsbUqQAJ6hmCL3RIQR/OEkazW9k4SEHecNm4k7P9h+Q1CDcEC0xayfeio RL7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=16eGEn4y; dkim=neutral (no key) header.i=@suse.de; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=PEYDvNQc; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel+bounces-4852-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4852-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id iz5-20020a170902ef8500b001d3ab026b7bsi4102951plb.563.2023.12.19.00.01.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 00:01:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-4852-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=16eGEn4y; dkim=neutral (no key) header.i=@suse.de; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=PEYDvNQc; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel+bounces-4852-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4852-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5E41D286DA4 for ; Tue, 19 Dec 2023 08:01:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B42EF13AF5; Tue, 19 Dec 2023 07:59:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="16eGEn4y"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="R+aha12P"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="PEYDvNQc"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="QwcAvQuY" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E259411CB3 for ; Tue, 19 Dec 2023 07:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E8C671FD5C; Tue, 19 Dec 2023 07:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702972784; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tnay4DoOOY0mam4Tml11YvRfOpHCwJIlf0uwch/HJSo=; b=16eGEn4yPSRWSqTJNkRSQp1dsivVScPsrCsq4z8bqAx+3Tk8PunuE96Z9/AZ/SCvkDvztS ZxFj5C1DZQ0d+POf4vDSXL5x3mkv2iZJG7nYxcESvBtek016NtFVjziKrwhn5gsrB0YIa5 nYRj/rp8+ulO2WTY0RCu//8uOcH8Bhg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702972784; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tnay4DoOOY0mam4Tml11YvRfOpHCwJIlf0uwch/HJSo=; b=R+aha12PdVaJNUrDfTgiYJWba/r6s9gAH06pvxcN/Ic/vDZWfyaJsdrUkjZx+8NZALoetw k1Q4qIBR8uvznTCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702972783; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tnay4DoOOY0mam4Tml11YvRfOpHCwJIlf0uwch/HJSo=; b=PEYDvNQclWzq9hBY8wYZPWxKdO9D7d5BbKp1cfClPNdbMAcjWDWHNuUU1D+FU1t8hBS8cS XzEZf9NyHeqDI3nnZoW0vWOHns/a8fB78SvxFYMxb94HCHcfgusKIGbFyDGveUlldrBa/H Wp1KPyP8ea8ZzyoVf9lTJfgDO4Zm3Qc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702972783; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tnay4DoOOY0mam4Tml11YvRfOpHCwJIlf0uwch/HJSo=; b=QwcAvQuYyMlsLDBDEnyFt0ts3tQI8KFkp8w5BgHfATwAr9umcqK7ql0a2QbCPf3uP6Cohv W2CE07eMZHVId2DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8B66113AA6; Tue, 19 Dec 2023 07:59:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id iPXHHm9NgWWyegAAD6G6ig (envelope-from ); Tue, 19 Dec 2023 07:59:43 +0000 Message-ID: <20d7d09b-f08f-4ef2-b230-3d2426688efe@suse.de> Date: Tue, 19 Dec 2023 08:59:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 09/16] nvmet-fc: free queue and assoc directly Content-Language: en-US To: Daniel Wagner , linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Sagi Grimberg , Keith Busch , James Smart References: <20231218153105.12717-1-dwagner@suse.de> <20231218153105.12717-10-dwagner@suse.de> From: Hannes Reinecke In-Reply-To: <20231218153105.12717-10-dwagner@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Level: X-Spam-Flag: NO X-Spamd-Result: default: False [-5.02 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[7]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-2.72)[98.78%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from] Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=PEYDvNQc; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QwcAvQuY X-Spam-Score: -5.02 X-Rspamd-Queue-Id: E8C671FD5C On 12/18/23 16:30, Daniel Wagner wrote: > Neither struct nvmet_fc_tgt_queue nor struct nvmet_fc_tgt_assoc are data > structure which are used in a RCU context. So there is no reason to > delay the free operation. > > Signed-off-by: Daniel Wagner > --- > drivers/nvme/target/fc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald, Werner Knoblich