Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp356141rdh; Tue, 19 Dec 2023 00:31:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IG2v2KMVTUcm+nc6zASC9PyWymCsqhJpcO/AYeiDSOuZ7ffC9Uta8vFn4TNlzAFXoDjdDEx X-Received: by 2002:a05:6808:10cc:b0:3b8:b063:5049 with SMTP id s12-20020a05680810cc00b003b8b0635049mr26006180ois.74.1702974682978; Tue, 19 Dec 2023 00:31:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702974682; cv=none; d=google.com; s=arc-20160816; b=RwtOshaFRjK8FRzgs8h68i0FAY+z6BeBjV1D2HKa97HKG9WKaHJC2vrcSH7a3EOhS7 FBYrEFtn7Z8Be2gRfHMHmHUu2eeYocLnmIXtYB3IJdjRsjTuQhWYBZSDaIzAK/vK5Iun yK69kUAe7ALV7Eb1GEfg7b3Z5UdbakZjJ4LIcwBXVEXB4oDMRJSg5jd7uwVn1W8TNDuw UeNwDunHNp6IfEl9zkjkgCd0ujQEBVe3lGE3lnZU4ijfnVa/H86dLPzKtmAF5F8wcman vQ2s6pWePegNnonT2NU6PJMfkh1BKY8WSCIJfHd8S5oQbF8PL3UgYSBlht17mgK4xLhv JJlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=i5VFZBXoek/PmoENd13wHvQBkwNetTGq8HZiKbqScho=; fh=+AUjbRkOJPdt5A/Vu5lz5b37EU6KyWRgcI6P/kfieik=; b=0p8Rw3NjkTGgK6eh4B1QcMDeOqDQW2kH2xhNCxOZs2y+Y7+gC6N3+dNgYUaAjqpo8N /FCZPY30+pNQ95cJ2KJtTXSw+dGcgdDRg6DXrnmRt+mSaD7D4uDuuUJneF2sJ8cNgLXD ZCSmglYTwMRzQisf3D+q2FmqsmZTNmVSaK8eBiJFWqE0Qxm7+mrJXODCX7RBhJeNkA48 QL8dWEWRgUxhed8krDkbkoEjRh37sZyprtaa+zfsSyE48jKydRZ44NP1h9GY+jCMrPCg o2mFPS0E72CXUI2Pqor8lxjKez4jqZ/SuvHutLsiyUyV5RB6sv+GGg6a1y92JrMJUMmd 30BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ErA7m7+q; spf=pass (google.com: domain of linux-kernel+bounces-4891-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4891-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id w17-20020a056a0014d100b006d3c35096dcsi5341513pfu.320.2023.12.19.00.31.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 00:31:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-4891-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ErA7m7+q; spf=pass (google.com: domain of linux-kernel+bounces-4891-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4891-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 99EA4285249 for ; Tue, 19 Dec 2023 08:31:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 366EE11712; Tue, 19 Dec 2023 08:31:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ErA7m7+q" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 023B212B69; Tue, 19 Dec 2023 08:31:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a2339262835so297926166b.3; Tue, 19 Dec 2023 00:31:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702974672; x=1703579472; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i5VFZBXoek/PmoENd13wHvQBkwNetTGq8HZiKbqScho=; b=ErA7m7+qTMUR7pbg4F2Wtnx7qY3nyiu4ZkVc3WWVTTdd2YD1yWdRO6Tq2oCyKiUnTe sH5CoBTUQ9sO2+/QWPekzPTsMxUt1MazxGqSuqpDt9jFVH6IyOwA5YCxaQ88gQssmKiN 5ntbzAO336FAVO+adDxOhh0Lez8cA2UkzonsaYrkiabIyKFRTSjrM/QnNZrJoPHW92Xw rXn1mmqaHJR3Uo3W4UR9cY+pfQ6WS6HsbJyF/2BIEzPYuxTLdd40UeiICevI1uR2LpZb aGcsGc6OY1UA4BKce/xOfTJQozZBQ0OhuuNpzEWVYDiUuMtKvak2bgu/JygRaEHDUpWD tvvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702974672; x=1703579472; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i5VFZBXoek/PmoENd13wHvQBkwNetTGq8HZiKbqScho=; b=BeSougi1KngTlZL3inT97kzYqS97jTedu5P+K6YZo2GSMpnubE0h09RqRS0SBr7ze2 D+siDBM9h9tD2k+Z2JeLUR8drCJwNex8S+rSNqSU1MSHrUUsvZ0Lmm6EX6oXymKzIwtG 9m5SwwZptxszBaSAWgdIgZKqs4bTnqtxZ96CndFFJWWaoKpsc93OFCinFK+BcHjm+ZYN kP5GdPW2rsLkIUcohAqlUIHCyGty+7/r+6whGGO7dCjfUr+/h7E0hBU3vRbpbJkbamJt ZCnOE0y3ZrtZ1AlNiJOd1ZVHZ924hMHVv+zAGLH4kZlZlzjtVIhyL3GuVtxcbJ3/LTE2 qYcA== X-Gm-Message-State: AOJu0YydFM7ixNdt3lDzChSUIwfirWZuwDFXqqSrjpH403aA9/0u7JJw iAShBxF2ITmrZTPS6Rh41alw3CwacwiOKLZmPEJwpezqlhJaRQ== X-Received: by 2002:a17:906:d6:b0:a23:ff8:cda6 with SMTP id 22-20020a17090600d600b00a230ff8cda6mr4758403eji.75.1702974672002; Tue, 19 Dec 2023 00:31:12 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <1702953057-4499-1-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: <1702953057-4499-1-git-send-email-shengjiu.wang@nxp.com> From: Daniel Baluta Date: Tue, 19 Dec 2023 10:31:00 +0200 Message-ID: Subject: Re: [PATCH v2] ASoC: fsl_sai: Fix channel swap issue on i.MX8MP To: Shengjiu Wang Cc: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 19, 2023 at 5:12=E2=80=AFAM Shengjiu Wang wrote: > > When flag mclk_with_tere and mclk_direction_output enabled, > The SAI transmitter or receiver will be enabled in very early > stage, that if FSL_SAI_xMR is set by previous case, > for example previous case is one channel, current case is > two channels, then current case started with wrong xMR in > the beginning, then channel swap happen. > > The patch is to clear xMR in hw_free() to avoid such > channel swap issue. > > Fixes: 3e4a82612998 ("ASoC: fsl_sai: MCLK bind with TX/RX enable bit") > Signed-off-by: Shengjiu Wang Reviewed-by: Daniel Baluta