Received-SPF: pass (google.com: domain of linux-kernel+bounces-4984-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <ef5a6cf0-4350-483d-a1e9-ce8b0ef71280@siemens.com>
Date: Tue, 19 Dec 2023 10:54:35 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/4] dts: iot2050: Support IOT2050-SM variant
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
 Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Bao Cheng Su <baocheng.su@siemens.com>,
 Chao Zeng <chao.zeng@siemens.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 devicetree@vger.kernel.org, Li Hua Qian <huaqian.li@siemens.com>
References: <cover.1702917360.git.jan.kiszka@siemens.com>
 <11e0b0c8b828254567a8ff89820c067cacad2150.1702917360.git.jan.kiszka@siemens.com>
 <8b3daa3c-dbf8-4286-b04e-011cd9b0efa5@linaro.org>
 <4c31adc5-3fc5-47bc-9766-6d3d1eeddb65@siemens.com>
 <fbb29d81-9ea0-4468-ad47-f6668c2be277@linaro.org>
 <de3f4778-51d6-48ab-9d4d-451f2ba01a3c@siemens.com>
 <3d2662be-3a55-4390-bd2a-cfa5cc53510f@linaro.org>
From: Jan Kiszka <jan.kiszka@siemens.com>
In-Reply-To: <3d2662be-3a55-4390-bd2a-cfa5cc53510f@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QldEaC9TTG4xcDAwMzd3TEFlVEEvY3psWmw2dHZVRElabi9jWi93TEgvN0or?=
 =?utf-8?B?dTF3MmRVdDNVYjNpRkNVZFBpK3V4WGo2QkNUeldpMWhDaExDb2FvMm1RMTA2?=
 =?utf-8?B?L3JvQXJWYnFIejhlY2gwbHRsQWlGT0F3aEVrSGt0YXJQei8xRXFyZVVjenhL?=
 =?utf-8?B?SUNUdlBOaFV4c1l5Q0lqZGRHQ0ZwMjRFSTRjdUJ5cnhHTW5EQThEa0tlOWR6?=
 =?utf-8?B?bmRQVXNkU2NqQktTR3I2QklLSjFhbDBSQzRJYVkzeVpEM2dnNHFLamJNVjVJ?=
 =?utf-8?B?T0JxM2k3dzUyNm8zSnVnbU5UMHN4Y2FzYWIxVjlNUXIrSEtyV3ZHUlE5cEVG?=
 =?utf-8?B?aHNQcXBudXljMU05VTN2K0VNSUpKYVN6c09jeG5ZYVZBYVd5ci90d1JVTEFH?=
 =?utf-8?B?NVA4VjlGR2E2cFJGdGtwQ1ZWQ2FoOTkralNsMjFzems0OFhUV2xvYmZvU1B2?=
 =?utf-8?B?TEY5VlZUQ0R4N3hLZkhJemxHUWZqdmFUQ0thcDBubGxPemFwZmlJRlZXaUg5?=
 =?utf-8?B?YVZXd2RDUjJNQWNZSitTTjZmVkgrbDBER2QrdFp1Ni9tN0NqT0kvTFhjTktt?=
 =?utf-8?B?T25zby85dDd3V1YxM0Foc1dIMGRLMzZtZWFKcmNmVFBWRVNZc0E1Ty9ZOTRK?=
 =?utf-8?B?NmJsbVNQK3BGTVEwV0Vva1cxNWQzcG1hTWNPQnJxcGJ4ZFZ1ZUt1QWw1cXVM?=
 =?utf-8?B?cGZ2dEhVSHF3ZE1XN1hTcXJCMmNrWnhSeno3amx0UjU4YmFvSlpGeGRmS1dD?=
 =?utf-8?B?U3BQRTN5YmZZcDJZZkNSSjYySkNmRnpqSWh5RUpwSFZXSW5QTTl1MWtPajNq?=
 =?utf-8?B?cmpZWWY3eUhaeDJqQXVkNzdrN3N4L1lYOVY2aXduekJvcUx2b29paFgrZENF?=
 =?utf-8?B?OE96bXJIamZOVEFUejFkalE5TjlFS2luNXhjblp6SkRxSzhFVDNLdVZsano4?=
 =?utf-8?B?T091ZGIwRlJpUDh0OGlkSWpqQWhZODRuUi9zd0lkaU41UklTaDd5UlZIM1ZG?=
 =?utf-8?B?TGgrNVFZeXpHU003SGJCQ044cGFIdmpaUC9wa3o2azJ6eTBDb2RROVBEc1Yr?=
 =?utf-8?B?NVZkUjVWY1ZVYnZSbWtqNGhyVEo4aUFLMzgyTnZjWjR1eUZCK29WcUFXZFZR?=
 =?utf-8?B?Qm9rUW1TYzRnMVQzWEFWbTdzazkrYTVmQkhVdHVCeGE1MC9QclV6SUl1VTNt?=
 =?utf-8?B?cUpOVUt4R2crZG82K3ZPcVNRdHA2a3VCN0lwcmo0SXE4UkJudjdsMng0NWpH?=
 =?utf-8?B?R0RGVVJIUnFNb25vUklSelZRZDR1WkZLWFhWcVpNSzhpVzlZS3VFdEVmZlM3?=
 =?utf-8?B?WVd1eFB1bWZWS29mRWp5ZlZZakFRdTZvMFRhSXpYaU90bWxVUGl6ajhUSzhP?=
 =?utf-8?B?b1ViMjRLSk5HVExjNkk4RWF4R2pNZU1ycUhQd2p2WGs4aFZENGtOZFE0TTZM?=
 =?utf-8?B?MlpIb2VHYzNEaklySk5nVjBkMlNxeHNJM0JDRzgwL1NKZ2JTYm80Y28rN2dZ?=
 =?utf-8?B?S0VoNHhTVWJSeERoVFU2c0pwcWNmcitRejM3U2t6NkRWRkxCSXZldTZNclcz?=
 =?utf-8?B?QlBVMUo2TzR4eWdiMTRkZU5wQ2NvZkszUjNSTEszdUgrQzdLODlhdklZbmpJ?=
 =?utf-8?B?anlGemVocVY4NzRIV2RJVE1Sa3RyYk1WaE0xWXNTUkhXOGZZOUkrRjhqS0Fk?=
 =?utf-8?B?ZnVhRVhmL1dabDEreVkvdDhJWm1NTXZzOWZOZTlvQnVwRVZrSU5MWXFNZzNo?=
 =?utf-8?B?QitEM0FibHYvV0xwYXlzbCsvQlNtcVFFRk4wbzBkOUdVdDBGODFFZitMQUFN?=
 =?utf-8?B?aElUYXJlMFpYVFJGYTBGN0xkKzJNcHJYVDBUbUZjblRjRThMOW5jZ0twSkxS?=
 =?utf-8?B?dzdLaWN4b1NQV1pxaFZTQm5QejJPcWpEd3MwOW9zM1hZUkpmV1RsajY0cGt0?=
 =?utf-8?B?aUo4UHpPdnIrSmk1RS9jdkxjRVpPdTZETWFOT2EraVo4cFZvRVJuSThYV0hy?=
 =?utf-8?B?ZlpaRW5HMExicFNDazZMeWhDSk13d2tKejMwR3lOMkZhNitOSWZ3SGpVZjc4?=
 =?utf-8?B?MlFvbGdPbkU1RG9zNGF5OWM3ZnZ0M1cvV0FTbzIvVlRPankzY3FTVTd2UzlM?=
 =?utf-8?B?MTZyUk16cXpvWXFOTzhJSjlKdWxjLzRERGVsVWYwM2d4QWxhNEx0THhhcnFt?=
 =?utf-8?B?R1E9PQ==?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a69c0f3d-8cea-432e-164c-08dc007882eb
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 09:54:37.4853
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iw95YsXNYu5HXsYHDMaiJNaOVUFkgvfvsS0MadSn9g9qKbL68f6OqoR4TBuaZoZpozLbCVh6RVato+PPNh3A5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAPR10MB5202

On 19.12.23 10:50, Krzysztof Kozlowski wrote:
> On 19/12/2023 10:03, Jan Kiszka wrote:
>> On 19.12.23 09:48, Krzysztof Kozlowski wrote:
>>> On 19/12/2023 09:22, Jan Kiszka wrote:
>>>>>
>>>>>> +			gpios = <&wkup_gpio0 53 GPIO_ACTIVE_HIGH>;
>>>>>
>>>>> Ditto
>>>>>
>>>>
>>>> This is adjusting the existing LED nodes in k3-am65-iot2050-common.dtsi,
>>>> not introducing new ones. We can add the color properties in a separate
>>>
>>>
>>> Then why aren't you overriding by phandle/label?
>>>
>>
>> We could do that as well if we added labels first (they don't exist so 
>> far). Not seeing any difference, though.
> 
> Confusion? Your code suggests new node, thus you got review like you got.
> 
>>
>>>> patch, but the node names are now part of the kernel ABI. Changing them
>>>> would break existing userland.
>>>
>>> You mean label. Why node names became the ABI? Which interface exposes them?
>>
>> root@iot2050-debian:~# ls -l /sys/class/leds/
>> total 0
>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 mmc0:: -> ../../devices/platform/bus@100000/4fa0000.mmc/leds/mmc0::
>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 mmc1:: -> ../../devices/platform/bus@100000/4f80000.mmc/leds/mmc1::
>> lrwxrwxrwx 1 root root 0 Dec 14 21:12 status-led-green -> ../../devices/platform/leds/leds/status-led-green
>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 status-led-red -> ../../devices/platform/leds/leds/status-led-red
>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led1-green -> ../../devices/platform/leds/leds/user-led1-green
>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led1-red -> ../../devices/platform/leds/leds/user-led1-red
>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led2-green -> ../../devices/platform/leds/leds/user-led2-green
>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led2-red -> ../../devices/platform/leds/leds/user-led2-red
> 
> I replied too fast previous and did not include answer here:
> 
> You have label for that... Somehow all these nodes are half-baked,
> without all the expected properties and now you call node name as ABI.
> The node name is not the ABI.

Well, existing userspace uses those names, and adding the properties
would break that interface. Now, does Linux do that?

Jan

-- 
Siemens AG, Technology
Linux Expert Center