Received-SPF: pass (google.com: domain of linux-kernel+bounces-4986-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <d25399e3-9054-44a1-9ff9-e27252436222@siemens.com>
Date: Tue, 19 Dec 2023 10:56:37 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/4] dts: iot2050: Support IOT2050-SM variant
Content-Language: en-US
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
 Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Bao Cheng Su <baocheng.su@siemens.com>,
 Chao Zeng <chao.zeng@siemens.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 devicetree@vger.kernel.org, Li Hua Qian <huaqian.li@siemens.com>
References: <cover.1702917360.git.jan.kiszka@siemens.com>
 <11e0b0c8b828254567a8ff89820c067cacad2150.1702917360.git.jan.kiszka@siemens.com>
 <8b3daa3c-dbf8-4286-b04e-011cd9b0efa5@linaro.org>
 <4c31adc5-3fc5-47bc-9766-6d3d1eeddb65@siemens.com>
 <fbb29d81-9ea0-4468-ad47-f6668c2be277@linaro.org>
 <de3f4778-51d6-48ab-9d4d-451f2ba01a3c@siemens.com>
 <3d2662be-3a55-4390-bd2a-cfa5cc53510f@linaro.org>
 <ef5a6cf0-4350-483d-a1e9-ce8b0ef71280@siemens.com>
In-Reply-To: <ef5a6cf0-4350-483d-a1e9-ce8b0ef71280@siemens.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dHFsM1lwMU12ZkxDSGwrM0lHenIxbDBsUjRzTnNvUW8xYm9PK1dOM0tnU3Zq?=
 =?utf-8?B?T1IyRm1nSkh2R3pXUVVBUm1taWF0bm1hTXdXYXBUaVlySU55dytGeVZtQkpv?=
 =?utf-8?B?cXZUMWFlSm9rUUx2RDRYN1E1RDJzMjZvbmUyYVJRU1FZK0dwTjBpTVFIUFh4?=
 =?utf-8?B?d2NZRjBoeE9QaDlxcm11M2N0VVNkZ1FYblFrTzVTN3NwOTZUUHFSY0ZxNUo5?=
 =?utf-8?B?VFIveFhSN2dnSktMdVUyRW1XSXJrT0ZpbDNDVWsraFM4T1IxNGFOazhQNFpx?=
 =?utf-8?B?Q3ArUk5YK2x4c3RWSE5wTmlwc3lJV0dDSWxrVFNUcjN3SjJzbjJOampSTlhL?=
 =?utf-8?B?dTg5T3kwRG4zdTgwZmx6L1VaRm1BdFl3Y3RLYXhld2lPSWg4UUJnZkswYXBm?=
 =?utf-8?B?SzFBL1F5b2xJbkdxTVc0SFZVcU1OZlR1OEZqOU51WHRyZFEyZUJLY3JNWjhE?=
 =?utf-8?B?VnM2MTduMkdPN3FhWnFMRE5xY2ZpWGJTbDRIL0I4Y21Ma2VrV1NlNi9BdHFW?=
 =?utf-8?B?VkxQQlN3OG5DM0IxVWhxZHdGbEFLN2FjU1ZrS3VLYWJCSFNLUkFSaFR0MGlF?=
 =?utf-8?B?ZEIyeDFKUnlhUkxwbU9ndld1dHY2MC9raGdjVTFXV3NOTldraHFBWXV2YWFz?=
 =?utf-8?B?VE03WmlMbkpTYWdCVWRQS1cxRDYwM3BuQnNEYllLNUVDb2pEeFVXWEpaT3Ju?=
 =?utf-8?B?aC81TjZUdG9iQWNSeCtqZkxWMWhBWFkwQ1F6allxK0lEVFBCck83ekpjKzk1?=
 =?utf-8?B?RGtFbzErL1JxWkFqQkpmUkMxTkU1OWlLZFlMUWpBM0FlL3RNNUlWQkhZc2FK?=
 =?utf-8?B?ZmJHWmh1NUZ6WlpRQlA0YlJaNTNERmxQM3ZtbCtiMUxaY3h5QTEzenl0RzRT?=
 =?utf-8?B?UnJaVldQN2d1Kzg2c0syWlExRHFBekx3Zlc4eG4wNGFQTW82NjV5ZkV2d0F2?=
 =?utf-8?B?dVlpUWM4d3FyMzQxb2ZKNFIvb1lFNGxUTlowSmNMUi9nY3lZSzZiblU3aDMw?=
 =?utf-8?B?WFVqdCswd1U0VVlOdGFIUUU3UGlGNE1QMDk5c1Z2RUNzbnNpU0JicHlxZ3J4?=
 =?utf-8?B?YjJjYTRabGIrQUhqdHR0dm9vd0NZZUcxZlg4ZU9BdEYvcU9YRCthN2RJeFJs?=
 =?utf-8?B?OTE2aFNrK0FCZHFoYW1xdDYrMFhNcXVHNXJoRkJ0SzdQZEhIcWo1TldIRGow?=
 =?utf-8?B?UTFiT2NFdTZMeW10ajZLNG4rdkMyVkwrRng2NTRzM3Y3TmFkNTlIelJ5bFZm?=
 =?utf-8?B?NHEvNGM5akZoOTBPNllza2tBeldBbXNSNlEzKzJkMkxZN3laTzdKcTEvK3lk?=
 =?utf-8?B?ckpoaWx6bmRKd3kvNzVmMFhTT2dGV1ZvRytYV2JFWWhUUzRaU3kyUE9yUWlm?=
 =?utf-8?B?ZmFXQ0NCRlpOSmlQWGtad1d3bSsrNGRxa3ZqeGtFdzRQWUtaZ3AwVFlaUzdh?=
 =?utf-8?B?VngzbnBtVXRuOVVOS0lzNG8rWUhXZWUrT0dDV1RHZjhEdjNQQ3M3U29OT1JC?=
 =?utf-8?B?TWE3MzFPalNUdWJBa0tHWHBiME0rYjFwZVYvUm9qckxjampqRFBkVVgzaThI?=
 =?utf-8?B?WWxzVGlyc2VzOENiOG8zOXRRMHVCb3JJaWxyZ2ZSNmczUzMrQ1pmZXBxMGlS?=
 =?utf-8?B?SUVEWlpEWDZkdXcxUEU0TzhjTkVLNVJQVlluSkdXWmFiV3dVc0ZZL3NOTzFS?=
 =?utf-8?B?dWtXelZkb1dHd21ObzdFeXZySWtnMVRSSW1TQjdQeENyTjhoL1gxVmlwOExM?=
 =?utf-8?B?MzBpMlRjR0s1SkVMbngxV1BaSFNXdmU4bXBBcENoQ2gzTTl6SkpRN2kvWEdT?=
 =?utf-8?B?Mzl2Q0w2K0srY0RKWXd6Zlc3YzRXZUt2a1FFSC90TEtRREc4YW9WVHVacDRy?=
 =?utf-8?B?VXRwemU3c1lpQ0FhK3UvclZTbFFvUDNjTkwydk5lbElSREIvT2tQTncyTkpQ?=
 =?utf-8?B?TnFqcW5KOTFvY3lkcVpDc2xoLzV0VllUY1ZXTEtWN0wvWG9YRThTY09GVnVO?=
 =?utf-8?B?c3pLNWV4UDhVUEUrdW5JVUFxUm53bUdST0kyWDhPbmFBZCtUSUZBa3pvOWlk?=
 =?utf-8?B?SU1UY1pRUGpWQndiTW44YUloSW1nazc3WTgzbnAzbnFaSnVRaGlSWm9OK2pB?=
 =?utf-8?B?a1VjRnV3RkR0NWJybUwzYmc3aWxibnBSWHl3ak9NWWJkOXQ0U1RTdnVOd2VE?=
 =?utf-8?B?TVE9PQ==?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b24b5ca-d0a6-4616-eb22-08dc0078cbfd
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 09:56:39.9370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +8YDmvZVbB5/vcFexKnueD3k3Ngbs+u1SGisFV9IylZs+UpxzIXEDzCAqdyC1ySsO1F1ZvYqmlrXfeoydqRJoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR10MB8090

On 19.12.23 10:54, Jan Kiszka wrote:
> On 19.12.23 10:50, Krzysztof Kozlowski wrote:
>> On 19/12/2023 10:03, Jan Kiszka wrote:
>>> On 19.12.23 09:48, Krzysztof Kozlowski wrote:
>>>> On 19/12/2023 09:22, Jan Kiszka wrote:
>>>>>>
>>>>>>> +			gpios = <&wkup_gpio0 53 GPIO_ACTIVE_HIGH>;
>>>>>>
>>>>>> Ditto
>>>>>>
>>>>>
>>>>> This is adjusting the existing LED nodes in k3-am65-iot2050-common.dtsi,
>>>>> not introducing new ones. We can add the color properties in a separate
>>>>
>>>>
>>>> Then why aren't you overriding by phandle/label?
>>>>
>>>
>>> We could do that as well if we added labels first (they don't exist so 
>>> far). Not seeing any difference, though.
>>
>> Confusion? Your code suggests new node, thus you got review like you got.
>>
>>>
>>>>> patch, but the node names are now part of the kernel ABI. Changing them
>>>>> would break existing userland.
>>>>
>>>> You mean label. Why node names became the ABI? Which interface exposes them?
>>>
>>> root@iot2050-debian:~# ls -l /sys/class/leds/
>>> total 0
>>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 mmc0:: -> ../../devices/platform/bus@100000/4fa0000.mmc/leds/mmc0::
>>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 mmc1:: -> ../../devices/platform/bus@100000/4f80000.mmc/leds/mmc1::
>>> lrwxrwxrwx 1 root root 0 Dec 14 21:12 status-led-green -> ../../devices/platform/leds/leds/status-led-green
>>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 status-led-red -> ../../devices/platform/leds/leds/status-led-red
>>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led1-green -> ../../devices/platform/leds/leds/user-led1-green
>>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led1-red -> ../../devices/platform/leds/leds/user-led1-red
>>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led2-green -> ../../devices/platform/leds/leds/user-led2-green
>>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led2-red -> ../../devices/platform/leds/leds/user-led2-red
>>
>> I replied too fast previous and did not include answer here:
>>
>> You have label for that... Somehow all these nodes are half-baked,
>> without all the expected properties and now you call node name as ABI.
>> The node name is not the ABI.
> 
> Well, existing userspace uses those names, and adding the properties
> would break that interface. Now, does Linux do that?
> 

Obviously, we could deviate from the existing naming scheme only for the
new variant, keeping it for the other 5, but that will be "fun" to maintain.

Jan

-- 
Siemens AG, Technology
Linux Expert Center