Received-SPF: pass (google.com: domain of linux-kernel+bounces-4988-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <cd5a0140-295a-4f48-a378-3c2b8be0f499@quicinc.com>
Date: Tue, 19 Dec 2023 17:57:13 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 4/6] arm64: dts: qcom: qcs8550: introduce qcs8550 dtsi
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Tengfei Fan
	<quic_tengfan@quicinc.com>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>
CC: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20231219005007.11644-1-quic_tengfan@quicinc.com>
 <20231219005007.11644-5-quic_tengfan@quicinc.com>
 <ec730ce7-2021-4cad-97e6-0a86c6063533@linaro.org>
From: "Aiqun Yu (Maria)" <quic_aiquny@quicinc.com>
In-Reply-To: <ec730ce7-2021-4cad-97e6-0a86c6063533@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 12/19/2023 3:02 PM, Krzysztof Kozlowski wrote:
> On 19/12/2023 01:50, Tengfei Fan wrote:
>> QCS8550 is derived from SM8550, it is mainly used in IoT scenarios.
> 
> What are the differences? You need to describe the hardware, you have
> entire commit msg for something useful which will avoid such comments
> from reviewers.
> 
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs8550.dtsi | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/qcom/qcs8550.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8550.dtsi b/arch/arm64/boot/dts/qcom/qcs8550.dtsi
>> new file mode 100644
>> index 000000000000..254657f46c5e
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/qcs8550.dtsi
>> @@ -0,0 +1,6 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>> + */
>> +
>> +#include "sm8550.dtsi"
> 
> This is a weird file. I thought qcs8550 has differences from sm8550,
> e.g. lack of modem, so why do you claim you have here MPSS?
MPSS here in qcs8550 is a GPS only MPSS.

QCS8550 will have a different firmware release with sm8550, and it will 
have different memory reserved for the firmware to be used.
While firmware release along with memory map was not settled down yet.
That's why currently qcs8550.dtsi is an "empty file" and only include 
sm8550.dtsi. As long as the firmware release is settled down, we will 
have more detailed different node here.

By the way, RB5 gen2 will also relies on the current qcs8550.dtsi, since 
it is using the same qcs8550 soc, and will use the same firmware release.

We have patch version2 remove the qcs8550.dtsi, and have SOM dtsi 
qcs8550-aim300.dtsi include the sm8550.dtsi. While after discussion, our 
understanding is that we can have an qcs8550.dtsi like this. Feel free 
to let us know if it is not right understanding.

> 
> It's really confusing now.

We can have a syncup to clear the confusing point if needed. :)
> 
> Best regards,
> Krzysztof
> 

-- 
Thx and BRs,
Aiqun(Maria) Yu