Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp391234rdh; Tue, 19 Dec 2023 01:58:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfcldNuGWerd3vBYJYP3iqdwUM38gspa0loGc0pGD8yOujB1/N87PwEaiEzyPkl4+9MZ+g X-Received: by 2002:a17:903:2381:b0:1d0:711b:c2d2 with SMTP id v1-20020a170903238100b001d0711bc2d2mr11683332plh.13.1702979898395; Tue, 19 Dec 2023 01:58:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702979898; cv=none; d=google.com; s=arc-20160816; b=HPbBTVzo/NTQiFPVrOkprRp29BnPPRg2VqKZaJPMoHtqgz3w0vVAK9TC+jw3v1XjLu Y0RpRRaiyVNyihhd0E1cl6uEs1jDqp0e/ta9UkionTDWBxybwEMxo5gwWYqSWq4MJK2h U3oGm42Ii6n8POoojk+ed3aNCgWWO7bpoJQ6lHQfkHganEf18yw5OCcbXVfbNoIYaeSP XiEoitA+KHIhPcU7x0osFYTz8yXRnDPJYiMToXMGvOvpyPLWS8CeOBjniMVd3i5g68tz ZVshWWjARCsQaiR752qXjpsHHJYzGz6lEfQZ0w5otdPoUxE8KeMp7Ym5M2w2A5WyzRcL DfNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=CwsWtsLOvWK+82mVjpkuXTM6g0jEIlPmXvx1Ed249No=; fh=QrRLTDTwptGzSiUv2Lg08f27GoTIyXkTl00WDBGquAE=; b=Q+cS8X8HnXuCQFkGcIWeKihATmtkp7goxHEA/owAwtHnH01+cu2tBHxy/lghy/xZey jV7G+rIRUEwoFfZHPaReBJXI/jlabuC659I27OxJ1nnVLdsWgr6/mhu/i+2y23q/71zW qVmb8hUwHW9ds+fs8tQi2ut6GdXQi5ojSOxI28bSgjEjxVxrei0ap29gcHVIyHy/GT1l mp22fn/sRMz1hl+a8eJe+qKW4ABtSbuhjnFu2QcQorlwwwS8z/fITrCPtxel4eqfQ8pM CrdmCnZv0MofiGSZ9tbyQZ07CzwwbSl86a8xz7Yt3hUcTQX2gj1aIf/ehBqnmiipVGwR Q3nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I1Goqhkc; spf=pass (google.com: domain of linux-kernel+bounces-4989-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4989-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id o2-20020a170902d4c200b001cc3527145bsi19849208plg.29.2023.12.19.01.58.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 01:58:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-4989-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I1Goqhkc; spf=pass (google.com: domain of linux-kernel+bounces-4989-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4989-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 115112864C9 for ; Tue, 19 Dec 2023 09:58:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2B0AC1426E; Tue, 19 Dec 2023 09:58:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="I1Goqhkc" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC2A21401E for ; Tue, 19 Dec 2023 09:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-552ff8d681aso5949373a12.1 for ; Tue, 19 Dec 2023 01:58:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702979886; x=1703584686; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CwsWtsLOvWK+82mVjpkuXTM6g0jEIlPmXvx1Ed249No=; b=I1Goqhkc8qdXXJBmFR+LXYh/paUf1J8Q8x03kL9c0hJr7Jo3BalkyFtYpP5xrVFF3I c9w532E6+Mp8KSlSw+n9ABeuJVajKgjzJ6dVRpIqy9Gh15A6YT74i5ajaYCq30fzFbMh YI49wH3DUeQ9mIC01Ii5oDvsJ8qNMPb8okfhMJFgrXU0HxlFK4G6tSYOHtl1n3WZn6X9 i6QQ5LIGtmo9U/PA4UhhFVB5yzj/p65HeGkhHbdvUkzTKJx2P9s2ZT2aMtUr6B6p2Ykg rVNy8Zkww1xBdIDhbX/lbju0gJeubgO2CmRg/ofsATFDLIVyQfpS/Ts+0bbb6ac7SeU9 MI8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702979886; x=1703584686; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CwsWtsLOvWK+82mVjpkuXTM6g0jEIlPmXvx1Ed249No=; b=X3Qizvfiqo0myysk3uxwYObvtDMqDP5+M7AyWBwojmzLPtxEleYViJDqrRVbU4FdW4 fQ2y3dpZElxpGRUAJC0YKnk3eSMNCS0Wi73mqo6XM2F5TakJcWQqOJSWzwau4i82Op9k cXz3hePPSXm4I0v2G4Q6k+mS3ULisYFCBAcrfLtKMobqz9/kPk0a6+CrByAK/Y0J8n5m bxtJTBSxjHxc/k6YEGEjo/b1wWURYM9VLV//7ZgZ1MD+7Jq26UN3Oz+c5bN+tKt7cTtn FZtD8ZqWzapLZHW4rVa1ZKlokaqiK3XD8nR2PuDxP6B8T53WvoTY8TRV7x3jAjsIDKQZ Uv+Q== X-Gm-Message-State: AOJu0Yw3+ioN3EdKPPR3ti0R/7sqYrS7otwMAPB3Q/9NrMvbrXvh/4aX I9qsxteaxj+/GtGaNNreWhsDt9KsRPZjnw== X-Received: by 2002:a17:906:4b04:b0:a1f:6ec8:2f6f with SMTP id y4-20020a1709064b0400b00a1f6ec82f6fmr701308eju.28.1702979886034; Tue, 19 Dec 2023 01:58:06 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id vq6-20020a170907a4c600b00a19b7362dcfsm15230770ejc.139.2023.12.19.01.58.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Dec 2023 01:58:05 -0800 (PST) Message-ID: Date: Tue, 19 Dec 2023 10:58:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] dts: iot2050: Support IOT2050-SM variant Content-Language: en-US To: Jan Kiszka , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bao Cheng Su , Chao Zeng Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Li Hua Qian References: <11e0b0c8b828254567a8ff89820c067cacad2150.1702917360.git.jan.kiszka@siemens.com> <8b3daa3c-dbf8-4286-b04e-011cd9b0efa5@linaro.org> <4c31adc5-3fc5-47bc-9766-6d3d1eeddb65@siemens.com> <3d2662be-3a55-4390-bd2a-cfa5cc53510f@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/12/2023 10:54, Jan Kiszka wrote: >>>> You mean label. Why node names became the ABI? Which interface exposes them? >>> >>> root@iot2050-debian:~# ls -l /sys/class/leds/ >>> total 0 >>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 mmc0:: -> ../../devices/platform/bus@100000/4fa0000.mmc/leds/mmc0:: >>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 mmc1:: -> ../../devices/platform/bus@100000/4f80000.mmc/leds/mmc1:: >>> lrwxrwxrwx 1 root root 0 Dec 14 21:12 status-led-green -> ../../devices/platform/leds/leds/status-led-green >>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 status-led-red -> ../../devices/platform/leds/leds/status-led-red >>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led1-green -> ../../devices/platform/leds/leds/user-led1-green >>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led1-red -> ../../devices/platform/leds/leds/user-led1-red >>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led2-green -> ../../devices/platform/leds/leds/user-led2-green >>> lrwxrwxrwx 1 root root 0 Dec 19 08:55 user-led2-red -> ../../devices/platform/leds/leds/user-led2-red >> >> I replied too fast previous and did not include answer here: >> >> You have label for that... Somehow all these nodes are half-baked, >> without all the expected properties and now you call node name as ABI. >> The node name is not the ABI. > > Well, existing userspace uses those names, and adding the properties > would break that interface. Now, does Linux do that? I don't think you understood the concept. There is no change for userspace. Same interface, same names. No ABI break. Anyway, changing them is not part of this patchset since these are not new nodes. Best regards, Krzysztof