Received-SPF: pass (google.com: domain of linux-kernel+bounces-5027-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 19 Dec 2023 11:46:39 +0100
From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Song Liu <song@kernel.org>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-block@vger.kernel.org, Paul E Luse <paul.e.luse@linux.intel.com>
Subject: Re: [PATCH 0/3] md: Remove deprecated flavors
Message-ID: <20231219114639.0000689d@linux.intel.com>
In-Reply-To: <CAPhsuW7w7WbWePpQd4aqnvXHwbdEJzw9efEP_r6tJwpeg0_qLw@mail.gmail.com>
References: <20231214222107.2016042-1-song@kernel.org>
	<20231215125059.00006270@linux.intel.com>
	<CAPhsuW6GZnufqFseLvgpMrrX6qRXodX1n89vEbbC-FqTjsWPDg@mail.gmail.com>
	<20231218093201.000020dd@linux.intel.com>
	<CAPhsuW7w7WbWePpQd4aqnvXHwbdEJzw9efEP_r6tJwpeg0_qLw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, 18 Dec 2023 08:11:53 -0800
Song Liu <song@kernel.org> wrote:

> Hi Mariusz,
>=20
> On Mon, Dec 18, 2023 at 12:32=E2=80=AFAM Mariusz Tkaczyk
> <mariusz.tkaczyk@linux.intel.com> wrote:
> > =20
> [...]
> > > >
> > > > Please note that there are mdadm tests for those levels. I can appr=
ove
> > > > it only when mdadm clean-up is merged. Our tests must pass
> > > > continuously. =20
> > >
> > > Is the continuous test result available publicly? =20
> >
> > We are working on public CI (Paul owns it). On my side I'm not executin=
g all
> > tests, IMSM only. In this case it is obvious that mdadm tests will stop
> > passing, I don't need results to see that. We should keep both mdadm an=
d md
> > compatible. We are continuously adding new MD regression tests to mdadm=
 (at
> > least Kuai is doing that) so we should also care about removing things.
> > =20
> > > =20
> > > >
> > > > It is a nice code complexity improvement so let me know if you would
> > > > like to get my help with mdadm patches. =20
> > >
> > > On my local tests with mdadm, I need to make changes to the following
> > > tests:
> > >
> > > 00linear...
> > > 00names...
> > > 00raid0...
> > > 00readonly...
> > > 02lineargrow...
> > > 03r0assem...
> > > 04r0update...
> > > 04update-metadata...
> > >
> > > The changes are all straightforward (just remove things related to
> > > linear/multipath/faulty).
> > > =20
> >
> > Please do not forgot remove dead code from mdadm. For example simple fi=
nd
> > "multipath" (case insensitive) reefers me to multiple places with speci=
al
> > handling for this level. We need to remove it from code and documentati=
on.
> > Can you handle this too? =20
>=20
> I think this is a bigger discussion: will mdadm stop supporting these
> flavors on
> older kernels? Say, mdadm-5.0+ (or a different number) will not support
> multipath flavor on older kernels?
>=20

Good point, I forgot that we are keeping backward compatibility with old
kernels. Currently 3.10 is the lowest one supported so agree, we need to ke=
ep
this code. Thanks for clarifying!

> >
> > Oh and last one, I can't find update for md man in your changes. Could =
you
> > please remove those levels from md man? =20
>=20
> man side is easier. Once we know which major will have this set (6.8 or
> later), we can update the man pages with the information.

Understood!

No further questions, please just remove tests and eventually add warning w=
hen
creating those levels in mdadm i.e "Linear/Multipath/Faulty are deprecated =
and
will be removed in next releases".

Thanks,
Mariusz