Received-SPF: pass (google.com: domain of linux-kernel+bounces-5056-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <4d4e488d-45d6-4496-b165-c349c67d4f11@intel.com>
Date: Tue, 19 Dec 2023 16:32:13 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/callthunks: Fix some potential string truncation in
 callthunks_debugfs_init()
Content-Language: en-US
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Thomas Gleixner
	<tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov
	<bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>
CC: <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
References: <8c2b24df3c077e55b2a4d91a7ffd08fa48e28d0a.1702803679.git.christophe.jaillet@wanadoo.fr>
From: Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <8c2b24df3c077e55b2a4d91a7ffd08fa48e28d0a.1702803679.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VytEMDhLRXEwZHJ2WDQ5Y1FodHVYWnJkQ0pJMG5SMWs0ZFBzNEVtTXllUVMy?=
 =?utf-8?B?b21ReTRGTnpVV25ZaXViUlp3Mi9CVXF4MG4yM3hBYUY4clNSamVieHNHa0xI?=
 =?utf-8?B?aTFtU2VRcjd2YVhKL0NFeHk5blFOczE0c2ZzNWVrbGpMR01DZW9VYS9hcnll?=
 =?utf-8?B?Qi92L2xiQktVNnBKR3o0MDZ6ZXN6V2haSk1GSzIzT2ZydlJWWUZVZ2tsWnVy?=
 =?utf-8?B?YWkyZHV4WFhhYWc3dEZFaDhUZmpUVGlMMXVVM0wvRFlsNDdCUDI4cEdsaS9i?=
 =?utf-8?B?S05qNlNwY1oybW5yUElwQmwzZUltaGg1RmNaYzl5a1d0ZWJnaFNMdFg2T284?=
 =?utf-8?B?VFZpVGxGUk1jZHFZNEx6K050KzRsQ0RONzZySEltSXpQdlBGVENtdVlvZUdH?=
 =?utf-8?B?VmZxdWs4Z05vNElvWVhzOUttSFEvWjNmUVQrZFZQdy9VbzFGSVdUNFhkSG1n?=
 =?utf-8?B?L0pMYnFkSm5nd2JTbElMUUJROHVrVGc4RzRFc0N5UnBLQ1BsenlSWWp2YkxJ?=
 =?utf-8?B?bWhJNEtEWXN5YlYyd3J3M0VLQ0MwSW0wZGpkMVljMUZqNGxSWFh3a3RTZmdU?=
 =?utf-8?B?U2hPYSsxVjhxMHFoZDlnUndQMWNKY08zWmVZVUdkVjdsQWRMSURIZlhqM1Fz?=
 =?utf-8?B?aEpwMUJJSGFGdFVlZTZxazdzTDlCcFJhZFlpNTE0WW9KKzF1cWR5QVphZWQv?=
 =?utf-8?B?ZW5WcyswamgzT1UxUGtLQUNBMGNDWEFkdXJiVjY2QVI0Y0JrL0oyZ0dobGls?=
 =?utf-8?B?dEsxZVREUFZ6ak9qdE1QVlcvTmdmRWx4Y1lNT1ZjZUwwMmxhbHBHL3BLdEVt?=
 =?utf-8?B?S0tPVUErM3FZWkpsL2RocVVaK1JId0lJZ0wrQzFWUmZBS1UwUlNvbnU5Qkp0?=
 =?utf-8?B?S21pekFER3NDM2t1RS9adE9WaVFnM05QZ2RBTEFOakpLLzVtUmlLWjZoZEh0?=
 =?utf-8?B?T2pzTHdHWU1DTGNudEl1TlJMSWJvNTBJZUNPVjgrMFo5b3RRREJxTkNSRFp4?=
 =?utf-8?B?RUpodzk3SCtNNXlkWnhacE5ocEtKSTRpUkdIb1lPeS9CV3RaSlNwQVZGbm1q?=
 =?utf-8?B?dEl1M0tEZlZaVGVHRmdwQThoWWpXZ2l1bEtXM2dYZVo0R2NFbUVTcmx5SFlQ?=
 =?utf-8?B?ei9PYks4QmFzUllkMkVWOUJKdmJ4UEErQkxKRnY4L3hPVW5IbkNVTVVrYnhY?=
 =?utf-8?B?VjdycDREUkFmbHBBYlV1M0VsYlpYSGhwSW03UEZDamtIaTBsNTRjUlZMc204?=
 =?utf-8?B?bkVlemFRaFZxNFBLelBOd1ZZRllZcHYvMTdhMGRmb1RleHVhNzNrdGdsMWJN?=
 =?utf-8?B?RE1GbmQzMkt4dnVlSkh5YStoNGlKRkNZbkhqenIybG1EcTdYRFoxQmo0aGFG?=
 =?utf-8?B?U3ExYW9pMUE0RGUyeHZpUjc1N28rOHBpM1N0REE5bE5ldmM3Mzk4czlXRDFy?=
 =?utf-8?B?a2duK3l4WjNiYUJaSWtyWlQ5UVBmbHRuRmJsVTJqeFd6OW9IQUt6TUNaYm9a?=
 =?utf-8?B?VkdSL2xlOXJSaHNqVzI4L2dha2h5UzE5dXByTTU1ZldIaHg5L0M4QUxpb2Jx?=
 =?utf-8?B?RFlOUDRlUGx4MUpXVjRiODZEeXVMNTFYQmVCKzNSdEdDMUsrRytMRDBqeG83?=
 =?utf-8?B?Q3ZQRmpOYWJXZWRXcXVhR3VocEFtL2JOVnZDYzFuRlJxbDdtY3R4M0loVDZw?=
 =?utf-8?B?K2p4eFlLZXVUaFlML0h0RzdhdXZaQURXS1hlRHlpdWdJcWhHZVRKNDY2TW96?=
 =?utf-8?B?RVh0KzVWa1UzUVZ6ZW9kY2I1M01Td1NXdEdUQ1JwblpiOGVQVklqamJNdjNs?=
 =?utf-8?B?Nk91N05RaFpObll2OEhLdnFyOWRSUzdCSURMaDl1SWl0SDQ0L1VFdXA2dERL?=
 =?utf-8?B?WVJ6MUNZZ0p2Z1ZabWxjZUgwcVV3TEVaV05ZQUlSU0JJMGZVV0lBdHU4S2x5?=
 =?utf-8?B?T2M4Y2hJOVBUWWFSbEpJUDF1dnJrN2IxQXBhR3MxOUVHWXZkM1lQZittemxM?=
 =?utf-8?B?cGlzWXN1YnVzOFpsaW91QmhTREcwRHNJM29ORTl4SHBiOU1jSWxTNS9sVWpQ?=
 =?utf-8?B?SUNjL2I0bTVjNDEvTTVvTVZ0ano3UjZqcCtqZzJ6dnVzSUMzc1J6djk1ZDl1?=
 =?utf-8?Q?FtQD+/mBS5zRT7ZSMh0UXVNBP?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 82ad3ead-eb1e-440f-9ba6-08dc0081f942
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 11:02:21.5983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Woj1cUXqoXghg6inkk3CV78j4l8ZB5y1ux2xMWnk2oaxtzefczB0jDTczfCR2vS/jOlKNwekB9zhvaInziuv2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7903
X-OriginatorOrg: intel.com

On 12/17/2023 2:31 PM, Christophe JAILLET wrote:
> When compiled with W=1, we get:
>   arch/x86/kernel/callthunks.c: In function ‘callthunks_debugfs_init’:
>   arch/x86/kernel/callthunks.c:394:35: error: ‘%lu’ directive writing between 1 and 10 bytes into a region of size 7 [-Werror=format-overflow=]
>     394 |                 sprintf(name, "cpu%lu", cpu);
>         |                                   ^~~
>   arch/x86/kernel/callthunks.c:394:31: note: directive argument in the range [0, 4294967294]
>     394 |                 sprintf(name, "cpu%lu", cpu);
>         |                               ^~~~~~~~
>   arch/x86/kernel/callthunks.c:394:17: note: ‘sprintf’ output between 5 and 14 bytes into a destination of size 10
>     394 |                 sprintf(name, "cpu%lu", cpu);
>         |
> 
> So, give some more space to 'name' to silence the warning.

It might be useful to specify that "some more space" hasn't been
arbitrarily decided. It took me a few minutes to figure that out.

With the max cpu number being 4294967294 with 10 characters, a total of
14 chars would be enough to print "cpu%lu".


> (and fix the issue should a lucky one have a config with so many
> CPU!)
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  arch/x86/kernel/callthunks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Apart from that, please feel free to add:

Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>

> diff --git a/arch/x86/kernel/callthunks.c b/arch/x86/kernel/callthunks.c
> index cf7e5be1b844..26182a7d12b3 100644
> --- a/arch/x86/kernel/callthunks.c
> +++ b/arch/x86/kernel/callthunks.c
> @@ -388,7 +388,7 @@ static int __init callthunks_debugfs_init(void)
>  	dir = debugfs_create_dir("callthunks", NULL);
>  	for_each_possible_cpu(cpu) {
>  		void *arg = (void *)cpu;
> -		char name [10];
> +		char name[14];
>  
>  		sprintf(name, "cpu%lu", cpu);
>  		debugfs_create_file(name, 0644, dir, arg, &dfs_ops);