Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp424615rdh; Tue, 19 Dec 2023 03:14:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IEjzTaa87GbyfF1QI1mvqfJUHwOLyR39MWqlThHThqz8OGM1RJUCGCvrTVS3mt46mqpAdbi X-Received: by 2002:a05:6870:f217:b0:203:60bf:8274 with SMTP id t23-20020a056870f21700b0020360bf8274mr8632005oao.6.1702984467978; Tue, 19 Dec 2023 03:14:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702984467; cv=none; d=google.com; s=arc-20160816; b=1D9uLQbzcT+oqVhdy7v8P8cp28wzgLXDrMDW0dI2cAILk3BAQ/fX+MQF1mYpLpleb3 q8iglTpd76TsPDm8nn5HmHFLTnH5aMSzzg/KFe8ZRxE1AmRNKlA8TiS7OvW92NAWej9d QkoSoFkTpEtSs+wczcg21j0XaG0mj8kwhgvZ79BD31hv0X6gmeDhEEaSBg456zMiBNal 9kvUrAMW/9LE5alCaovmgstqHwZo+1kMZRaFj3MlPunM+GdL2BrAYsta95gmgc0tTEOm g1Bix9074lvt24HGAKOhXnz9HPhSbG/QcLEfTRO/vB+FbGhQ2f5MQVB63tjPLrIy98rL j9hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5YurYC8UBGoNqWm08xdRph8nfwPh1HQzlxO9Wt4kEB4=; fh=kcgU0zlDUgnimr+i6v94uJFjD+ehLkZVEFcAQhWFiNM=; b=jZkV8hs8Y1uoqPuKg14igswumE1dMRp8KEBkZ7xV+A9zyHkFFy6niRjQezMsRjmY4j AdluTKhpcpEVdt0Arns3FcerxjGkImwzCaXsZfHYgTpvS/Hxemmohx/kx+znoGWbjig8 AmgR3pORjprJtLPvLct/B648OqDZ/Zm+0gqArL+biEvDlvyc58Dul3bj9uGFD4WPTFZt Ez1dHEIGg33UA+tr3BinPBqUfYfqaAyVpNbi42A6iO9MxEJzLY0NwISp5r4Niy+dNkZv KbAUIBiHDza0K+aWCSiwzyOOMB/Lp4Vvs9LXGTvL/oedbYcpWowSxzSZpjewrEhZGcv2 FjaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uCLn8Aan; spf=pass (google.com: domain of linux-kernel+bounces-5059-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5059-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b12-20020a631b4c000000b005c6ac5b5fc8si19855552pgm.401.2023.12.19.03.14.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 03:14:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-5059-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uCLn8Aan; spf=pass (google.com: domain of linux-kernel+bounces-5059-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5059-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A0405284C8D for ; Tue, 19 Dec 2023 11:14:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A6315154AB; Tue, 19 Dec 2023 11:14:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uCLn8Aan" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7F3514F79; Tue, 19 Dec 2023 11:14:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC2A6C433C7; Tue, 19 Dec 2023 11:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702984458; bh=4dslH+bYawkfXaHXPZBzbHeEjQIgy5C0S5DQUgJOamE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uCLn8AanN0AhspbNLHhFt+V5YjWqp0f9Ywobt3FpVQ+4wacdEKkm701QAi0Z4HYeC 8CfzMqj+K2cwGcAz6kah1fJhH5ZxOJIrAGZWL6QxFy2HnDkdJPBAOree9A1V79oH3y ky4RivFiTMf6dsb7ACb57UOv27ypC8X987bOE856eR1w2+CjuN85AJGLXmC9P0/NhR qs2h5hnzOJV48miDVIx3TfYgsPrX+3K5wZJMQHgM3P4X0BjRVInWcoOOr6gXW5Y9UD pixpKfH2Oqis+7O/Hg8Cfgh5iLlsgjYLPNOk5bSp9xjIV/9QNjjGxZEUq32HMjUpd7 a1Yc0bNEI+ipQ== Date: Tue, 19 Dec 2023 11:14:13 +0000 From: Simon Horman To: Jijie Shao Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shenjian15@huawei.com, wangjie125@huawei.com, liuyonglong@huawei.com, lanhao@huawei.com, wangpeiyang1@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 net-next 2/4] net: hns3: move constants from hclge_debugfs.h to hclge_debugfs.c Message-ID: <20231219111413.GI811967@kernel.org> References: <20231219013513.2589845-1-shaojijie@huawei.com> <20231219013513.2589845-3-shaojijie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231219013513.2589845-3-shaojijie@huawei.com> On Tue, Dec 19, 2023 at 09:35:11AM +0800, Jijie Shao wrote: > some constants are defined in hclge_debugfs.h, > but only used in hclge_debugfs.c. > so move them from hclge_debugfs.h to hclge_debugfs.c. > > Signed-off-by: Jijie Shao Thanks, I agree that these symbols belong in hclge_debugfs.c. Reviewed-by: Simon Horman