Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp435243rdh; Tue, 19 Dec 2023 03:37:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IEMTURh/OtOpWcdQ0d8UOxgvZ/oe0xRKhf4pH2kOAIi387ObdqWSi70IDNpBMfsKW/NdA4K X-Received: by 2002:a05:6602:2550:b0:7b7:f6ef:d144 with SMTP id cg16-20020a056602255000b007b7f6efd144mr366114iob.24.1702985832115; Tue, 19 Dec 2023 03:37:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702985832; cv=none; d=google.com; s=arc-20160816; b=uxAM8FB3MUGama8WrRUBcU3x55UOj3c1VsmETMeVMFJosIK4xNwJXVBSZxbIpgXDHs czHYMadjUB3OALs8Byw5HYHUeIzB5vRnDrPmMYkNHT5ynXdtAdqV1LkC2xt9qHGM1VNX dz1UZTBVMKFcDWNRq+Yq/BMTeiOsuIEbaFYWu7jzl5Tncqf+dvhcxE2+1KkT+OaGrxUw BP/mIs4v4X9o/Ilg/ftUE25NlSkgsk01FNUchnr/CCegaboqAIsRq18YVEN3HWEZ8XyS hJcVTdOVO6G+1vxiUyV847doaa6LtFfEt09KcvXkKLOC1Te4GvBaKmxTCb2ViZYolmGR lLgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature :dkim-signature:dkim-signature:dkim-signature; bh=9oZ3r6A05JfS/WWL0ax7LcwQtf1Dc7z0Xn007zoYGlc=; fh=Ob8FspbdAv2lvfy9oyzcNqJb9FlG/MYewgbmONDw7dw=; b=V9rTJ+IFMT1ShpboMKqAD4P4naRf36uOrzZSt4Tx67ufR18Yv9OlL3XatogCJ/SAUh I+M3E1CjQDKjbkVE7kqyxeqFbC10EAixx+miqOtv1+XdIw8L3XhNrEu/56tzyk8hkPza 8XvIEGXpgu9tltsxS49nyL31bXbwMRdXCqyGsjT2QH+kqYnDNyvlG7kLG0Cs6Ia5jSXp cfJ0pnXeA4ISeRMRwi4dN7m/lM0Jhbe2BwT+B0T8We2hu+r2zOOW6mxy4HEAZJnUoHUa fb1Fkq+3m9SULi1CQOtLoYkHVyg8sC/sICyJmsDGyVM2TS00qkjd+0rg5RUDg4czn5lO dUhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=b0LQ0y+H; dkim=neutral (no key) header.i=@suse.de; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=b0LQ0y+H; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel+bounces-5089-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5089-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id y29-20020a63b51d000000b005cd82a478f6si5313432pge.759.2023.12.19.03.37.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 03:37:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-5089-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=b0LQ0y+H; dkim=neutral (no key) header.i=@suse.de; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=b0LQ0y+H; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel+bounces-5089-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5089-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B5269283591 for ; Tue, 19 Dec 2023 11:37:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5BC831640B; Tue, 19 Dec 2023 11:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="b0LQ0y+H"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="j4m8eY/a"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="b0LQ0y+H"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="j4m8eY/a" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 037A816407 for ; Tue, 19 Dec 2023 11:37:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0595A1FD54; Tue, 19 Dec 2023 11:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702985822; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9oZ3r6A05JfS/WWL0ax7LcwQtf1Dc7z0Xn007zoYGlc=; b=b0LQ0y+Hw3+2Yc+SYifGeLRbKsi1eH1n14Cm6BGqD0NzWd8Ynr8uY4qVEJOSTebd2bok3w P+JI7ah37TJO1x4nbd+huYn6F2YWE8MdfLnRdBhIQv01lVHxtTwMopBqYAzwvfwsGy7aXp 2ndmb9LkWyL6JzMj/14e+y5RvS6rIyA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702985822; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9oZ3r6A05JfS/WWL0ax7LcwQtf1Dc7z0Xn007zoYGlc=; b=j4m8eY/aPtyYvX0kNcn+baczXDPlS7pZV3ct2yvMTYZCXwHJQTcYLjwDXDukFocH02tazR n27J9yQ3t4iZ7QCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702985822; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9oZ3r6A05JfS/WWL0ax7LcwQtf1Dc7z0Xn007zoYGlc=; b=b0LQ0y+Hw3+2Yc+SYifGeLRbKsi1eH1n14Cm6BGqD0NzWd8Ynr8uY4qVEJOSTebd2bok3w P+JI7ah37TJO1x4nbd+huYn6F2YWE8MdfLnRdBhIQv01lVHxtTwMopBqYAzwvfwsGy7aXp 2ndmb9LkWyL6JzMj/14e+y5RvS6rIyA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702985822; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9oZ3r6A05JfS/WWL0ax7LcwQtf1Dc7z0Xn007zoYGlc=; b=j4m8eY/aPtyYvX0kNcn+baczXDPlS7pZV3ct2yvMTYZCXwHJQTcYLjwDXDukFocH02tazR n27J9yQ3t4iZ7QCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 95E641375D; Tue, 19 Dec 2023 11:37:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id 5YXcIV2AgWVENQAAD6G6ig (envelope-from ); Tue, 19 Dec 2023 11:37:01 +0000 Message-ID: <40a449b9-f5b0-4fda-ae60-49f6010541fe@suse.de> Date: Tue, 19 Dec 2023 12:37:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/16] nvmet-fc: remove null hostport pointer check Content-Language: en-US To: Daniel Wagner , linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Sagi Grimberg , Keith Busch , James Smart References: <20231218153105.12717-1-dwagner@suse.de> <20231218153105.12717-12-dwagner@suse.de> From: Hannes Reinecke In-Reply-To: <20231218153105.12717-12-dwagner@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Level: X-Spam-Flag: NO X-Spamd-Result: default: False [-2.99 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-2.69)[98.62%]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[7]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from] Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=b0LQ0y+H; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="j4m8eY/a" X-Spam-Score: -2.99 X-Rspamd-Queue-Id: 0595A1FD54 On 12/18/23 16:30, Daniel Wagner wrote: > An association has always a valid hostport pointer. Remove useless > null pointer check. > > Signed-off-by: Daniel Wagner > --- > drivers/nvme/target/fc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald, Werner Knoblich