Received-SPF: pass (google.com: domain of linux-kernel+bounces-5101-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 19 Dec 2023 13:47:01 +0200
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Larysa Zaremba <larysa.zaremba@intel.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
	linux-kernel@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	=?utf-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>,
	Magnus Karlsson <magnus.karlsson@intel.com>,
	Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
	Jonathan Lemon <jonathan.lemon@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>
Subject: Re: [PATCH net-next] xsk: make struct xsk_cb_desc available outside
 CONFIG_XDP_SOCKETS
Message-ID: <20231219114701.5r5qoqkekfbvqtcy@skbuf>
References: <20231219110205.1289506-1-vladimir.oltean@nxp.com>
 <ZYF9+lhYT1i7dvDT@lzaremba-mobl.ger.corp.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZYF9+lhYT1i7dvDT@lzaremba-mobl.ger.corp.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+dlFd4/bQsKfjyznTbyhvmtXohsv6lPwwGPfee/IVlD89VMvktFXxPJDTuQE?=
 =?us-ascii?Q?sMZZStEi/j9xKuxeH1adI1dpuj7eJ7FUoVzNT894uIIIzUDkDrfooV2pDfnY?=
 =?us-ascii?Q?dASHD8wNX9ufr9p5iZX9Tx/lPwpidPSdl+mfw4NR4Wb2n6gkL/0WrfAMPyMn?=
 =?us-ascii?Q?XDVBRV8/VSCskobr/7XH4hpuPJ3Ew0BgN6hDmhxCwFULihEOdKnl+is4G9oA?=
 =?us-ascii?Q?j48vR+Zs7gkzRLedtGrdxvcZL1/EEO0hkd7d8SFZ1/F+xxIeaMRM2KTZ1jws?=
 =?us-ascii?Q?oHO0+jvZ6ymbHO6RdAWGJMlKYaL7k5G/wZTSqddkU7j4TXJIKWoZ8GkTJUuc?=
 =?us-ascii?Q?PLPyVXNb+VRuuGoxARbLsQiZpNVLVBqb7pbiLZFPULZLTkAB6T1E5hIOADue?=
 =?us-ascii?Q?fGFdrqqdqXlYV5wd8M0P6s5KjphczATXApk1ZmZFYxZ6Bowehyq9b7vbCkj5?=
 =?us-ascii?Q?HFEoVb2k0xBiH9DDhgRBpxRAs7Fuw2YTgPet2jqCMmYe+qBccmMRCmOdKmYl?=
 =?us-ascii?Q?ceJAt6rDiwzPLBiTSzX21gfmiHyfqohgREH32rfZTbOTxkfXJU8f8Gkosto+?=
 =?us-ascii?Q?whH/XyhjA8pNL8EFCKLYO60PHXdarw2AL1TehYSjpEySR33K5c65KnweBlxw?=
 =?us-ascii?Q?cAcZy0gWmNHKppnbcPboo4c0CiDntb2aCzvscUfwSBMJ7/rklufANNUWklaI?=
 =?us-ascii?Q?kiY0ZeCAksTPaQy7RwI7mcqRKiRk8Y5klYq3rxx2Hvjhu+D0hBGk8qQ8KniY?=
 =?us-ascii?Q?9q9TUDV+9J/g4J7bkL+gp/SmjzzsBgJADRCCHYHBlRSoYE7On/4ZXKAczyuU?=
 =?us-ascii?Q?whNB7Uq2H3e6Gx8ClDLBR5CGwZkWmWb1wx0FN8zxAyWmHyDKbg+vhT3uWiOh?=
 =?us-ascii?Q?DBUQgNmFJNYoe1Hj9EYYw0x99SNFBxOT69vhNG5jlpEcfviylEWyQ5sLQjTu?=
 =?us-ascii?Q?pCiz6h8OEvxelZnLFj1rp3spNVW4FOVpmKzOuHIkjHGI5Hnx949A6Q5pxc+O?=
 =?us-ascii?Q?kjFOrPP3MlNjhAIlVRo8Dtyaxi6qbLApSyGNXBj4WehfKEZcr26zrNOjM72q?=
 =?us-ascii?Q?WNkTDJYbtcJ1rM+qyf3iTtZY8pBCn7UfZa8+BRfIGoxsqz09cw9+jN1snGk6?=
 =?us-ascii?Q?ChlmBNd0LYEjEfHOoEQ3WvP5zn0Cn8VwNihODaojAE5T+xmonqZxTXbHE+ZR?=
 =?us-ascii?Q?q26cLxni0NWdOCpJbqW8yyJT+ArXh35DV/6+YE4vz440H2HEK+xd01943eYy?=
 =?us-ascii?Q?jz8/fzaK5B5kDJDUA2rcBo5R0WjCdEjVFezLi1YLDI5lxnxTuMeZMWsF8bvs?=
 =?us-ascii?Q?vcXQjOEikX9G2teGY7U+secAm5yNm6Uk4mHaYoPPgmv1hll0iQe3mmXQtKFs?=
 =?us-ascii?Q?KbJoxE0j3UzUyVwpItDGaWXvMHrHduW2Pc8GVjtUzC2j0DbWE3RVEj4aR+kC?=
 =?us-ascii?Q?jr4GHagwFjZ636WsR1lOsaGeRNeRBohYZv0xerizuVqHhO5+pUTxVi7Zd5DJ?=
 =?us-ascii?Q?eqCVIvc+tTfALlJ11UdAP34MFZrRqQIRgGTx3zT3t+jpJVc/tslj4q49xm3O?=
 =?us-ascii?Q?e4o+vFBRkNJgTQ0zyG/Gd20vOhV+qwtChyz9f4TImCopk7IJ0PYCYQGYT5AK?=
 =?us-ascii?Q?Jw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 948ffa16-0e28-41da-73e0-08dc0088395f
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 11:47:05.9421
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n9XmYR4dVJzD6qMM1yAxmGPDoTdIT+kCjvJ/8Vaj1PDaobROhwXAvxyCVqjI9K9ChZvE2O4Xh+sthwpJGy7CUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7425

On Tue, Dec 19, 2023 at 12:26:50PM +0100, Larysa Zaremba wrote:
> On Tue, Dec 19, 2023 at 01:02:05PM +0200, Vladimir Oltean wrote:
> > The ice driver fails to build when CONFIG_XDP_SOCKETS is disabled.
> > 
> > drivers/net/ethernet/intel/ice/ice_base.c:533:21: error:
> > variable has incomplete type 'struct xsk_cb_desc'
> >         struct xsk_cb_desc desc = {};
> >                            ^
> > include/net/xsk_buff_pool.h:15:8: note:
> > forward declaration of 'struct xsk_cb_desc'
> > struct xsk_cb_desc;
> >        ^
> > 
> > Fixes: d68d707dcbbf ("ice: Support XDP hints in AF_XDP ZC mode")
> > Closes: https://lore.kernel.org/netdev/8b76dad3-8847-475b-aa17-613c9c978f7a@infradead.org/
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> This probably should go through bpf-next. Other than that, fix looks fine:
> 
> Acked-by: Larysa Zaremba <larysa.zaremba@intel.com>
> 
> > ---
> > Posting to net-next since this tree is broken at this stage, not only
> > bpf-next.

It was a conscious decision. Build fixes are more time critical than
most other patches, and net-next is more likely to suffer from a failure
with CONFIG_XDP_SOCKETS disabled than bpf-next is. But, sure, it's up to
maintainers to figure out how to deal with it.