Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp440046rdh; Tue, 19 Dec 2023 03:49:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGMjjU0QXNADpMm7tq7k57gJ7pjM0Stw0lfNLFXeJNLEH12jxQ332kUXeAh9T2QE9Jm0ajV X-Received: by 2002:a05:6a21:6da2:b0:191:b753:752 with SMTP id wl34-20020a056a216da200b00191b7530752mr1233830pzb.36.1702986549690; Tue, 19 Dec 2023 03:49:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702986549; cv=none; d=google.com; s=arc-20160816; b=bgY936LZZ/aAnPT3nMFJXp+fm21WwiygNoAZapSofBG5aau5Smbv5GRVdbnvbA6A6d dc1ZXJ4ezNjzGI/IF2kPz2boFx2o+V4mB2zUl1ve0nYmt0bdY1z0zAT9uYqMto1ib2sv 6xvmjWsKmytF46z9nQ36Tx3MJ6eRxi8XRnquvpYLlfuVSH3Rc/gUN01m8rAzUe1tchk/ REwY7n38ZtLyBguN8vNr5DCo/pfJoUYIXKrx4t7N2ddoRNTL+Od+w+cTQstDpU1x4jH/ Z5gzARH40k+QH+leFoso5YJxfdzNcjJRlNB4IaTVdSlqp1rkt27G3NzFwuQL9g/CtCTn aTmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=ihBuGoZ+1c73Nfos1FB6nej7cYQmBATwWMmsTrg8PFA=; fh=j0Bp9qNVZ1tLnX6XNTrL7nk/iqxHIKHj0NzsylfFiV0=; b=co/gHvYWETYq+ke0S9gDKXljm90ICEMvKjANEIVLMhUzpKoxdlBfQIOkFIDg/zmML4 UFqG/utKOSNUIyz5v1Bis4StABakuJv6GUnud9mj0hvywUKodYYc7ggYKVg+OLV3wWdR ie5UJ80lfeMXD1a7RV/wS5MGIKHz+dGNoXx+Rm1m27C/5JcUnWbv/c9efWv18N1RW8oI cBym4GbY8ZVaUXoPi0XPdxPnPkJchsCCvKUz3i0SiNp0X8XUjy73zhl8/lgpNKVMCUpK jMlc1oIkyof0SQ76tDZIVjwga+HJzsZ7hjwbAi9rTmTzys995gfJzz9+yXNZElzllRkO leqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VITvBIzY; spf=pass (google.com: domain of linux-kernel+bounces-5105-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5105-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id i11-20020a6551cb000000b005b9022ddeaasi18805786pgq.516.2023.12.19.03.49.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 03:49:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-5105-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VITvBIzY; spf=pass (google.com: domain of linux-kernel+bounces-5105-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5105-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C5A7DB22BA4 for ; Tue, 19 Dec 2023 11:49:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BDE6815E98; Tue, 19 Dec 2023 11:48:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VITvBIzY" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80C56171BF for ; Tue, 19 Dec 2023 11:48:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5532b45c286so3429741a12.0 for ; Tue, 19 Dec 2023 03:48:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702986527; x=1703591327; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=ihBuGoZ+1c73Nfos1FB6nej7cYQmBATwWMmsTrg8PFA=; b=VITvBIzYLEXLngF9VfQ3woafFKRO/6pBf2VDg9/0d6oi94iY9yOBnov7EGsmqfyM5K +Fi6b2G+t6uo1aLBEOE1T0PTKO6j5QsyReAG7boQMgFemt0H6w4UxkbAgqGYc0ODfg1V 1NN5Vez+dF4IqoBgw0X98q22EKo7XZFhkqYpnkBAMhq+IrYysG4tpyHszOLRHuObNC21 bvP74YYxTBp31WN2X3Bk+sw3ofpTvrjd8eTxSvKCDgztu+MlcEANiO11G/LlkRIBOs3j vyghWr8pS3pxCFBivvEwrK+hK0I6D8eupTW8eJRWxdq5Q7kCWcbMeWakrJH3uFTm79Hn k4lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702986527; x=1703591327; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ihBuGoZ+1c73Nfos1FB6nej7cYQmBATwWMmsTrg8PFA=; b=CeThh/4WytGMrw5++BGJ9RMH/dc7M5gyl1KDkcRltJY8p1FqjnTfr8F4YL1cicgk0V hiK7+2SY1vDgIUUTRPSsvVKZMxphTQe+uMQwH1iKWWLmtiUM8nnX5qR3TEnI44oySR78 jqOt+zPUrwcktfD/W0GNrlhbL78xxqu/2kd1PxU1GT9pGCFiTfTtgEnYlLG3UJadrau1 FBkmjsORy7t/73yURNUFVda+JqeU0gZYf7YbOhapOmxNWWIvpVpj28+Aw80EhllpbT++ 0xwuDuaSmRzNThbYXo8Y+xVyLzdiWqOud6i+/MjHIDXcyyQ78q40BW8xK/ANiqSuPqd6 4Iow== X-Gm-Message-State: AOJu0Yyr/MhIw9Deg14y5cvEM/kEWzdHwb003ihTPAlxO+U3rkV/yme9 ex7maPD0/NtYb4EuHLgM8hv3kg== X-Received: by 2002:a50:c109:0:b0:553:9a7f:aefa with SMTP id l9-20020a50c109000000b005539a7faefamr198446edf.129.1702986526784; Tue, 19 Dec 2023 03:48:46 -0800 (PST) Received: from [192.168.199.59] (178235179206.dynamic-4-waw-k-1-3-0.vectranet.pl. [178.235.179.206]) by smtp.gmail.com with ESMTPSA id q24-20020a056402041800b00553165eb4f7sm2966501edv.17.2023.12.19.03.48.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Dec 2023 03:48:46 -0800 (PST) Message-ID: <1e151dcf-d4fc-4aec-9f68-c8ef372a00f2@linaro.org> Date: Tue, 19 Dec 2023 12:48:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] thermal: core: Print out thermal zone name on update_temperature error To: "Rafael J. Wysocki" Cc: Daniel Lezcano , Zhang Rui , Lukasz Luba , Marijn Suijten , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20231218-topic-thermaldbg-v1-1-451bcb723e1d@linaro.org> Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 18.12.2023 20:40, Rafael J. Wysocki wrote: > On Mon, Dec 18, 2023 at 3:40 PM Konrad Dybcio wrote: >> >> Currently, we can encounter an error like this: >> >> thermal thermal_zone48: failed to read out thermal zone (-19) >> >> It's good to know that there's been an issue, but on some occasions >> (like the error happening in the middle of a platform crash), one may >> not be able to look up what kind of thermal zone that is. >> >> Add the TZ name to the error message in order to speed up debugging. > > s/name/type/ ? It looks like that's what you mean. > > First, the tz type is not its name (because there may be multiple > zones of the same type) and it would be consistent with the first > paragraph above. That's possible, I'm no expert wrt thermal :) Would you be okay with this change, together with an amended commit message? Konrad