Received: by 2002:a05:7412:8598:b0:f9:33c2:5753 with SMTP id n24csp449815rdh; Tue, 19 Dec 2023 04:07:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IEkddmv+C/x1rfSparzYvXZcuN6PS0RfiQR12IqZqBYdXUDd5zRVpK2oSr2EXjjCXXjQBlC X-Received: by 2002:a17:902:e5c5:b0:1d1:cbbf:8ed4 with SMTP id u5-20020a170902e5c500b001d1cbbf8ed4mr10500908plf.76.1702987627726; Tue, 19 Dec 2023 04:07:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702987627; cv=none; d=google.com; s=arc-20160816; b=D/y7YAMS9ufN6VnKk+49P02QtdzcBN9cR4m4ZhPf4hMI1f+tCgyrAuxVMliUTl0OX1 1umk7tbOocUY+ihs3aYP9ko/xW0C6QzXxsDRQ709LgVEZ0Rc1StUA58BO876KXx5aqx5 a5hjxKZ1+Qe28WwSJ2Y7BYnmJi/h+8eDabwGs1AdGWcl3qlR2QH1j+kxBMMJtTiwFfQn ezxaIsgLfXO4BouMHGgkpdjF0ck/iGCdYDJKeh5zX0ZEozs4MT3MVpiyBJ1et0LdQamC MrGG3izPVQXJDu5jTX/JXHoWpJFp0niMazga/VY///YgkHvj+Ij6vO07fSjAEgjfELdK dXcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=QX0/am4IjBACVtJR4SW9C9khWxbgbpT1N87hAG7O6Og=; fh=V1tS30MR71O8875Vt1aZ1qSdLiMiRBfV7PEKyWISISk=; b=bKch5ErXBPLovyrzycUqPCSH5hnLdDVLjulFy4iag5lYc9qP+0wFdWIXCL34PRh1mI RtY7aza02jLftuAhE71G3W7Fa8UG9OK2ncjWQ+BSYrFHDLdZ7A1r61dtlAPpu6eur/J7 LLDCq8SH54QQoIU0k4+0CK91399RlcIWUY84KoHuFqFeoW74FLM9zHXGEi/dQecO3JTT z5RT00idoVdTruAZc8O0IeQeYxcW9lx/SWpnOVjSXulgGRGY/49Xx1BhNO+3IxdW4G8N HD4fjopUY2lD+oMd9BpKA9e9LFquOr7xmtEi5ism0Yz7FmTsQQIsj4Z/vYxWmctwyqZV x8og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iWaSXOj8; spf=pass (google.com: domain of linux-kernel+bounces-5144-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5144-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id bi11-20020a170902bf0b00b001d08f1a597asi18992489plb.285.2023.12.19.04.07.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 04:07:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-5144-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iWaSXOj8; spf=pass (google.com: domain of linux-kernel+bounces-5144-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-5144-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 60739286F8A for ; Tue, 19 Dec 2023 12:07:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2938E171B9; Tue, 19 Dec 2023 12:06:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iWaSXOj8" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 945061862E for ; Tue, 19 Dec 2023 12:06:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-40d2e56f3a6so601745e9.1 for ; Tue, 19 Dec 2023 04:06:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702987610; x=1703592410; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QX0/am4IjBACVtJR4SW9C9khWxbgbpT1N87hAG7O6Og=; b=iWaSXOj8ZxeKTjuWY9iYRCPBfwGDILkaMEHeG8ba6e2MgV6Mh7I3Ed0dNcynCCU4h5 2inOync0si6oLnwjlBeCxv7eYMmUOe9VZRpz7vxkWilYsu3uNv6/OqVLKNemA8p6kSw0 3ocFVkq1FFuv7JUhFa4V4Jm7GFlaV3mT8VQlspLnEWIymWgcyd/Lf7zQn/A/9trtGV1W e4zsTuw1AI+ft8qod85ZWmGa6gHOlsU77LHdUvyoaaCC5KjAJBI4nZ4G5FYIKo+x7WHb SCF/lzVn3TqKJ85s3H5Kwc3d9xrnNDl9qSq2LlLeQk7WyapIM+ly3dcy8kEqZ3D0VhKE bnKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702987610; x=1703592410; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QX0/am4IjBACVtJR4SW9C9khWxbgbpT1N87hAG7O6Og=; b=aTvJE8pTjaPGKmbl4fNxKihqrpU6Ka6NlxiJF3I5g/zR0qI1Om2iK1wb3ioVtDXAtJ rwK5nYIA8uJeRbQmJlHVDbJgDnrufGRCPUg0w2WGtGMTjUQzWQ8FqjC+skCbGOi4oK6B +k+r5PAfdzbXlWoyGIjoZYP25BVDCmZIZDuLrOg0Z5O61GdOugxnffxjX9pcxKk7WqOr 3U/PGFQxWJutxzn8D0oT+QijRyzDriNDdqi+ns5P+JTomxFmJkN40sFlKhCPrGfSU3AX R2CaaMhc8kZ1mzr3XKOYax0ALpzo7X5ja5ULq/kJb9UQvOdZ7t+G2pDrJ0UEEnITQhhc UA9Q== X-Gm-Message-State: AOJu0Yx01cMyKACa6HRfalDGkQNHxJyZE75eZN+s3Ut1jKihzXbOgJfi ROUZuHFLrb7izh5RvMpi+Or7PKZ+awIHbU0YmDX8DgVUiDaULQ== X-Received: by 2002:a05:600c:5119:b0:40c:6e48:a5f8 with SMTP id o25-20020a05600c511900b0040c6e48a5f8mr480826wms.17.1702987609862; Tue, 19 Dec 2023 04:06:49 -0800 (PST) Received: from [192.168.100.86] ([37.228.218.3]) by smtp.gmail.com with ESMTPSA id c6-20020a5d4cc6000000b0033662c2820bsm7241359wrt.117.2023.12.19.04.06.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Dec 2023 04:06:49 -0800 (PST) Message-ID: Date: Tue, 19 Dec 2023 12:06:48 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 20/34] media: iris: add video hardware internal buffer count and size calculation Content-Language: en-US To: Dikshita Agarwal , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stanimir.k.varbanov@gmail.com, quic_vgarodia@quicinc.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org, bryan.odonoghue@linaro.org Cc: linux-arm-msm@vger.kernel.org, quic_abhinavk@quicinc.com References: <1702899149-21321-1-git-send-email-quic_dikshita@quicinc.com> <1702899149-21321-21-git-send-email-quic_dikshita@quicinc.com> From: Bryan O'Donoghue In-Reply-To: <1702899149-21321-21-git-send-email-quic_dikshita@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/12/2023 11:32, Dikshita Agarwal wrote: > drivers/media/platform/qcom/vcodec/iris/Makefile | 1 + > .../media/platform/qcom/vcodec/iris/iris_buffer.c | 48 ++ > .../media/platform/qcom/vcodec/iris/iris_common.h | 1 + > .../media/platform/qcom/vcodec/iris/iris_core.h | 2 + > .../media/platform/qcom/vcodec/iris/iris_helpers.c | 13 + > .../media/platform/qcom/vcodec/iris/iris_helpers.h | 4 + > .../platform/qcom/vcodec/iris/iris_instance.h | 2 + > .../media/platform/qcom/vcodec/iris/iris_vdec.c | 1 + > .../media/platform/qcom/vcodec/iris/vpu_common.h | 8 + > .../media/platform/qcom/vcodec/iris/vpu_iris3.c | 6 + > .../platform/qcom/vcodec/iris/vpu_iris3_buffer.c | 201 +++++ > .../platform/qcom/vcodec/iris/vpu_iris3_buffer.h | 845 +++++++++++++++++++++ So, unless the code you are adding effects existing upstream venus, I think it would be a bit easier to review if you squashed down changes that pertain to Iris only. For example this patch seems to relate to Iris only, so why is it a progressive change within your series. Similar comment for "add vb2 streaming and buffer ops" and other "add feature x" patches in this series. If the change is contained to your own codebase, then progressive changes are more noise than content. Please try to squash down changes - to reduce the number of patches and the total LOC being proposed here. --- bod