Received-SPF: pass (google.com: domain of linux-kernel+bounces-5140-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <f2f31c85-70e4-4a2b-b791-73433cdaf881@linaro.org>
Date: Tue, 19 Dec 2023 13:05:46 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] thermal: core: Print out thermal zone name on
 update_temperature error
Content-Language: en-US
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
 "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Zhang Rui <rui.zhang@intel.com>, Lukasz Luba <lukasz.luba@arm.com>,
 Marijn Suijten <marijn.suijten@somainline.org>, linux-pm@vger.kernel.org,
 linux-kernel@vger.kernel.org, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
References: <20231218-topic-thermaldbg-v1-1-451bcb723e1d@linaro.org>
 <CAJZ5v0gkko7nWH2ePwEhbfXR-jAb9+f+rsfYXKBMSz04uW4rYg@mail.gmail.com>
 <1e151dcf-d4fc-4aec-9f68-c8ef372a00f2@linaro.org>
From: Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <1e151dcf-d4fc-4aec-9f68-c8ef372a00f2@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


Hi Konrad,

[Cc: Angelo]

On 19/12/2023 12:48, Konrad Dybcio wrote:
> On 18.12.2023 20:40, Rafael J. Wysocki wrote:
>> On Mon, Dec 18, 2023 at 3:40 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>>
>>> Currently, we can encounter an error like this:
>>>
>>>    thermal thermal_zone48: failed to read out thermal zone (-19)
>>>
>>> It's good to know that there's been an issue, but on some occasions
>>> (like the error happening in the middle of a platform crash), one may
>>> not be able to look up what kind of thermal zone that is.
>>>
>>> Add the TZ name to the error message in order to speed up debugging.
>>
>> s/name/type/ ?  It looks like that's what you mean.
>>
>> First, the tz type is not its name (because there may be multiple
>> zones of the same type) and it would be consistent with the first
>> paragraph above.
> That's possible, I'm no expert wrt thermal :)
> 
> Would you be okay with this change, together with an amended commit
> message?

Angelo is looking for how to sort out the name vs type confusion [1].

May be you should wait he comes with a proposal before updating the message?

[1] 
https://lore.kernel.org/all/3428b2af-5522-4090-995a-10eaee90c28e@linaro.org/

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog