Received-SPF: pass (google.com: domain of linux-kernel+bounces-5141-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20231219115423.222134-1-ammarfaizi2@gnuweeb.org> <20231219115423.222134-3-ammarfaizi2@gnuweeb.org>
In-Reply-To: <20231219115423.222134-3-ammarfaizi2@gnuweeb.org>
From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Date: Tue, 19 Dec 2023 19:05:44 +0700
Message-ID: <CAOG64qMdX08_apxfsvxg1wvyo7EWv9K-Swti3AN2vt_Lxfdcjw@mail.gmail.com>
Subject: Re: [PATCH liburing v1 2/2] t/no-mmap-inval: Replace `valloc()` with `t_posix_memalign()`
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Jens Axboe <axboe@kernel.dk>, Michael William Jonathan <moe@gnuweeb.org>, 
	io-uring Mailing List <io-uring@vger.kernel.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, 
	"GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 19, 2023 at 6:54=E2=80=AFPM Ammar Faizi wrote:
> Address the limitations of valloc(). This function, which is primarily
> used for allocating page-aligned memory, is not only absent in some
> systems but is also marked as obsolete according to the `man 3 valloc`.
>
> Replace valloc() with t_posix_memalign() to fix the following build
> error:
>
>   no-mmap-inval.c:28:56: warning: call to undeclared function 'valloc'; I=
SO C99 and \
>   later do not support implicit function declarations [-Wimplicit-functio=
n-declaration]
>           p.cq_off.user_addr =3D (unsigned long long) (uintptr_t) valloc(=
8192);
>                                                                 ^
>   1 warning generated.
>
>   ld.lld: error: undefined symbol: valloc
>   >>> referenced by no-mmap-inval.c:28
>   >>>               /tmp/no-mmap-inval-ea16a2.o:(main)
>   >>> did you mean: calloc
>   >>> defined in: /system/lib64/libc.so
>   clang-15: error: linker command failed with exit code 1 (use -v to see =
invocation)
>   make[1]: *** [Makefile:239: no-mmap-inval.t] Error 1
>
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>

Reviewed-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>

-- Viro