Received-SPF: pass (google.com: domain of linux-kernel+bounces-5147-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <50eb1dd6-f7b8-478a-8ddb-1c7d9bdbe413@linaro.org>
Date: Tue, 19 Dec 2023 12:10:57 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 00/34] Qualcomm video encoder and decoder driver
Content-Language: en-US
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
 Dikshita Agarwal <quic_dikshita@quicinc.com>, linux-media@vger.kernel.org,
 linux-kernel@vger.kernel.org, stanimir.k.varbanov@gmail.com,
 quic_vgarodia@quicinc.com, agross@kernel.org, andersson@kernel.org,
 konrad.dybcio@linaro.org, mchehab@kernel.org, bryan.odonoghue@linaro.org
Cc: linux-arm-msm@vger.kernel.org, quic_abhinavk@quicinc.com
References: <1702899149-21321-1-git-send-email-quic_dikshita@quicinc.com>
 <a033dfc5-dcf1-4969-ad4d-1836ff9ff0a3@linaro.org>
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
In-Reply-To: <a033dfc5-dcf1-4969-ad4d-1836ff9ff0a3@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 18/12/2023 18:38, Dmitry Baryshkov wrote:
> On 18/12/2023 13:31, Dikshita Agarwal wrote:
>> This patch series introduces support for Qualcomm new video acceleration
>> hardware architecture, used for video stream decoding/encoding. This 
>> driver
>> is based on new communication protocol between video hardware and 
>> application
>> processor.
> 
> This doesn't answer one important point, you have been asked for v1. 
> What is the actual change point between Venus and Iris? What has been 
> changed so much that it demands a separate driver. This is the main 
> question for the cover letter, which has not been answered so far.
> 
>  From what I see from you bindings, the hardware is pretty close to what 
> we see in the latest venus generations. I asssme that there was a change 
> in the vcodec inteface to the firmware and other similar changes. Could 
> you please point out, which parts of Venus driver do no longer work or 
> are not applicable for sm8550?

I'd like to hear this detail too.

Grazing on some of the patches here I saw were we adding vb2 buffer ops, 
which is already supported by venus.

Similar question on booting cores and doing a busy/wait instead of a 
rendezvous based on an IRQ.

I feel there's a version of this series that can probably unify the 
codebases but, am open to being told how that is incorrect.

---
bod