Received-SPF: pass (google.com: domain of linux-kernel+bounces-5160-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <b7ae6ca1-efb4-0f35-8f83-ecd28ab16632@linux.alibaba.com>
Date: Tue, 19 Dec 2023 20:22:34 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: [PATCH net-next v7 07/10] net/smc: compatible with 128-bits
 extended GID of virtual ISM device
To: Simon Horman <horms@kernel.org>
Cc: wintera@linux.ibm.com, wenjia@linux.ibm.com, hca@linux.ibm.com,
 gor@linux.ibm.com, agordeev@linux.ibm.com, davem@davemloft.net,
 edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
 kgraul@linux.ibm.com, jaka@linux.ibm.com, borntraeger@linux.ibm.com,
 svens@linux.ibm.com, alibuda@linux.alibaba.com, tonylu@linux.alibaba.com,
 raspl@linux.ibm.com, schnelle@linux.ibm.com,
 guangguan.wang@linux.alibaba.com, linux-s390@vger.kernel.org,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231219084536.8158-1-guwen@linux.alibaba.com>
 <20231219084536.8158-8-guwen@linux.alibaba.com>
 <20231219115952.GL811967@kernel.org>
From: Wen Gu <guwen@linux.alibaba.com>
In-Reply-To: <20231219115952.GL811967@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2023/12/19 19:59, Simon Horman wrote:
> On Tue, Dec 19, 2023 at 04:45:33PM +0800, Wen Gu wrote:
>> According to virtual ISM support feature defined by SMCv2.1, GIDs of
>> virtual ISM device are UUIDs defined by RFC4122, which are 128-bits
>> long. So some adaptation work is required. And note that the GIDs of
>> existing platform firmware ISM devices still remain 64-bits long.
>>
>> Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
>> Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
> 
> ...
> 
>> @@ -1023,9 +1041,12 @@ smcd_clc_prep_confirm_accept(struct smc_connection *conn,
>>   	if (version == SMC_V1) {
>>   		clc->hdr.length = htons(SMCD_CLC_ACCEPT_CONFIRM_LEN);
>>   	} else {
>> -		clc->d1.chid = htons(smc_ism_get_chid(smcd));
>> +		chid = smc_ism_get_chid(smcd);
>> +		clc->d1.chid = htons(chid);
>>   		if (eid && eid[0])
>>   			memcpy(clc->d1.eid, eid, SMC_MAX_EID_LEN);
>> +		if (__smc_ism_is_virtual(chid))
>> +			clc->d1.gid_ext = htonll(smcd_gid.gid_ext);
> 
> Hi Wen Gu,
> 
> The type of clc->d1.gid_ext is u64 (host byte-order)
> but here it is being assigned a big endian value.
> This does not seem correct.
> 
> Flagged by Smatch.

Oh, thank you Simon! That's a regression. I mistakenly changed the type
to u64 instead of __be64 in previous versions when fixing conflicts.
Thank you very much for the catch.

> 
>>   		len = SMCD_CLC_ACCEPT_CONFIRM_LEN_V2;
>>   		if (first_contact) {
>>   			*fce_len = smc_clc_fill_fce_v2x(fce_v2x, ini);
> 
> ...
>