Received-SPF: pass (google.com: domain of linux-kernel+bounces-5228-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 19 Dec 2023 13:01:46 +0000
From: Matthew Wilcox <willy@infradead.org>
To: Jingbo Xu <jefflexu@linux.alibaba.com>
Cc: shr@devkernel.io, akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, joseph.qi@linux.alibaba.com,
	linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mm: fix arithmetic for max_prop_frac when setting
 max_ratio
Message-ID: <ZYGUOslxxwe1sNzR@casper.infradead.org>
References: <20231219024246.65654-1-jefflexu@linux.alibaba.com>
 <20231219024246.65654-3-jefflexu@linux.alibaba.com>
 <ZYEWyn5g/jG/ixMk@casper.infradead.org>
 <5460aaf1-44f6-475f-b980-cb9058cc1df4@linux.alibaba.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5460aaf1-44f6-475f-b980-cb9058cc1df4@linux.alibaba.com>

On Tue, Dec 19, 2023 at 01:58:21PM +0800, Jingbo Xu wrote:
> On 12/19/23 12:06 PM, Matthew Wilcox wrote:
> > On Tue, Dec 19, 2023 at 10:42:46AM +0800, Jingbo Xu wrote:
> >>  	} else {
> >>  		bdi->max_ratio = max_ratio;
> >> -		bdi->max_prop_frac = (FPROP_FRAC_BASE * max_ratio) / 100;
> >> +		bdi->max_prop_frac = div64_u64(FPROP_FRAC_BASE * max_ratio,
> >> +					       100 * BDI_RATIO_SCALE);
> >>  	}
> > 
> > Why use div64_u64 here?
> > 
> > FPROP_FRAC_BASE is an unsigned long.  max_ratio is an unsigned int, so
> > the numerator is an unsigned long.  BDI_RATIO_SCALE is 10,000, so the
> > numerator is an unsigned int.  There's no 64-bit arithmetic needed here.
> 
> Yes, div64_u64() is actually not needed here. So it seems
> 
> bdi->max_prop_frac = FPROP_FRAC_BASE * max_ratio / 100 / BDI_RATIO_SCALE;
> 
> is adequate?

I'd rather spell that as:

		bdi->max_prop_frac = (FPROP_FRAC_BASE * max_ratio) /
					(100 * BDI_RATIO_SCALE);

It's closer to how you'd write it out mathematically and so it reads
more easily.  At least for me.