Received-SPF: pass (google.com: domain of linux-kernel+bounces-5398-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Frank Li <Frank.li@nxp.com>
CC: "imx@lists.linux.dev" <imx@lists.linux.dev>, Jingoo Han
	<jingoohan1@gmail.com>, Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Manivannan Sadhasivam <mani@kernel.org>, Lorenzo Pieralisi
	<lpieralisi@kernel.org>, =?iso-8859-2?Q?Krzysztof_Wilczy=F1ski?=
	<kw@linux.com>, Rob Herring <robh@kernel.org>, Bjorn Helgaas
	<bhelgaas@google.com>, Jon Mason <jdmason@kudzu.us>, "open list:PCI DRIVER
 FOR SYNOPSYS DESIGNWARE" <linux-pci@vger.kernel.org>, open list
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] PCI: dwc: Fix BAR0 wrong map to iATU6 after root
 complex reinit endpoint
Thread-Topic: [PATCH 1/1] PCI: dwc: Fix BAR0 wrong map to iATU6 after root
 complex reinit endpoint
Thread-Index: AQHaMja1NResTHTkFE6//FhBs62b57CwYdiAgABGuYCAAAUWgA==
Date: Tue, 19 Dec 2023 14:38:34 +0000
Message-ID: <ZYGq6RdCfdhXFF/9@x1-carbon>
References: <20231219044844.1195294-1-Frank.Li@nxp.com>
 <ZYFrUWM7JXdv7rtb@x1-carbon> <ZYGmpaf18pJgM/qj@lizhi-Precision-Tower-5810>
In-Reply-To: <ZYGmpaf18pJgM/qj@lizhi-Precision-Tower-5810>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-8859-2?Q?o+yuFT5qQdxtjcXN7NM/vTFgu/mn/cP+lr0bArLpuRQBFKhcfnLLQSnJD2?=
 =?iso-8859-2?Q?gCje6VXFUyj1ueZRhHK/nvdP4pjan3qGXbDF4VtTIwxdLscwE/lVq7IvXQ?=
 =?iso-8859-2?Q?ASToi0FmzRmlpIS2eIad3N66d44avKIY49T7jSe/1gFj2jhW5RUJR2hDeE?=
 =?iso-8859-2?Q?FkJWazDZ2YnNZsBPLtfC58S5k7TZ08RnAV2P96ugW2k/VVuVyq98AeqXJP?=
 =?iso-8859-2?Q?kR2snJDsMMqr1g8QYtwVp/SjLm56ajuHpzCCGyLof/pK7r/+uz/XBzhdiU?=
 =?iso-8859-2?Q?imom1lnmIgnOzRDymds2voBKwbD+dDvRhaPQGftngueqW69Z9IMaqvrF6P?=
 =?iso-8859-2?Q?uyUlTDIo9Yc/xs+eLt2PRvJvkjN6aEbQoezu7A+Tr00UayqmfQYDSETv4V?=
 =?iso-8859-2?Q?Y4KKu7OC8EPnjKbImUaYIP6H/4lz2PH32GDWgrviieSu5N4yXEVWJBklH7?=
 =?iso-8859-2?Q?LiqZqNbkviyIbuHGC35hVFR+soIDmpho9bRzqF5Pv8w2etjQLcTrhXq6sc?=
 =?iso-8859-2?Q?l+FqVdvGD/Pw27R6rdSYyocgcSgfMibxjieak1GAJXts2aJpKne/VN0Vv5?=
 =?iso-8859-2?Q?oQiLO6fMFTCMeoClYgpiS0Cfr0IYmGZvR4TWbYd/jDG2cHE6IwY1cITLij?=
 =?iso-8859-2?Q?P28dLyqIMWqdBrZ81IKwE0JKW4yRuWAkLbuEKkPCag0dZGD5UKibOQxS6D?=
 =?iso-8859-2?Q?YqnMP4EAXot4+PtXuRcKxKLOxIPzrqZFJ1TCx5BMYKV/oOogmQPxu8DK/s?=
 =?iso-8859-2?Q?hyNql43zf43MvjmdoacTqaeajX+V/ix4D8yYqjtnqHo1E7hFRFYHEh5iV6?=
 =?iso-8859-2?Q?94iChVpzxqgcsG7KWbalRzF53V0iCGVfONOuiSl7DJDVPi6aE4yDBUFyFp?=
 =?iso-8859-2?Q?EuZvetCdabbAjjbEECSWb5ab/+FBdpBzEAI9FqblXPvJBEcPql+eKqkPxB?=
 =?iso-8859-2?Q?94riM4XAoFgdXXmz6dn+QJ1Aby6ooL+OSHW7W1GMSuujx/pS/esSsuwXSY?=
 =?iso-8859-2?Q?ophlvU23Mp6XuMHd/x2l8JVx7R6FyU4XnjHOTh/rz2WzZGbtbbsGfcnQkM?=
 =?iso-8859-2?Q?zjv2J6pm9/VOd5yJkh0KngGaLkb/c9o4IyiLu+MfUKvm0i0bItOvyxWQrK?=
 =?iso-8859-2?Q?Dy/CvaqTnIvl7lZsHCIR+MaIp9/z2gnYT630/o5So7Rnqd+Fk1S3LK45g2?=
 =?iso-8859-2?Q?ySnkz5vNh2Q5dNlLFtI3qJvAngYBZORzZ8ONXYasTH5S1msG+7JmF1Tejk?=
 =?iso-8859-2?Q?GgOGXhh07iNpR1lfYpQ7H0id0HUSb4l/ZBMBVg174Iq6M2HCK5AUDSIRPz?=
 =?iso-8859-2?Q?t7VCQnRZfBon/gsHsGUQhMg+haqK9urJmv87ff9OLrk7ImQJjjwmUb0Ofm?=
 =?iso-8859-2?Q?7+PpLQPFv8h39BkjXIGpOWlBlsEGoqi3jXGwIez2kwoSmWciMYXeXlxS3r?=
 =?iso-8859-2?Q?xvMDyF1EQF0x87hcPg4Q5c5+HFFVWJGMVl4xmj6cQsAxPXeVWVd/cDbORH?=
 =?iso-8859-2?Q?iMIPtaIIG2IXPzVfuC3kOBHY8HkljCpMhduyr9A6gwEtVZMkTqX1bhVFUu?=
 =?iso-8859-2?Q?MZlDaXnQ1boVYzXPP8DddE3p6QMhUitiHAu5k12RzIyWepu0NqwaTFvjCP?=
 =?iso-8859-2?Q?6u52EEkk3JACOJN6JYhgskeFoxO2ZiGESBlx1l0QMH29R81hDPce53JA?=
 =?iso-8859-2?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-2"
Content-ID: <53AAACE1FC9C464697DE0F7228A4727A@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	SI1vh3gANpiOiK/ZFuM9H+i1U/HfsjG85U0bgtpLU3kUBSKOYLerJREN4YBbOz5c6HGqC8gKkBt0A8Z602gJ3OwxHrM5PS1bsirTsg0K5PNYdv7QzYORgE69yrnbjthh/kYVsBhCwjLQQdibDmgJxUSuffEU6U/g34HQ7eAUkInXaSURs37a0CDaZW7pJZO3XsP1JTMCcYc7Bdb7RRNRr9ldYBNalaqhAOBD1hxkrIs494Qn4+xsPeihHCclPX9fhsJcpniLVYe2wIsR7rFz0KQ5KU5/sQzwo8oUeW4uRF31LXC9R0vzTHO3E5Ap0HaFu1XkxoprthHctwceATWfXVCk0xg3avKVDumw0VcUFEt5Emkb3ObUY6e7W7qXpK3k/Mv6jbdqwxF3m+rYnqGDpFvYdRzKYDwCLGNDhvWX00XKY6VHIHIuetfb8NXhrd1Qr82r9h0uf8KqdxuBppyh+jLPdKcCJyYtSwM/2p4EuaMd8ZCFnR5cvK7eRvb9tImmcdN+Z4c9IhZb5SBmufv3qO2obiZbpR3wSgwQ4FknVpRgl0CAJlIxwsghtnW1nqfp0BK1HbPNclHh/C1+XIeAt/dXKxp/tmAMZWIumABLQAUyyXb83aNsryL9PCgntGnK
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6272.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fce85d47-d1e2-4ec4-dae1-08dc00a02e35
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2023 14:38:34.9216
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +27xxZ3TBrL10QOWLpmtMT037KyPav4eRFE2I+0DeSczq4mGsQpTxZp0vaYrj59QmmlpVQ0/vbeJIOfzNGltMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6301

On Tue, Dec 19, 2023 at 09:20:21AM -0500, Frank Li wrote:
> On Tue, Dec 19, 2023 at 10:07:14AM +0000, Niklas Cassel wrote:
> > On Mon, Dec 18, 2023 at 11:48:43PM -0500, Frank Li wrote:
> > > dw_pcie_ep_inbound_atu()
> > > {
> > > 	...
> > > 	if (!ep->bar_to_atu[bar])
> > > 		free_win =3D find_first_zero_bit(ep->ib_window_map, pci->num_ib_win=
dows);
> > > 	else
> > > 		free_win =3D ep->bar_to_atu[bar];
> > > 	...
> > > }
> > >=20
> > > The atu index 0 is valid case for atu number. The find_first_zero_bit=
()
> > > will return 6 when second time call into this function if atu is 0. S=
uppose
> > > it should use branch 'free_win =3D ep->bar_to_atu[bar]'.
> > >=20
> > > Change 'bar_to_atu' to s8. Initialize bar_to_atu as -1 to indicate it=
 have
> > > not allocate atu to the bar.
> > >=20
> > > Reported-by: Niklas Cassel <Niklas.Cassel@wdc.com>
> > > Close: https://lore.kernel.org/linux-pci/ZXt2A+Fusfz3luQV@x1-carbon/T=
/#u
> > > Fixes: 4284c88fff0e ("PCI: designware-ep: Allow pci_epc_set_bar() upd=
ate inbound map address")
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > >=20
> > > Notes:
> > >     @Niklas:
> > >     	I have not test your case. I should be equal to previous's fix i=
n
> > >     mail list.
> >=20
> > Hello Frank,
> >=20
> > Thank you for sending a proper fix for this!
> >=20
> > Personally, I slightly prefer your fix that saves the iatu index + 1, a=
nd
> > keeps 0 to mean unused. That way, you don't need the memset, and you do=
n't
> > need to change the type to signed, but either way is fine by me, so:
>=20
> index + 1 don't match hardware iATU index. It will be confused because
> other parts is 0 based.
>=20
> So I choose "-1" as free iATU.

A s8 can hold a max value of 127.
CX_ATU_NUM_OUTBOUND_REGIONS seems to be 0-255.

Since the DWC code can be synthesized with 256 iATUs,
your code will not work on systems with 128 or more iATUs.

If we continue to use a u8, and offset the saved value by one,
we will at least be able to support 255-1 =3D=3D 254 iATUs.


Kind regards,
Niklas=