Received-SPF: pass (google.com: domain of linux-kernel+bounces-5440-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 19 Dec 2023 16:58:07 +0200
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Mark Hasemeyer <markhas@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Raul Rangel <rrangel@chromium.org>,
	David Gow <davidgow@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mark Brown <broonie@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Takashi Iwai <tiwai@suse.de>,
	Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v1 5/6] platform: Modify platform_get_irq_optional() to
 use resource
Message-ID: <ZYGvf0kH9EHfJKUc@smile.fi.intel.com>
References: <20231213110009.v1.1.Ifd0903f1c351e84376d71dbdadbd43931197f5ea@changeid>
 <20231213110009.v1.5.Ife9ebad2bbfbab3a05e90040f344d750aa0aac7e@changeid>
 <ZXoLbt7jNrmC0VbQ@smile.fi.intel.com>
 <CANg-bXDUxMvm2tmHZVz4Mh=o3VMmO2ZTT2547RZEcwDkn2FUeQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANg-bXDUxMvm2tmHZVz4Mh=o3VMmO2ZTT2547RZEcwDkn2FUeQ@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Mon, Dec 18, 2023 at 01:23:35PM -0700, Mark Hasemeyer wrote:

...

> > Consider combine the above to use fwnode_irq_get() in the separate prerequisite
> > change.
> 
> I like the idea. It doesn't look like 'struct fwnode_operations'
> provides a way to retrieve information in a 'struct resource' format.

It can be added, but it's orthogonal to this series. What I suggest is
to unify them here followed by your patch in this series. I.o.w. add
one more patch as a prerequisite.

> Perhaps this could be followed up on in a separate patch train?

Definitely, but again, not (directly) related to this series.

...

> > > +                     irqd_set_trigger_type(irqd, r->flags & IORESOURCE_BITS);
> >
> > NIH resource_type().
> >
> > > +     }
> > >       return ret;
> 
> Does NIH mean "not invented here"?

Yes.

> resource_type() masks
> IORESOURCE_TYPE_BITS, not IORESOURCE_BITS. I'm not quite sure what you
> mean here.

Ah, my bad, indeed, you are right.

-- 
With Best Regards,
Andy Shevchenko